[jira] [Commented] (IGNITE-11935) Checkstyle must support NewlineAtEndOfFile rule

2019-06-26 Thread Aleksey Plekhanov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873447#comment-16873447
 ] 

Aleksey Plekhanov commented on IGNITE-11935:


[~Mmuzaf] looks good to me. Merged to master. 

Thanks for the contribution!

> Checkstyle must support NewlineAtEndOfFile rule
> ---
>
> Key: IGNITE-11935
> URL: https://issues.apache.org/jira/browse/IGNITE-11935
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>  Labels: checkstyle
> Fix For: 2.8
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add support {{}} to the checkstyle plugin.
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-11935) Checkstyle must support NewlineAtEndOfFile rule

2019-06-19 Thread Maxim Muzafarov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867893#comment-16867893
 ] 

Maxim Muzafarov commented on IGNITE-11935:
--

[~alex_pl]

Changes are ready for review. Can you take a look at?

{{Run-All}} results are not provided since only blank lines added/removed. I've 
attached results of Check Style suite and Build Apache Ignite suite to this 
issue.

> Checkstyle must support NewlineAtEndOfFile rule
> ---
>
> Key: IGNITE-11935
> URL: https://issues.apache.org/jira/browse/IGNITE-11935
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>  Labels: checkstyle
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add support {{}} to the checkstyle plugin.
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)