[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892901#comment-16892901 ] Denis Chudov commented on IGNITE-11979: --- [~amashenkov], I've done fixes and left comment. Please take a look once again. > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887899#comment-16887899 ] Andrew Mashenkov commented on IGNITE-11979: --- [~Denis Chudov], I've left few comments to the PR. Please, take a look. > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886993#comment-16886993 ] Denis Chudov commented on IGNITE-11979: --- [~jooger], could you also review my changes, please? > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885980#comment-16885980 ] Sergey Antonov commented on IGNITE-11979: - [~Denis Chudov] Changes looks good for me > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885935#comment-16885935 ] Denis Chudov commented on IGNITE-11979: --- [~antonovsergey93], done > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885934#comment-16885934 ] Ignite TC Bot commented on IGNITE-11979: {panel:title=-- Run :: All: Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Cache 6{color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=4318886]] {color:#d04437}ZooKeeper (Discovery) 3{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=4318911]] {panel} [TeamCity *-- Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=4318932buildTypeId=IgniteTests24Java8_RunAll] > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885178#comment-16885178 ] Sergey Antonov commented on IGNITE-11979: - [~Denis Chudov] I found failed indexing suite ({{PDS (Indexing)}}). Your changes relates with indexing. Please re-run blockers in your visa! > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884920#comment-16884920 ] Denis Chudov commented on IGNITE-11979: --- [~antonovsergey93], could you review my code pls? > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884919#comment-16884919 ] Denis Chudov commented on IGNITE-11979: --- Blockers are not related to my commit. > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11979) Add ability to set default parallelizm of rebuild indexes in configuration
[ https://issues.apache.org/jira/browse/IGNITE-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884918#comment-16884918 ] Ignite TC Bot commented on IGNITE-11979: {panel:title=-- Run :: All: Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}PDS (Indexing){color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=4318897]] {color:#d04437}Cache 6{color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=4318886]] {color:#d04437}ZooKeeper (Discovery) 3{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=4318911]] {panel} [TeamCity *-- Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=4318932buildTypeId=IgniteTests24Java8_RunAll] > Add ability to set default parallelizm of rebuild indexes in configuration > -- > > Key: IGNITE-11979 > URL: https://issues.apache.org/jira/browse/IGNITE-11979 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Denis Chudov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We can't change SchemaIndexCacheVisitorImpl#DFLT_PARALLELISM at the moment: > {code:java} > /** Default degree of parallelism. */ > private static final int DFLT_PARALLELISM = Math.min(4, Math.max(1, > Runtime.getRuntime().availableProcessors() / 4)); > {code} > On huge servers with a lot of cores (such as 56) we will rebuild indexes in 4 > threads. I think we should have ability to set DFLT_PARALLELISM in Ignite > configuration. -- This message was sent by Atlassian JIRA (v7.6.14#76016)