[jira] [Commented] (IGNITE-12256) Fix double invocation of javaMajorVersion in scripts

2019-10-04 Thread Peter Ivanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944753#comment-16944753
 ] 

Peter Ivanov commented on IGNITE-12256:
---

Looks good to me.

> Fix double invocation of javaMajorVersion in scripts
> 
>
> Key: IGNITE-12256
> URL: https://issues.apache.org/jira/browse/IGNITE-12256
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.7.6
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Most of our shell script look as folows:
> {code}
> #
> # Discover path to Java executable and check it's version.
> #
> checkJava
> #
> # Discover IGNITE_HOME environment variable.
> #
> setIgniteHome
> #
> # Final JVM_OPTS for Java 9+ compatibility
> #
> javaMajorVersion "${JAVA_HOME}/bin/java"
> {code}
> It makes no sense to me since we already call javaMajorVersion in checkJava. 
> Let's try to get rid of it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12256) Fix double invocation of javaMajorVersion in scripts

2019-10-03 Thread Ilya Kasnacheev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943551#comment-16943551
 ] 

Ilya Kasnacheev commented on IGNITE-12256:
--

[~vveider] please review proposed fix.

> Fix double invocation of javaMajorVersion in scripts
> 
>
> Key: IGNITE-12256
> URL: https://issues.apache.org/jira/browse/IGNITE-12256
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.7.6
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Most of our shell script look as folows:
> {code}
> #
> # Discover path to Java executable and check it's version.
> #
> checkJava
> #
> # Discover IGNITE_HOME environment variable.
> #
> setIgniteHome
> #
> # Final JVM_OPTS for Java 9+ compatibility
> #
> javaMajorVersion "${JAVA_HOME}/bin/java"
> {code}
> It makes no sense to me since we already call javaMajorVersion in checkJava. 
> Let's try to get rid of it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12256) Fix double invocation of javaMajorVersion in scripts

2019-10-03 Thread Ilya Kasnacheev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943549#comment-16943549
 ] 

Ilya Kasnacheev commented on IGNITE-12256:
--

Also need to fix versions such as
{code}
openjdk version "9-Ubuntu"
OpenJDK Runtime Environment (build 9-Ubuntu+0-9b181-4)
OpenJDK 64-Bit Server VM (build 9-Ubuntu+0-9b181-4, mixed mode)
{code}
as in IGNITE-9836

> Fix double invocation of javaMajorVersion in scripts
> 
>
> Key: IGNITE-12256
> URL: https://issues.apache.org/jira/browse/IGNITE-12256
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 2.7.6
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> Most of our shell script look as folows:
> {code}
> #
> # Discover path to Java executable and check it's version.
> #
> checkJava
> #
> # Discover IGNITE_HOME environment variable.
> #
> setIgniteHome
> #
> # Final JVM_OPTS for Java 9+ compatibility
> #
> javaMajorVersion "${JAVA_HOME}/bin/java"
> {code}
> It makes no sense to me since we already call javaMajorVersion in checkJava. 
> Let's try to get rid of it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)