[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003330#comment-17003330
]
Ignite TC Bot commented on IGNITE-12371:
{panel:title=Branch: [pull/7196/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4876650&buildTypeId=IgniteTests24Java8_RunAll]
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: newbie
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003331#comment-17003331
]
Ignite TC Bot commented on IGNITE-12371:
{panel:title=Branch: [pull/7196/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4876650&buildTypeId=IgniteTests24Java8_RunAll]
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: newbie
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003171#comment-17003171
]
Nikolay Izhikov commented on IGNITE-12371:
--
LGTM
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: newbie
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003165#comment-17003165
]
Ivan Pavlukhin commented on IGNITE-12371:
-
I raised a [PR|https://github.com/apache/ignite/pull/7196]. TC visa is on the
way. [~mstepachev], [~nizhikov], could you please take a look?
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996673#comment-16996673
]
Nikolay Izhikov commented on IGNITE-12371:
--
Hello, [~mstepachev]
Any news about this ticket?
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974171#comment-16974171
]
Stepachev Maksim commented on IGNITE-12371:
---
[~nizhikov] I didn't. I decided that the tests refactor is time waste.
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974126#comment-16974126
]
Nikolay Izhikov commented on IGNITE-12371:
--
Hello, [~mstepachev]
Great news. Looking forward for your contribution.
Did you refactor tests for a new method?
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974120#comment-16974120
]
Stepachev Maksim commented on IGNITE-12371:
---
[~nizhikov] Hi, I added it. In another ticket.
[https://github.com/gridgain/gridgain/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java#L889]
and will donate it.
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12371) Explicit method for starting client nodes
[
https://issues.apache.org/jira/browse/IGNITE-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974117#comment-16974117
]
Anton Vinogradov commented on IGNITE-12371:
---
Obviously, 500 explicit usages should be refactored as a part of this issue.
> Explicit method for starting client nodes
> -
>
> Key: IGNITE-12371
> URL: https://issues.apache.org/jira/browse/IGNITE-12371
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Priority: Major
> Labels: newbie
>
> Right now there is almost 500 explicit usage of {{setClientMode}} in tests.
> Seems we should support the starting of client nodes in test framework.
> We should introduce method {{startClientNode(String name)}} and similar.
> This will simplify tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
