[jira] [Commented] (IGNITE-12504) Auto-adjust breaks existing code, should be disabled by default
[
https://issues.apache.org/jira/browse/IGNITE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027512#comment-17027512
]
Maxim Muzafarov commented on IGNITE-12504:
--
[~akalashnikov][~ilyak]
So, let's close the issue, right?
> Auto-adjust breaks existing code, should be disabled by default
> ---
>
> Key: IGNITE-12504
> URL: https://issues.apache.org/jira/browse/IGNITE-12504
> Project: Ignite
> Issue Type: Bug
> Components: cache, persistence
>Affects Versions: 2.8
>Reporter: Ilya Kasnacheev
>Assignee: Anton Kalashnikov
>Priority: Blocker
> Fix For: 2.8
>
>
> We have automatic baseline adjustment now. However, it is 'on' by default,
> which means it breaks existing code. I see new exceptions when starting an
> existing project after bumping Ignite dependency version:
> {code}
> Caused by:
> org.apache.ignite.internal.processors.cluster.BaselineAdjustForbiddenException:
> Baseline auto-adjust is enabled, please turn-off it before try to adjust
> baseline manually
> {code}
> (Please see reproducer from attached UL discussion)
> I think we should disable auto-adjust by default, let people enable it when
> they see it fit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12504) Auto-adjust breaks existing code, should be disabled by default
[
https://issues.apache.org/jira/browse/IGNITE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026711#comment-17026711
]
Ilya Kasnacheev commented on IGNITE-12504:
--
[~akalashnikov] Sounds reasonable.
> Auto-adjust breaks existing code, should be disabled by default
> ---
>
> Key: IGNITE-12504
> URL: https://issues.apache.org/jira/browse/IGNITE-12504
> Project: Ignite
> Issue Type: Bug
> Components: cache, persistence
>Affects Versions: 2.8
>Reporter: Ilya Kasnacheev
>Assignee: Anton Kalashnikov
>Priority: Blocker
> Fix For: 2.8
>
>
> We have automatic baseline adjustment now. However, it is 'on' by default,
> which means it breaks existing code. I see new exceptions when starting an
> existing project after bumping Ignite dependency version:
> {code}
> Caused by:
> org.apache.ignite.internal.processors.cluster.BaselineAdjustForbiddenException:
> Baseline auto-adjust is enabled, please turn-off it before try to adjust
> baseline manually
> {code}
> (Please see reproducer from attached UL discussion)
> I think we should disable auto-adjust by default, let people enable it when
> they see it fit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12504) Auto-adjust breaks existing code, should be disabled by default
[
https://issues.apache.org/jira/browse/IGNITE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026701#comment-17026701
]
Anton Kalashnikov commented on IGNITE-12504:
[~ilyak] non-persistent clusters weren't supported baseline before changes - it
was just zero-delay rebalance on each join/fail event. But after the
implementation of auto-adjust feature non-persistent clusters started to
support baseline same as a persistent cluster. So for keeping the old behavior
of zero-delay rebalance auto-adjust should be enabled by default and timeout
should be equal to 0.
In my opinion, the description of this ticket like ' it breaks existing code'
should be relative only to persistent cluster because changing of baseline for
not-persistent cluster before auto-adjust feature didn't make any sense(so code
with baseline change for non-persistent cluster should not exist). if it so
I'll close this ticket as duplicate. If you still think that enabled
auto-adjust for the non-persistent cluster can lead to the problems, we'll try
to figure it out.
> Auto-adjust breaks existing code, should be disabled by default
> ---
>
> Key: IGNITE-12504
> URL: https://issues.apache.org/jira/browse/IGNITE-12504
> Project: Ignite
> Issue Type: Bug
> Components: cache, persistence
>Affects Versions: 2.8
>Reporter: Ilya Kasnacheev
>Assignee: Anton Kalashnikov
>Priority: Blocker
> Fix For: 2.8
>
>
> We have automatic baseline adjustment now. However, it is 'on' by default,
> which means it breaks existing code. I see new exceptions when starting an
> existing project after bumping Ignite dependency version:
> {code}
> Caused by:
> org.apache.ignite.internal.processors.cluster.BaselineAdjustForbiddenException:
> Baseline auto-adjust is enabled, please turn-off it before try to adjust
> baseline manually
> {code}
> (Please see reproducer from attached UL discussion)
> I think we should disable auto-adjust by default, let people enable it when
> they see it fit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12504) Auto-adjust breaks existing code, should be disabled by default
[
https://issues.apache.org/jira/browse/IGNITE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026676#comment-17026676
]
Ilya Kasnacheev commented on IGNITE-12504:
--
[~akalashnikov] I'm not sure. What about non-persistent clusters?
If you are confident that IGNITE-12227 disables auto-adjust by default, you can
mark this ticket as duplicate.
> Auto-adjust breaks existing code, should be disabled by default
> ---
>
> Key: IGNITE-12504
> URL: https://issues.apache.org/jira/browse/IGNITE-12504
> Project: Ignite
> Issue Type: Bug
> Components: cache, persistence
>Affects Versions: 2.8
>Reporter: Ilya Kasnacheev
>Assignee: Anton Kalashnikov
>Priority: Blocker
> Fix For: 2.8
>
>
> We have automatic baseline adjustment now. However, it is 'on' by default,
> which means it breaks existing code. I see new exceptions when starting an
> existing project after bumping Ignite dependency version:
> {code}
> Caused by:
> org.apache.ignite.internal.processors.cluster.BaselineAdjustForbiddenException:
> Baseline auto-adjust is enabled, please turn-off it before try to adjust
> baseline manually
> {code}
> (Please see reproducer from attached UL discussion)
> I think we should disable auto-adjust by default, let people enable it when
> they see it fit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12504) Auto-adjust breaks existing code, should be disabled by default
[
https://issues.apache.org/jira/browse/IGNITE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026647#comment-17026647
]
Anton Kalashnikov commented on IGNITE-12504:
[~ilyak], since auto-adjust for the persistent cluster is disabled by default
after https://issues.apache.org/jira/browse/IGNITE-12227. Am I right to
understand that we can close this ticket? Or there are some other problem
cases?
> Auto-adjust breaks existing code, should be disabled by default
> ---
>
> Key: IGNITE-12504
> URL: https://issues.apache.org/jira/browse/IGNITE-12504
> Project: Ignite
> Issue Type: Bug
> Components: cache, persistence
>Affects Versions: 2.8
>Reporter: Ilya Kasnacheev
>Assignee: Anton Kalashnikov
>Priority: Blocker
> Fix For: 2.8
>
>
> We have automatic baseline adjustment now. However, it is 'on' by default,
> which means it breaks existing code. I see new exceptions when starting an
> existing project after bumping Ignite dependency version:
> {code}
> Caused by:
> org.apache.ignite.internal.processors.cluster.BaselineAdjustForbiddenException:
> Baseline auto-adjust is enabled, please turn-off it before try to adjust
> baseline manually
> {code}
> (Please see reproducer from attached UL discussion)
> I think we should disable auto-adjust by default, let people enable it when
> they see it fit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
