[jira] [Commented] (IGNITE-12552) [IEP-35] Expose MetricRegistry to the public API

2020-01-16 Thread Nikolay Izhikov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017045#comment-17017045
 ] 

Nikolay Izhikov commented on IGNITE-12552:
--

[~agoncharuk] Can you please, review my changes.

It fixes the issue with the usage of the internal API in ReadOnlyMetricManager 
interface.

> [IEP-35] Expose MetricRegistry to the public API
> 
>
> Key: IGNITE-12552
> URL: https://issues.apache.org/jira/browse/IGNITE-12552
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Blocker
>  Labels: IEP-35
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> MetricRegistry is not a part of public API, but used in MetricExporter which 
> is the part of public API.
> We should export MetricRegistry to the public API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12552) [IEP-35] Expose MetricRegistry to the public API

2020-01-17 Thread Andrey N. Gura (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017944#comment-17017944
 ] 

Andrey N. Gura commented on IGNITE-12552:
-

[~nizhikov] [~agoncharuk] This fix doesn't solve issue because this interface 
itself exposes internal entities. Se also my reply on devlist where I describe 
other issues of this interface ( 
http://apache-ignite-developers.2346864.n4.nabble.com/Internal-classes-are-exposed-in-public-API-td45146.html#a45178
 )

> [IEP-35] Expose MetricRegistry to the public API
> 
>
> Key: IGNITE-12552
> URL: https://issues.apache.org/jira/browse/IGNITE-12552
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Blocker
>  Labels: IEP-35
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> MetricRegistry is not a part of public API, but used in MetricExporter which 
> is the part of public API.
> We should export MetricRegistry to the public API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12552) [IEP-35] Expose MetricRegistry to the public API

2020-01-22 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020949#comment-17020949
 ] 

Ignite TC Bot commented on IGNITE-12552:


{panel:title=Branch: [pull/7269/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4947701&buildTypeId=IgniteTests24Java8_RunAll]

> [IEP-35] Expose MetricRegistry to the public API
> 
>
> Key: IGNITE-12552
> URL: https://issues.apache.org/jira/browse/IGNITE-12552
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Blocker
>  Labels: IEP-35
> Fix For: 2.8
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MetricRegistry is not a part of public API, but used in MetricExporter which 
> is the part of public API.
> We should export MetricRegistry to the public API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)