[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036032#comment-17036032 ] Alexey Scherbakov commented on IGNITE-12582: [~schernolyas] [~mstepachev] Looks good. Merged to master 465cc444d0bf69f230a7c6c9e429ff69851cba62. Thank for contribution. BTW, I see the same ticket [2], should it be closed as duplicate ? [2] https://issues.apache.org/jira/browse/IGNITE-12643 > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > Fix For: 2.8.1 > > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035086#comment-17035086 ] Sergey Chernolyas commented on IGNITE-12582: [~Pavlukhin] the visa has been gotten. the process is followed. > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > Fix For: 2.8.1 > > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[
https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035083#comment-17035083
]
Ignite TC Bot commented on IGNITE-12582:
{panel:title=Branch: [pull/7411/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5043398&buildTypeId=IgniteTests24Java8_RunAll]
> It is needed to set used cache for Spring Data dynamically
> --
>
> Key: IGNITE-12582
> URL: https://issues.apache.org/jira/browse/IGNITE-12582
> Project: Ignite
> Issue Type: Improvement
> Components: spring
>Affects Versions: 2.7.6
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Major
> Fix For: 2.8.1
>
>
> Hi!
> My project needs to configure used cache by property, like
> ""[spring.data|http://spring.data/].mongodb.uri:
> mongodb://:@:/" from Spring Data for
> MongoDB. Now, I can set cache for particular repository by annotation
> "RepositoryConfig" only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[
https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035022#comment-17035022
]
Ignite TC Bot commented on IGNITE-12582:
{panel:title=Branch: [pull/7411/head] Base: [master] : Possible Blockers
(4)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Cache 7{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=5042435]]
{color:#d04437}Cache 5{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5042398]]
* IgniteCacheTestSuite5:
IgniteCachePartitionLossPolicySelfTest.testReadWriteSafeWithBackupsAfterKillCrdWithPersistence[TRANSACTIONAL]
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Queries 1{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5042421]]
* IgniteBinaryCacheQueryTestSuite:
IndexingCachePartitionLossPolicySelfTest.testReadWriteSafeWithPersistence[ATOMIC]
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Cache 4{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5042397]]
* IgniteCacheTestSuite4: IgniteCacheAtomicLoadAllTest.testLoadAll - Test has
low fail rate in base branch 0,0% and is not flaky
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5042445&buildTypeId=IgniteTests24Java8_RunAll]
> It is needed to set used cache for Spring Data dynamically
> --
>
> Key: IGNITE-12582
> URL: https://issues.apache.org/jira/browse/IGNITE-12582
> Project: Ignite
> Issue Type: Improvement
> Components: spring
>Affects Versions: 2.7.6
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Major
> Fix For: 2.8.1
>
>
> Hi!
> My project needs to configure used cache by property, like
> ""[spring.data|http://spring.data/].mongodb.uri:
> mongodb://:@:/" from Spring Data for
> MongoDB. Now, I can set cache for particular repository by annotation
> "RepositoryConfig" only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034718#comment-17034718 ] Sergey Chernolyas commented on IGNITE-12582: New PR is created. See [https://github.com/apache/ignite/pull/7411] > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > Fix For: 2.8.1 > > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034252#comment-17034252 ] Ivan Pavlukhin commented on IGNITE-12582: - [~schernolyas], according to the development process a ticket can be moved to _patch available_ status as long as a PR is ready from standpoint of an author and there is a TC bot visa. But here I suppose we should rerun test suites where tests were added as a visa added previously does not have new tests executed. > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > Fix For: 2.8.1 > > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034213#comment-17034213 ] Sergey Chernolyas commented on IGNITE-12582: Hi [~Pavlukhin]! The tests have been appended to corresponding test suits. Can I change status of the issue ? > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034144#comment-17034144 ] Ivan Pavlukhin commented on IGNITE-12582: - [~schernolyas], [~mstepachev], it looks like that new test classes were not added to any test suite. All tests must be added to a test suite in order to run them in CI. I suppose Maksim can help to choose a proper suite. Maksim, please do a code review carefully. > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[
https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033881#comment-17033881
]
Ignite TC Bot commented on IGNITE-12582:
{panel:title=Branch: [pull/7381/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5037403&buildTypeId=IgniteTests24Java8_RunAll]
> It is needed to set used cache for Spring Data dynamically
> --
>
> Key: IGNITE-12582
> URL: https://issues.apache.org/jira/browse/IGNITE-12582
> Project: Ignite
> Issue Type: Improvement
> Components: spring
>Affects Versions: 2.7.6
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Major
>
> Hi!
> My project needs to configure used cache by property, like
> ""[spring.data|http://spring.data/].mongodb.uri:
> mongodb://:@:/" from Spring Data for
> MongoDB. Now, I can set cache for particular repository by annotation
> "RepositoryConfig" only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033691#comment-17033691 ] Stepachev Maksim commented on IGNITE-12582: --- LGTM, Please add the visa. [~irakov] Please merge it after the visa. > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031841#comment-17031841 ] Sergey Chernolyas commented on IGNITE-12582: [~mstepachev] Could you please review the PR [https://github.com/apache/ignite/pull/7381] ? > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[ https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029831#comment-17029831 ] Sergey Chernolyas commented on IGNITE-12582: Hi [~Pavlukhin] ! 1) I don't know. It need to be checked. In theory, I am doing the same. 2) The way was proposed. To extend feature of field "cacheName" of @RepositoryConfig. You right that is can be a double-edged sword. On the one hand, it is logical. On the other hand, it can be source of errors and misunderstandings > It is needed to set used cache for Spring Data dynamically > -- > > Key: IGNITE-12582 > URL: https://issues.apache.org/jira/browse/IGNITE-12582 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.7.6 >Reporter: Sergey Chernolyas >Assignee: Sergey Chernolyas >Priority: Major > > Hi! > My project needs to configure used cache by property, like > ""[spring.data|http://spring.data/].mongodb.uri: > mongodb://:@:/" from Spring Data for > MongoDB. Now, I can set cache for particular repository by annotation > "RepositoryConfig" only. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12582) It is needed to set used cache for Spring Data dynamically
[
https://issues.apache.org/jira/browse/IGNITE-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029794#comment-17029794
]
Ivan Pavlukhin commented on IGNITE-12582:
-
[~schernolyas], thank you for your efforts! I looked into
[PR|https://github.com/apache/ignite/pull/7347/] and I have some questions:
# Can we use
{{org.springframework.beans.factory.support.AbstractBeanFactory#getBeanExpressionResolver}}
for an expression evaluation? Generally it sounds good to have a behavior
consistent with {{@Value}} annotation.
# I suppose the next question was discussed somehow but it would good to
reflect it in the ticket. Why do we reuse old {{@RepositoryConfig}} annotation
enhancing it with new capabilities? Theoretically it can lead to backward
incompatibility. Other options here are adding a new annotation and deprecating
the old one or adding a new property to the existing annotation.
> It is needed to set used cache for Spring Data dynamically
> --
>
> Key: IGNITE-12582
> URL: https://issues.apache.org/jira/browse/IGNITE-12582
> Project: Ignite
> Issue Type: Improvement
> Components: spring
>Affects Versions: 2.7.6
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Major
>
> Hi!
> My project needs to configure used cache by property, like
> ""[spring.data|http://spring.data/].mongodb.uri:
> mongodb://:@:/" from Spring Data for
> MongoDB. Now, I can set cache for particular repository by annotation
> "RepositoryConfig" only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
