[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-12-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729582#comment-16729582
 ] 

ASF GitHub Bot commented on IGNITE-1260:


Github user udaykale closed the pull request at:

https://github.com/apache/ignite/pull/4153


> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Uday Kale
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-07-27 Thread Dmitriy Pavlov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559962#comment-16559962
 ] 

Dmitriy Pavlov commented on IGNITE-1260:


I've double checked, tests are running in AWS config after merge.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Uday Kale
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-30 Thread Dmitriy Govorukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528842#comment-16528842
 ] 

Dmitriy Govorukhin commented on IGNITE-1260:


[~dpavlov] Please, merge changes.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Uday Kale
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-30 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528670#comment-16528670
 ] 

Uday Kale commented on IGNITE-1260:
---

[~DmitriyGovorukhin] thanks for the review. I have changed the status to 'patch 
available'.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Uday Kale
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-29 Thread Dmitriy Govorukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527381#comment-16527381
 ] 

Dmitriy Govorukhin commented on IGNITE-1260:


[~uday] Yes, see Dmitriy Pavlov message above, about how to get contributors 
access.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-29 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527353#comment-16527353
 ] 

Uday Kale commented on IGNITE-1260:
---

Hi, [~DmitriyGovorukhin] I am unable to change the status to 'Patch Available'. 
Seems to be the issue with permissions. Do I need contributor access for this?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-29 Thread Dmitriy Govorukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527321#comment-16527321
 ] 

Dmitriy Govorukhin commented on IGNITE-1260:


[~uday] Changes looks good for me, please set issue status 'Patch Available' if 
you ready to merge.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-27 Thread Dmitriy Pavlov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525158#comment-16525158
 ] 

Dmitriy Pavlov commented on IGNITE-1260:


[~uday], you could write to dev list message with ask to be added to 
contributors list in JIRA. Or probably [~dmagda] can assign this role to you

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-27 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525147#comment-16525147
 ] 

Uday Kale commented on IGNITE-1260:
---

Hi [~dpavlov], I am unable to see any options to assign the ticket to myself. 
Where should i be looking.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-27 Thread Dmitriy Pavlov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525112#comment-16525112
 ] 

Dmitriy Pavlov commented on IGNITE-1260:


Hi [~uday], could you please also assign this ticket to you?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-27 Thread Dmitriy Govorukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525013#comment-16525013
 ] 

Dmitriy Govorukhin commented on IGNITE-1260:


Hi [~uday], I create Upsorce review 
[CR-669|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-669] and left 
my comments there. 

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
> Fix For: 2.7
>
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-26 Thread Dmitriy Pavlov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523700#comment-16523700
 ] 

Dmitriy Pavlov commented on IGNITE-1260:


Hi [~uday], thank you for your interest in Apache Ignite. 

I know that Denis is travelling right now. So someone else from the community 
will review your changes as soon as possible. Sorry, we have a lot of pending 
tickets in the review queue ( 
https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review ). 

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-20 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518024#comment-16518024
 ] 

Uday Kale commented on IGNITE-1260:
---

[~dmagda], don't know why its showing 12 days. The second commit was done just 
4 days. Its the second commit 
[2d898d4|https://github.com/apache/ignite/pull/4153/commits/2d898d4a9fb7b335afbe445cb35037c872b7b521]
 in the commit list.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-19 Thread Denis Magda (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517613#comment-16517613
 ] 

Denis Magda commented on IGNITE-1260:
-

[~uday], have you updated the pull-request? When I click on the link of the one 
at the top of the discussion I see 12 days old changes.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-16 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514804#comment-16514804
 ] 

Uday Kale commented on IGNITE-1260:
---

[~dmagda], I have implemented the changes based on the approach mentioned 
earlier. I have tested it on 
[TC|https://ci.ignite.apache.org/viewLog.html?buildId=1395721&buildTypeId=IgniteTests24Java8_Aws&tab=buildResultsDiv].
 Please review and suggest any further improvements.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-15 Thread Denis Magda (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514108#comment-16514108
 ] 

Denis Magda commented on IGNITE-1260:
-

[~vveider], I see, thought it was disabled completely. Then there is nothing to 
bother you with.

[~uday], let's try your approach. It sounds like a good solution.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-12 Thread Peter Ivanov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510063#comment-16510063
 ] 

Peter Ivanov commented on IGNITE-1260:
--

[~dmagda], please, clarify the task: what do you me by "recover AWS tests on 
TC"?
There is 
[AWS|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Aws]
 build configuration on TeamCity -- something have to be done with it or its 
results?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-12 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510033#comment-16510033
 ] 

Uday Kale commented on IGNITE-1260:
---

[~dmagda] Thanks for looking into the PR.

Regarding unit tests that do not require AWS connectivity, which you mentioned 
earlier. Does the approach I mentioned in my previous comment seem ok?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-12 Thread Denis Magda (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510022#comment-16510022
 ] 

Denis Magda commented on IGNITE-1260:
-

[~uday], your solution from the PR for testing looks fine. [~dpavlov], 
[~vveider], could you help to recover AWS tests on TC, do a final review of the 
PR and merge it?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-11 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509241#comment-16509241
 ] 

Uday Kale commented on IGNITE-1260:
---

[~dmagda] I will need to mock the s3 client. However, it is created internally 
by the private "createAmazonS3Client" method. I could make the method package 
protected and stub it from the unit test. Then what you suggested will be 
doable. Shall I use this approach?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-11 Thread Denis Magda (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508742#comment-16508742
 ] 

Denis Magda commented on IGNITE-1260:
-

[~uday], we need to set up an AWS environment if want to have tests that work 
together with AWS. That won't happen now.

Could you come up with a test that doesn't require AWS connectivity? You can 
potentially feed dummy data to see that API methods work out properly.

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-09 Thread Uday Kale (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506981#comment-16506981
 ] 

Uday Kale commented on IGNITE-1260:
---

Test for this task is failing in TC. I have noticed that other tests in the 
suite are failing but muted. The failure is same for all test: 
"java.lang.AssertionError: Environment variable 'test.amazon.access.key' is not 
set" including mine. The comments link the issue to 
[IGNITE-5495|https://issues.apache.org/jira/browse/IGNITE-5495]. So I will have 
to mute my test too?

[~ntikho...@apache.org] can you please help here?

> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-1260) S3 IP finder should have an option to use a subfolder instead of bucket root

2018-06-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505809#comment-16505809
 ] 

ASF GitHub Bot commented on IGNITE-1260:


GitHub user udaykale opened a pull request:

https://github.com/apache/ignite/pull/4153

IGNITE-1260 Added support for S3 keyPrefix in AWS S3-based IP finder

Resolves IGNITE-1260

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/udaykale/ignite IGNITE-1260

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4153


commit 515af752392b6872afe4085ed0555d6787f1d4f7
Author: uday 
Date:   2018-06-08T07:54:24Z

IGNITE-1260 Added support for S3 keyPrefix in AWS S3-based IP finder




> S3 IP finder should have an option to use a subfolder instead of bucket root
> 
>
> Key: IGNITE-1260
> URL: https://issues.apache.org/jira/browse/IGNITE-1260
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: newbie, usability, user-request
>
> Current implementation forces user to use the bucket root which is not always 
> possible. Need to provide a configuration parameter that allows to provide a 
> path in addition to the bucket name.
> Corresponding user@ thread: 
> http://apache-ignite-users.70518.x6.nabble.com/AWS-Integration-td495.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)