[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-17 Thread Maxim Muzafarov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038540#comment-17038540
 ] 

Maxim Muzafarov commented on IGNITE-12638:
--

I've cherry-picked to 2.8

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-17 Thread Maxim Muzafarov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038202#comment-17038202
 ] 

Maxim Muzafarov commented on IGNITE-12638:
--

[~agura], [~ibessonov]

Thank you, I'll cherry-pick the issue today to 2.8

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-13 Thread Andrey N. Gura (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036567#comment-17036567
 ] 

Andrey N. Gura commented on IGNITE-12638:
-

[~ibessonov] LGTM. Merged to master branch. Thanks for your contribution.

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-13 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036161#comment-17036161
 ] 

Ignite TC Bot commented on IGNITE-12638:


{panel:title=Branch: [pull/7383/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5046457buildTypeId=IgniteTests24Java8_RunAll]

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-12 Thread Ivan Bessonov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035940#comment-17035940
 ] 

Ivan Bessonov commented on IGNITE-12638:


[~agura] thank you, I will also encapsulate mutable public fields as we 
discussed privately.

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-12 Thread Andrey N. Gura (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035459#comment-17035459
 ] 

Andrey N. Gura commented on IGNITE-12638:
-

[~mmuzaf] I believe the change like this can't lead to flaky tests.

[~ibessonov] I've taook a look and have some comments about cosmetic. Could you 
please fix it?

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-11 Thread Ivan Bessonov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034498#comment-17034498
 ] 

Ivan Bessonov commented on IGNITE-12638:


[~mmuzaf] I'm all for merging it to master but I can't do it by myself.

What flaky failures do you mean? Are you afraid that this change will add some?

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-11 Thread Maxim Muzafarov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034471#comment-17034471
 ] 

Maxim Muzafarov commented on IGNITE-12638:
--

Let's merge to the master branch first and wait for flaky failures (if any)

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-11 Thread Dmitriy Govorukhin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034395#comment-17034395
 ] 

Dmitriy Govorukhin commented on IGNITE-12638:
-

[~ibessonov]Looks good to me! Thanks!

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.
> DistributedMetaStorageHistoryItem and DistributedMetaStorageVersion will be 
> persisted on disc so we need to have a reliable way to read them even when 
> classes will be updated in the future. IgniteDataTransferObject is the 
> standard option for such cases - it allows versioning of serialization format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12638) Classes persisted by DistributedMetaStorage are not IgniteDTO

2020-02-07 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032364#comment-17032364
 ] 

Ignite TC Bot commented on IGNITE-12638:


{panel:title=Branch: [pull/7383/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4993078buildTypeId=IgniteTests24Java8_RunAll]

> Classes persisted by DistributedMetaStorage are not IgniteDTO
> -
>
> Key: IGNITE-12638
> URL: https://issues.apache.org/jira/browse/IGNITE-12638
> Project: Ignite
>  Issue Type: Bug
>Reporter: Ivan Bessonov
>Assignee: Ivan Bessonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This has to be fixed to simplify future modification of component.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)