[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2021-02-08 Thread Alexey Scherbakov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281589#comment-17281589
 ] 

Alexey Scherbakov commented on IGNITE-13393:


[~alapin]

I've left some comments in PR.
Additional questions:


1. > Agreed, however currently it's not possible to trace specified operations 
properly cause we don't have compute tracing

Why can't we at least trace/log the event on top level ? I see you have 
implemented this for removeAll operation, but not for clear. That's the reason 
for this ?

2. I've noticed a lot of CACHE_*_FUTURE newly introduced spans. It doesn't make 
sense for me to have such kind of spans, because they don't provide any useful 
information, tied to internal implementation (actualy, named like internal 
futures) and multiplies the number of traced spans. All operations should be 
traced on request/response level with intermediate phases. For example, cache 
read operation consists of map/remap and read. 
Moreover, I haven't noticed such thing for transaction tracing. 
In my opinion, all this spans can be removed without any drawbacks.

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2021-01-24 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271104#comment-17271104
 ] 

Ignite TC Bot commented on IGNITE-13393:


{panel:title=Branch: [pull/8205/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8205/head] Base: [master] : New Tests 
(18)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Open Census{color} [[tests 
18|https://ci.ignite.apache.org/viewLog.html?buildId=5838184]]
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncWithValidValueTracing
 - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetTracing - PASSED{color}
... and 7 new tests

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5838194&buildTypeId=IgniteTests24Java8_RunAll]

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2021-01-22 Thread Alexander Lapin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270052#comment-17270052
 ] 

Alexander Lapin commented on IGNITE-13393:
--

[~ascherbakov]
>Current _ASYNC tracing semantics seems questionable to me. What's the point in 
>tracing future creation? IMO sync and async ops should be traced similarly. I 
>would remove _ASYNC scopes at all, instead use async=true tag to differentiate 
>between sync and async contexts.
 Fixed.
>What about other "update" operation, like invokes and filtered updates ? I 
>think the tracing implementaion should be unified with puts, using methods 
>org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#update0
> and 
>org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#updateAll0
> as entry points.
Fixed. Implemented for all operations.
>removeAll is a distributed operation. It's entry point in 
>GridDistributedCacheAdapter#removeAll. Looks like it's not traced properly.
>In addition to removeAll a cache can be cleared using clear(), which uses jobs 
>for local clearing. Should it be traced as well ?
Agreed, however currently it's not possible to trace specified operations 
properly cause we don't have compute tracing. I've create ticket for that. 
[IGNITE-14036|https://issues.apache.org/jira/browse/IGNITE-14036]
*One more iteration of review required.*

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2020-12-13 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248783#comment-17248783
 ] 

Ignite TC Bot commented on IGNITE-13393:


{panel:title=Branch: [pull/8205/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8205/head] Base: [master] : New Tests 
(18)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Open Census{color} [[tests 
18|https://ci.ignite.apache.org/viewLog.html?buildId=5789440]]
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncWithValidValueTracing
 - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetTracing - PASSED{color}
... and 7 new tests

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5789029&buildTypeId=IgniteTests24Java8_RunAll]

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2020-10-26 Thread Alexey Scherbakov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220565#comment-17220565
 ] 

Alexey Scherbakov commented on IGNITE-13393:


[~alapin]
 # Current _ASYNC tracing semantics seems questionable to me. What's the point 
in tracing future creation? IMO sync and async ops should be traced similarly. 
I would remove _ASYNC scopes at all, instead use async=true tag to 
differentiate between sync and async contexts.
 # removeAll is a distributed operation. It's entry point in 
GridDistributedCacheAdapter#removeAll. Looks like it's not traced properly.
 # What about other "update" operation, like invokes and filtered updates ? I 
think the tracing implementaion should be unified with puts, using methods 
org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#update0
 and 
org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache#updateAll0
 as entry points.
 # In addition to removeAll a cache can be cleared using clear(), which uses 
jobs for local clearing. Should it be traced as well ?

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2020-10-20 Thread Alexander Lapin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217441#comment-17217441
 ] 

Alexander Lapin commented on IGNITE-13393:
--

[~ascherbakov] Could you please take a look?

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13393) Tracing: Atomic cache read/write flow.

2020-10-20 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217392#comment-17217392
 ] 

Ignite TC Bot commented on IGNITE-13393:


{panel:title=Branch: [pull/8205/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8205/head] Base: [master] : New Tests 
(18)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Open Census{color} [[tests 
18|https://ci.ignite.apache.org/viewLog.html?buildId=5675948]]
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAsyncWithValidValueTracing
 - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicRemoveAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIWriteTracingTest.testCacheAtomicPutAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncAllTracing - 
PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAsyncTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetAllTracing - PASSED{color}
* {color:#013220}IgniteOpenCensusSuite: 
OpenCensusCacheAPIReadTracingTest.testCacheAtomicGetTracing - PASSED{color}
... and 7 new tests

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5668376&buildTypeId=IgniteTests24Java8_RunAll]

> Tracing: Atomic cache read/write flow.
> --
>
> Key: IGNITE-13393
> URL: https://issues.apache.org/jira/browse/IGNITE-13393
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Alexander Lapin
>Assignee: Alexander Lapin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Implement tracing for atomic cache operations:
>  * put
>  * putAll
>  * putAsync
>  * putAllAsync
>  * remove
>  * removeAll
>  * removeAsync
>  * removeAllAsync
>  * get
>  * getAll
>  * getAsync
>  * getAllAsync
> Also add ability to include root cache read/write operations to tx tracing 
> flow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)