[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325556#comment-17325556 ] Ivan Bessonov commented on IGNITE-14497: HI [~makedonskaya], changes look good. Thank you for contribution! > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325098#comment-17325098 ] Maria Makedonskaya commented on IGNITE-14497: - [~ibessonov], could you please review my changes? > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318810#comment-17318810 ] Maria Makedonskaya commented on IGNITE-14497: - [~ibessonov], could you pls take a look? > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318808#comment-17318808 ] Denis Chudov commented on IGNITE-14497: --- [~makedonskaya] lgtm > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[
https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316863#comment-17316863
]
Ignite TC Bot commented on IGNITE-14497:
{panel:title=Branch: [pull/8983/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8983/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5956539buildTypeId=IgniteTests24Java8_RunAll]
> Move background task deletion at the end of next checkpoint
> ---
>
> Key: IGNITE-14497
> URL: https://issues.apache.org/jira/browse/IGNITE-14497
> Project: Ignite
> Issue Type: Bug
>Reporter: Maria Makedonskaya
>Assignee: Maria Makedonskaya
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In [1] has been described scenario of the race that makes possible a
> situation when information from metastore has been deleted and part of the
> index is still present in the storage.
> Actually, fix in [1] that has been done in slightly different way, however,
> it strongly decreases possibility of the race. Removal of the background task
> has been moved to beginning of the next checkpoint. It was done this way,
> because the problem was in case when node unexpectedly failed in the middle
> of next checkpoint and after restart task failed on check of deleted index
> metaPage. The check was done in [2].
> In current issue, we only move background task deletion at the end of the
> next checkpoint.
> [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382]
> [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316864#comment-17316864 ] Maria Makedonskaya commented on IGNITE-14497: - [~Denis Chudov], could you please review my changes? > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
