[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361086#comment-16361086
 ] 

ASF GitHub Bot commented on IGNITE-1456:


Github user vinx13 closed the pull request at:

https://github.com/apache/ignite/pull/1947


> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>Priority: Major
>  Labels: cpp
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153609#comment-16153609
 ] 

Igor Sapego commented on IGNITE-1456:
-

Ok, I took a look. Current code uses {{OutOp}} when it should use 
{{InStreamOutObject}}. Moreover, {{OP_REBALANCE}} returns 
{{PlatformListenable}} which should be wrapped in {{Future}} class in C++, 
otherwise user have no way to find out when operation is completed. Currently 
return value just discarded which means control returned to the thread 
instantly, before operation could have been even started.

> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>  Labels: cpp
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153341#comment-16153341
 ] 

Igor Sapego commented on IGNITE-1456:
-

There is no tests in PR. I'm going to add some tests to check if everything is 
working as intended and merge it then, if everything is OK.

> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>  Labels: cpp
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153173#comment-16153173
 ] 

Vladimir Ozerov commented on IGNITE-1456:
-

Looks good to me. [~isapego], could you please double-check and merge if all is 
OK?

> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>  Labels: cpp
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[Wuwei Lin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013877#comment-16013877
 ] 

Wuwei Lin commented on IGNITE-1456:
---

Ready for review.

> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>  Labels: cpp
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1456) CPP: Implement Cache.Rebalance()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011603#comment-16011603
 ] 

ASF GitHub Bot commented on IGNITE-1456:


GitHub user vinx13 opened a pull request:

https://github.com/apache/ignite/pull/1947

IGNITE-1456: CPP: Implements Cache.Rebalance()



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vinx13/ignite ignite-1456

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1947.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1947


commit 0bb53d8e8e908dad703b2c612bbfca8313ee80cb
Author: Wuwei Lin 
Date:   2017-05-16T01:36:25Z

CPP: Implements Cache.Rebalance()




> CPP: Implement Cache.Rebalance()
> 
>
> Key: IGNITE-1456
> URL: https://issues.apache.org/jira/browse/IGNITE-1456
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 1.1.4
>Reporter: Vladimir Ozerov
>Assignee: Wuwei Lin
>  Labels: cpp
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)