[jira] [Commented] (IGNITE-14692) Validate tuple for STRICT schema
[ https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348307#comment-17348307 ] Andrey Mashenkov commented on IGNITE-14692: --- [~tledkov-gridgain], LGTM! > Validate tuple for STRICT schema > > > Key: IGNITE-14692 > URL: https://issues.apache.org/jira/browse/IGNITE-14692 > Project: Ignite > Issue Type: Improvement >Reporter: Taras Ledkov >Assignee: Taras Ledkov >Priority: Major > Labels: iep-54, ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > The part of the IGNITE-14556. > At a point of Table public method is called by a user, we need to validate > user input > Description. > We can add this logic to check if value fields match the current schema > version (no new fields). > For STRICT-Schema. If Tuple has one or more additional columns, then we > should fail the user operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14692) Validate tuple for STRICT schema
[ https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347462#comment-17347462 ] Andrey Mashenkov commented on IGNITE-14692: --- [~tledkov-gridgain], looks good. Please fix styles and resolve conflicts. > Validate tuple for STRICT schema > > > Key: IGNITE-14692 > URL: https://issues.apache.org/jira/browse/IGNITE-14692 > Project: Ignite > Issue Type: Improvement >Reporter: Taras Ledkov >Assignee: Taras Ledkov >Priority: Major > Labels: iep-54, ignite-3 > Time Spent: 2h 40m > Remaining Estimate: 0h > > The part of the IGNITE-14556. > At a point of Table public method is called by a user, we need to validate > user input > Description. > We can add this logic to check if value fields match the current schema > version (no new fields). > For STRICT-Schema. If Tuple has one or more additional columns, then we > should fail the user operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14692) Validate tuple for STRICT schema
[ https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346741#comment-17346741 ] Taras Ledkov commented on IGNITE-14692: --- [~amashenkov], review comments are fixed, TC is green. > Validate tuple for STRICT schema > > > Key: IGNITE-14692 > URL: https://issues.apache.org/jira/browse/IGNITE-14692 > Project: Ignite > Issue Type: Improvement >Reporter: Taras Ledkov >Assignee: Taras Ledkov >Priority: Major > Labels: iep-54, ignite-3 > Time Spent: 1h 10m > Remaining Estimate: 0h > > The part of the IGNITE-14556. > At a point of Table public method is called by a user, we need to validate > user input > Description. > We can add this logic to check if value fields match the current schema > version (no new fields). > For STRICT-Schema. If Tuple has one or more additional columns, then we > should fail the user operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14692) Validate tuple for STRICT schema
[ https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346161#comment-17346161 ] Andrey Mashenkov commented on IGNITE-14692: --- [~tledkov-gridgain], I've left few comments to the PR. > Validate tuple for STRICT schema > > > Key: IGNITE-14692 > URL: https://issues.apache.org/jira/browse/IGNITE-14692 > Project: Ignite > Issue Type: Improvement >Reporter: Taras Ledkov >Assignee: Taras Ledkov >Priority: Major > Labels: iep-54, ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > The part of the IGNITE-14556. > At a point of Table public method is called by a user, we need to validate > user input > Description. > We can add this logic to check if value fields match the current schema > version (no new fields). > For STRICT-Schema. If Tuple has one or more additional columns, then we > should fail the user operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)