[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355603#comment-17355603 ] Stanilovsky Evgeny commented on IGNITE-14739: - [~sergey-chugunov] i comment unrelevant test. Check it plz. > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352330#comment-17352330 ] Alexey Scherbakov commented on IGNITE-14739: [~zstan] LGTM > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351657#comment-17351657 ] Stanilovsky Evgeny commented on IGNITE-14739: - [~ascherbakov] this drop is a payment for the correctness ) May be after your mention with incorrect logic it will reduce a bit. However i still suppose that this drop is negligible in comparison with fix that it contains. No one rejection on dev list found. > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351647#comment-17351647 ] Alexey Scherbakov commented on IGNITE-14739: Additionally, the change if (ptr != null && !cctx.tm().logTxRecords()) -> if (ptr != null seems incorrect, because if tx logging is enabled, we will flush the WAL in [1] [1] org.apache.ignite.internal.processors.cache.transactions.IgniteTxAdapter#state(org.apache.ignite.transactions.TransactionState, boolean) > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351643#comment-17351643 ] Alexey Scherbakov commented on IGNITE-14739: [~zstan] It seems we have performance drop comparing to master revision #626168e1 I'm not sure it's ok to enable tx logging by default, considering the fact the fix in IGNITE-6324 is only partial. > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[
https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350260#comment-17350260
]
Ignite TC Bot commented on IGNITE-14739:
{panel:title=Branch: [pull/9112/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9112/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6019840&buildTypeId=IgniteTests24Java8_RunAll]
> Enable a permanent wal recording of transactions states records.
>
>
> Key: IGNITE-14739
> URL: https://issues.apache.org/jira/browse/IGNITE-14739
> Project: Ignite
> Issue Type: Improvement
> Components: persistence
>Affects Versions: 2.10
>Reporter: Stanilovsky Evgeny
>Assignee: Stanilovsky Evgeny
>Priority: Major
> Attachments: screenshot-1.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After [1] was merged, i suggest to enable transactions states wal logging on
> a permanent basis. This will allow to correctly restore transactional states
> after partial or whole nodes crash.
> [1] https://issues.apache.org/jira/browse/IGNITE-6324
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-14739) Enable a permanent wal recording of transactions states records.
[ https://issues.apache.org/jira/browse/IGNITE-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349040#comment-17349040 ] Stanilovsky Evgeny commented on IGNITE-14739: - !screenshot-1.png! > Enable a permanent wal recording of transactions states records. > > > Key: IGNITE-14739 > URL: https://issues.apache.org/jira/browse/IGNITE-14739 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.10 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > After [1] was merged, i suggest to enable transactions states wal logging on > a permanent basis. This will allow to correctly restore transactional states > after partial or whole nodes crash. > [1] https://issues.apache.org/jira/browse/IGNITE-6324 -- This message was sent by Atlassian Jira (v8.3.4#803005)
