[jira] [Commented] (IGNITE-15067) Add custom destination path to the snapshost API
[
https://issues.apache.org/jira/browse/IGNITE-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545832#comment-17545832
]
Ignite TC Bot commented on IGNITE-15067:
{panel:title=Branch: [pull/10052/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/10052/head] Base: [master] : New Tests
(7)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Control Utility (Zookeeper){color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=6606753]]
* {color:#013220}ZookeeperIgniteControlUtilityTestSuite:
GridCommandHandlerTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
{color:#8b}Snapshots{color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=6605319]]
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotRestoreSelfTest.testClusterSnapshotRestoreFromCustomDir[Encryption=true]
- PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotHandlerTest.testHandlerSnapshotLocation[Encryption=false]
- PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotHandlerTest.testHandlerSnapshotLocation[Encryption=true] -
PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotRestoreSelfTest.testClusterSnapshotRestoreFromCustomDir[Encryption=false]
- PASSED{color}
{color:#8b}Control Utility{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=6605276]]
* {color:#013220}IgniteControlUtilityTestSuite:
GridCommandHandlerWithSSLTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
* {color:#013220}IgniteControlUtilityTestSuite:
GridCommandHandlerTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6605343buildTypeId=IgniteTests24Java8_RunAll]
> Add custom destination path to the snapshost API
>
>
> Key: IGNITE-15067
> URL: https://issues.apache.org/jira/browse/IGNITE-15067
> Project: Ignite
> Issue Type: Improvement
>Reporter: Maxim Muzafarov
>Assignee: Pavel Pereslegin
>Priority: Major
> Labels: iep-43, ise
> Fix For: 2.14
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The default configuration path obtains from the IgniteConfiguration. However,
> in some circumstances, it is good to set this destination path at runtime.
> This path must be configured relatively in the node working directory and
> must be accessible from the security point of view.
> h3. Proposed API
> h4. Java (internal)
> {code:java}
> // New non-null getter in SnapshotHandlerContext to get the full path to the
> snapshot files.
> public File snapshotDirectory()
> // Snapshot creation example.
> snpMgr.createSnapshot("snpName", "/opt/snapshots")
> // Snapshot validation example.
> snpMgr.checkSnapshot("snpName", "/opt/snapshots")
> // Snapshot restore example.
> snpMgr.restoreSnapshot("snpName", "/opt/snapshots"){code}
> h4. Control script
> *create* command syntax
> {noformat}
> control.(sh|bat) --snapshot create snapshot_name [--dest path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> --dest path- Path to the directory where the snapshot will be saved. If
> not specified, the default configured snapshot directory will be used.
> --sync - Run the operation synchronously, the command will wait for
> the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
> *check* command syntax
> {noformat}
> control.(sh|bat) --snapshot check snapshot_name [--src path]
> Parameters:
> snapshot_name - Snapshot name.
> --src path - Path to the directory where the snapshot files are
> located. If not specified, the default configured snapshot directory will be
> used.
> {noformat}
> *restore* command syntax
> {noformat}
> control.(sh|bat) --snapshot restore snapshot_name --start [--groups
> group1,...groupN] [--src path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> --groups group1,...groupN - Cache group names.
> --src path - Path to the directory where the snapshot files
> are located. If not specified, the default configured snapshot directory will
> be used.
> --sync - Run the operation synchronously, the command
> will wait for the entire operation to complete. Otherwise, it will be
> performed in the background, and the command will immediately return control.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (IGNITE-15067) Add custom destination path to the snapshost API
[
https://issues.apache.org/jira/browse/IGNITE-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545827#comment-17545827
]
Pavel Pereslegin commented on IGNITE-15067:
---
[~NSAmelchev], thanks for the review!
> Add custom destination path to the snapshost API
>
>
> Key: IGNITE-15067
> URL: https://issues.apache.org/jira/browse/IGNITE-15067
> Project: Ignite
> Issue Type: Improvement
>Reporter: Maxim Muzafarov
>Assignee: Pavel Pereslegin
>Priority: Major
> Labels: iep-43, ise
> Fix For: 2.14
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The default configuration path obtains from the IgniteConfiguration. However,
> in some circumstances, it is good to set this destination path at runtime.
> This path must be configured relatively in the node working directory and
> must be accessible from the security point of view.
> h3. Proposed API
> h4. Java (internal)
> {code:java}
> // New non-null getter in SnapshotHandlerContext to get the full path to the
> snapshot files.
> public File snapshotDirectory()
> // Snapshot creation example.
> snpMgr.createSnapshot("snpName", "/opt/snapshots")
> // Snapshot validation example.
> snpMgr.checkSnapshot("snpName", "/opt/snapshots")
> // Snapshot restore example.
> snpMgr.restoreSnapshot("snpName", "/opt/snapshots"){code}
> h4. Control script
> *create* command syntax
> {noformat}
> control.(sh|bat) --snapshot create snapshot_name [--dest path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> --dest path- Path to the directory where the snapshot will be saved. If
> not specified, the default configured snapshot directory will be used.
> --sync - Run the operation synchronously, the command will wait for
> the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
> *check* command syntax
> {noformat}
> control.(sh|bat) --snapshot check snapshot_name [--src path]
> Parameters:
> snapshot_name - Snapshot name.
> --src path - Path to the directory where the snapshot files are
> located. If not specified, the default configured snapshot directory will be
> used.
> {noformat}
> *restore* command syntax
> {noformat}
> control.(sh|bat) --snapshot restore snapshot_name --start [--groups
> group1,...groupN] [--src path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> --groups group1,...groupN - Cache group names.
> --src path - Path to the directory where the snapshot files
> are located. If not specified, the default configured snapshot directory will
> be used.
> --sync - Run the operation synchronously, the command
> will wait for the entire operation to complete. Otherwise, it will be
> performed in the background, and the command will immediately return control.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (IGNITE-15067) Add custom destination path to the snapshost API
[
https://issues.apache.org/jira/browse/IGNITE-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545467#comment-17545467
]
Amelchev Nikita commented on IGNITE-15067:
--
[~xtern], LGTM.
> Add custom destination path to the snapshost API
>
>
> Key: IGNITE-15067
> URL: https://issues.apache.org/jira/browse/IGNITE-15067
> Project: Ignite
> Issue Type: Improvement
>Reporter: Maxim Muzafarov
>Assignee: Pavel Pereslegin
>Priority: Major
> Labels: iep-43, ise
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The default configuration path obtains from the IgniteConfiguration. However,
> in some circumstances, it is good to set this destination path at runtime.
> This path must be configured relatively in the node working directory and
> must be accessible from the security point of view.
> Proposed API:
> {code}
> public IgniteFuture createSnapshot(String name, String locPath);
> {code}
> control.sh *create* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot create snapshot_name [--dest path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> path - Path to the directory where the snapshot will be saved. If
> not specified, the default snapshot directory will be used.
> sync - Run the operation synchronously, the command will wait for
> the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
> control.sh *check* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot check snapshot_name [--src path]
> Parameters:
> snapshot_name - Snapshot name.
> path - Path to the directory where the snapshot files are
> located. If not specified, the default snapshot directory will be used.
> {noformat}
> control.sh *restore* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot restore snapshot_name --start [--groups
> group1,...groupN] [--src path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> group1,...groupN - Cache group names.
> path - Path to the directory where the snapshot files are
> located. If not specified, the default snapshot directory will be used.
> sync - Run the operation synchronously, the command will wait
> for the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (IGNITE-15067) Add custom destination path to the snapshost API
[
https://issues.apache.org/jira/browse/IGNITE-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544521#comment-17544521
]
Ignite TC Bot commented on IGNITE-15067:
{panel:title=Branch: [pull/10052/head] Base: [master] : Possible Blockers
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}AOP{color} [[tests 0 Exit Code
|https://ci2.ignite.apache.org/viewLog.html?buildId=6462513]]
{panel}
{panel:title=Branch: [pull/10052/head] Base: [master] : New Tests
(7)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Control Utility{color} [[tests
2|https://ci2.ignite.apache.org/viewLog.html?buildId=6462434]]
* {color:#013220}IgniteControlUtilityTestSuite:
GridCommandHandlerTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
* {color:#013220}IgniteControlUtilityTestSuite:
GridCommandHandlerWithSSLTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
{color:#8b}Control Utility (Zookeeper){color} [[tests
1|https://ci2.ignite.apache.org/viewLog.html?buildId=6462435]]
* {color:#013220}ZookeeperIgniteControlUtilityTestSuite:
GridCommandHandlerTest.testSnapshotCreateCheckAndRestoreCustomDir -
PASSED{color}
{color:#8b}Snapshots{color} [[tests
4|https://ci2.ignite.apache.org/viewLog.html?buildId=6462485]]
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotRestoreSelfTest.testClusterSnapshotRestoreFromCustomDir[Encryption=true]
- PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotRestoreSelfTest.testClusterSnapshotRestoreFromCustomDir[Encryption=false]
- PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotHandlerTest.testHandlerSnapshotLocation[Encryption=true] -
PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite:
IgniteClusterSnapshotHandlerTest.testHandlerSnapshotLocation[Encryption=false]
- PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6462626buildTypeId=IgniteTests24Java8_RunAll]
> Add custom destination path to the snapshost API
>
>
> Key: IGNITE-15067
> URL: https://issues.apache.org/jira/browse/IGNITE-15067
> Project: Ignite
> Issue Type: Improvement
>Reporter: Maxim Muzafarov
>Assignee: Pavel Pereslegin
>Priority: Major
> Labels: iep-43, ise
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The default configuration path obtains from the IgniteConfiguration. However,
> in some circumstances, it is good to set this destination path at runtime.
> This path must be configured relatively in the node working directory and
> must be accessible from the security point of view.
> Proposed API:
> {code}
> public IgniteFuture createSnapshot(String name, String locPath);
> {code}
> control.sh *create* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot create snapshot_name [--dest path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> path - Path to the directory where the snapshot will be saved. If
> not specified, the default snapshot directory will be used.
> sync - Run the operation synchronously, the command will wait for
> the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
> control.sh *check* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot check snapshot_name [--src path]
> Parameters:
> snapshot_name - Snapshot name.
> path - Path to the directory where the snapshot files are
> located. If not specified, the default snapshot directory will be used.
> {noformat}
> control.sh *restore* snapshot command syntax
> {noformat}
> control.(sh|bat) --snapshot restore snapshot_name --start [--groups
> group1,...groupN] [--src path] [--sync]
> Parameters:
> snapshot_name - Snapshot name.
> group1,...groupN - Cache group names.
> path - Path to the directory where the snapshot files are
> located. If not specified, the default snapshot directory will be used.
> sync - Run the operation synchronously, the command will wait
> for the entire operation to complete. Otherwise, it will be performed in the
> background, and the command will immediately return control.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (IGNITE-15067) Add custom destination path to the snapshost API
[
https://issues.apache.org/jira/browse/IGNITE-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433655#comment-17433655
]
Pavel Pereslegin commented on IGNITE-15067:
---
Perhaps it makes sense to add such a feature when restoring a snapshot too
(without workdir restriction).
This will simplify restoring to another cluster from an external resource
(mounted to the server).
> Add custom destination path to the snapshost API
>
>
> Key: IGNITE-15067
> URL: https://issues.apache.org/jira/browse/IGNITE-15067
> Project: Ignite
> Issue Type: Improvement
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Major
> Labels: iep-43
> Fix For: 2.12
>
>
> The default configuration path obtains from the IgniteConfiguration. However,
> in some circumstances, it is good to set this destination path at runtime.
> This path must be configured relatively in the node working directory and
> must be accessible from the security point of view.
> Proposed API:
> {code}
> public IgniteFuture createSnapshot(String name, Path locPath);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
