[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221605#comment-15221605 ] Artem Shutak commented on IGNITE-1559: -- In bounds of the issue javadoc was fixed and classes:// schema description was deleted from UriDeploymentSpi javadoc. file:// schema shold be used instead. > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Valentin Kulichenko >Priority: Critical > Fix For: 1.5.0.final > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963659#comment-14963659 ] ASF GitHub Bot commented on IGNITE-1559: GitHub user ashutakGG opened a pull request: https://github.com/apache/ignite/pull/166 Fixed GridUriDeploymentClassLoaderSelfTest#testNestedJarClassloading Fixed test after https://issues.apache.org/jira/browse/IGNITE-1559. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ashutakGG/incubator-ignite fixed-GridUriDeploymentClassLoaderSelfTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #166 commit fd397f71465cf47f746891428706d37e71c67eaf Author: ashutak Date: 2015-10-19T17:30:55Z fixed GridUriDeploymentClassLoaderSelfTest#testNestedJarClassloading > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Valentin Kulichenko >Priority: Critical > Fix For: 1.5 > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936699#comment-14936699 ] Artem Shutak commented on IGNITE-1559: -- Updated both: readme.io and javadocs. Readme.io has been updated according to Yakov comments at email (see below). Please, review "Code example" part again. >From Yakov's email: 1. SPI parameters explanations and code example should be before scanners (scanner is SPI config as well, just more detailed info) 2. code example should include all scanners + add spring configuration example 3. >> quot Http Uri Example The following example will scan ignite/deployment folder on site www.mysite.com using authentication 'username:password' every '1' milliseconds. http://username:password;freq=10...@www.mysite.com:110/ignite/deployment >>/quot I thought this scanner will download the page served by a server and mysite.com:110 (that will be default page), parse it and download and deploy all GAR files specified by href attributes of elements on the page. Please correct your content if you agree. > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Artem Shutak > Fix For: ignite-1.5 > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936070#comment-14936070 ] Valentin Kulichenko commented on IGNITE-1559: - Artem, I moved the article here: https://apacheignite.readme.io/docs/deployment-spi. I also made several fixes there. Can you please go through it and fix javadoc accordingly? I will merge after that. > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Valentin Kulichenko > Fix For: ignite-1.5 > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935627#comment-14935627 ] Artem Shutak commented on IGNITE-1559: -- Created new article on readme.io: http://apacheignite.gridgain.org/docs/deployment-tasks. > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Valentin Kulichenko > Fix For: ignite-1.5 > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935382#comment-14935382 ] Artem Shutak commented on IGNITE-1559: -- PR: https://github.com/apache/ignite/pull/114. The PR contains changes at 'uri/pom.xml' it should be run on TC. > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > - > > Key: IGNITE-1559 > URL: https://issues.apache.org/jira/browse/IGNITE-1559 > Project: Ignite > Issue Type: Task >Reporter: Artem Shutak >Assignee: Artem Shutak > Fix For: ignite-1.5 > > > Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. > It's not possible to understand from current javadoc of > UriDeploymentHttpScanner how it works. > There's only one simple test in GridHttpDeploymentSelfTest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
[
https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935193#comment-14935193
]
Artem Shutak commented on IGNITE-1559:
--
In process of improvement javadocs for UriDeploymentSpi I've found that
"classes"-protocol currently not supported. So, I will remove this part from
javadoc.
Checked with
{code}
deploymentSpi.setUriList(Arrays.asList("classes://freq=5000@localhost/c:/Program
files/ignite/deployment"));
{code}
I've got next exception:
{noformat}
Exception in thread "main" class org.apache.ignite.IgniteException: Failed to
start manager: GridManagerAdapter [enabled=true,
name=org.apache.ignite.internal.managers.deployment.GridDeploymentManager]
at
org.apache.ignite.internal.util.IgniteUtils.convertException(IgniteUtils.java:881)
at org.apache.ignite.Ignition.start(Ignition.java:324)
at
org.apache.ignite.TmpUriDeploymentTest.main(TmpUriDeploymentTest.java:37)
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to start
manager: GridManagerAdapter [enabled=true,
name=org.apache.ignite.internal.managers.deployment.GridDeploymentManager]
at
org.apache.ignite.internal.IgniteKernal.startManager(IgniteKernal.java:1488)
at org.apache.ignite.internal.IgniteKernal.start(IgniteKernal.java:856)
at
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:1617)
at
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start(IgnitionEx.java:1484)
at org.apache.ignite.internal.IgnitionEx.start0(IgnitionEx.java:965)
at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:526)
at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:507)
at org.apache.ignite.Ignition.start(Ignition.java:321)
... 1 more
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to start SPI:
UriDeploymentSpi [tmpDirPath=/tmp,
deployTmpDirPath=/tmp/gg.uri.deployment.tmp/b2bf7e0f-efa2-47e6-9c56-57a2ed44b27c,
checkMd5=false,
unitComp=org.apache.ignite.spi.deployment.uri.UriDeploymentSpi$LastTimeUnitDescriptorComparator@434ce06a,
encodeUri=true, firstScanCntr=0, lsnr=null, delayOnNewOrUpdatedFile=false]
at
org.apache.ignite.internal.managers.GridManagerAdapter.startSpi(GridManagerAdapter.java:255)
at
org.apache.ignite.internal.managers.deployment.GridDeploymentManager.start(GridDeploymentManager.java:101)
at
org.apache.ignite.internal.IgniteKernal.startManager(IgniteKernal.java:1485)
... 8 more
Caused by: class org.apache.ignite.spi.IgniteSpiException: Unsupported URI
(please configure appropriate scanner):
classes://freq=5000@localhost/c:/Program%20files/ignite/deployment
at
org.apache.ignite.spi.deployment.uri.UriDeploymentSpi.spiStart(UriDeploymentSpi.java:630)
at
org.apache.ignite.internal.managers.GridManagerAdapter.startSpi(GridManagerAdapter.java:252)
... 10 more
{noformat}
> Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
> -
>
> Key: IGNITE-1559
> URL: https://issues.apache.org/jira/browse/IGNITE-1559
> Project: Ignite
> Issue Type: Task
>Reporter: Artem Shutak
>Assignee: Artem Shutak
> Fix For: ignite-1.5
>
>
> Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
> It's not possible to understand from current javadoc of
> UriDeploymentHttpScanner how it works.
> There's only one simple test in GridHttpDeploymentSelfTest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
