[jira] [Commented] (IGNITE-15692) Implement TableManager component stop
[ https://issues.apache.org/jira/browse/IGNITE-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434461#comment-17434461 ] Alexander Lapin commented on IGNITE-15692: -- [~v.pyatkov] LGTM > Implement TableManager component stop > -- > > Key: IGNITE-15692 > URL: https://issues.apache.org/jira/browse/IGNITE-15692 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Vladislav Pyatkov >Priority: Major > Labels: ignite-3 > Time Spent: 15h 50m > Remaining Estimate: 0h > > *Problem* > TableManager stop isn't implemented, therefore, stopping an Ignite node does > not stop rafts groups of table partitions, which in turn leads to leaking > resources, particularly threads and thread pools. > Things to be done: > * Proper stop of everything that was started during TableManager start and > withing it's life cycle. Definitely it's raft groups and maybe something else. > * Proper stop assumes that it's thread safe, so that busy lock is involved > to protect local part of operations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-15692) Implement TableManager component stop
[ https://issues.apache.org/jira/browse/IGNITE-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431247#comment-17431247 ] Alexander Lapin commented on IGNITE-15692: -- [~v.pyatkov] Please see my comments in PR. Could you please also briefly note within ticket description what was actually implemented? > Implement TableManager component stop > -- > > Key: IGNITE-15692 > URL: https://issues.apache.org/jira/browse/IGNITE-15692 > Project: Ignite > Issue Type: Improvement >Reporter: Alexander Lapin >Assignee: Vladislav Pyatkov >Priority: Major > Labels: ignite-3 > Time Spent: 7h 10m > Remaining Estimate: 0h > > *Problem* > TableManager stop isn't implemented, therefore, stopping an Ignite node does > not stop rafts groups of table partitions, which in turn leads to leaking > resources, particularly threads and thread pools. > Things to be done: > * Proper stop of everything that was started during TableManager start and > withing it's life cycle. Definitely it's raft groups and maybe something else. > * Proper stop assumes that it's thread safe, so that busy lock is involved > to protect local part of operations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
