[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483398#comment-17483398 ] Konstantin Orlov commented on IGNITE-16235: --- [~zstan], LGTM! > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 50m > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482537#comment-17482537 ] Evgeny Stanilovsky commented on IGNITE-16235: - [~korlov] fixed. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 40m > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482468#comment-17482468 ] Konstantin Orlov commented on IGNITE-16235: --- LGTM > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482363#comment-17482363 ] Konstantin Orlov commented on IGNITE-16235: --- Another bunch of comments is waiting in the PR. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481096#comment-17481096 ] Evgeny Stanilovsky commented on IGNITE-16235: - [~korlov] thanks, fixed. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 20m > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480931#comment-17480931 ] Konstantin Orlov commented on IGNITE-16235: --- Hi, [~zstan]! I've left a few comments, Please see the PR. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479120#comment-17479120 ] Evgeny Stanilovsky commented on IGNITE-16235: - [~korlov] plz check it? > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477217#comment-17477217 ] Evgeny Stanilovsky commented on IGNITE-16235: - [~korlov] i update tests, also i prefer to store testTableOperationsWithLaggedNode i fount it useful. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474287#comment-17474287 ] Evgeny Stanilovsky commented on IGNITE-16235: - [~korlov] plz check it. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-16235) Races between query execution and table creation
[ https://issues.apache.org/jira/browse/IGNITE-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471789#comment-17471789 ] Vladislav Pyatkov commented on IGNITE-16235: For the delay of events from Metastorage the WatchListenerInhibitor is used. > Races between query execution and table creation > > > Key: IGNITE-16235 > URL: https://issues.apache.org/jira/browse/IGNITE-16235 > Project: Ignite > Issue Type: Test > Components: sql >Reporter: Konstantin Orlov >Assignee: Evgeny Stanilovsky >Priority: Major > > While the IGNITE-16090 fixes the issue, the provided patch lacks of proper > integration test that would verify the fix automatically. So we need to add > the test with follow scenario: > - cluster of 2 or more nodes is started > - create a table and immediately run a query upon that table > To reveal the original issue, we need to delay ditributed event of a table > creation on the node somehow in order to make the query be executed before > the table structures were created. > I believe this is not the only such a test, so we need a general approach to > write tests to verify the cluster behaviour in a concurrent environment. -- This message was sent by Atlassian Jira (v8.20.1#820001)
