[jira] [Commented] (IGNITE-17203) SQL API: Implement scale and precision metadata

2022-07-07 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563617#comment-17563617
 ] 

Konstantin Orlov commented on IGNITE-17203:
---

[~amashenkov], LGTM!

> SQL API: Implement scale and precision metadata
> ---
>
> Key: IGNITE-17203
> URL: https://issues.apache.org/jira/browse/IGNITE-17203
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Reporter: Pavel Tupitsyn
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-alpha6
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> *scale()* and *precision()* in *ColumnMetadata* interface return incorrect 
> values. Implement them properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-17203) SQL API: Implement scale and precision metadata

2022-07-06 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563035#comment-17563035
 ] 

Konstantin Orlov commented on IGNITE-17203:
---

[~amashenkov], I've left a few comments. Please see PR

> SQL API: Implement scale and precision metadata
> ---
>
> Key: IGNITE-17203
> URL: https://issues.apache.org/jira/browse/IGNITE-17203
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Reporter: Pavel Tupitsyn
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-alpha6
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> *scale()* and *precision()* in *ColumnMetadata* interface return incorrect 
> values. Implement them properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-17203) SQL API: Implement scale and precision metadata

2022-07-01 Thread Pavel Tupitsyn (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561498#comment-17561498
 ] 

Pavel Tupitsyn commented on IGNITE-17203:
-

[~amashenkov] I don't think .NET limitations should dictate server-side 
precision and scale.
Let's support what we can according to SQL standard and deal with .NET and 
other platform limitations separately.

> SQL API: Implement scale and precision metadata
> ---
>
> Key: IGNITE-17203
> URL: https://issues.apache.org/jira/browse/IGNITE-17203
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Reporter: Pavel Tupitsyn
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-alpha6
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> *scale()* and *precision()* in *ColumnMetadata* interface return incorrect 
> values. Implement them properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-17203) SQL API: Implement scale and precision metadata

2022-07-01 Thread Andrey Mashenkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561437#comment-17561437
 ] 

Andrey Mashenkov commented on IGNITE-17203:
---

I've jfound we use Short.MAX_VALUE as max precision and scale for numeric types.
AFAIK, decimal in .NET is limited with 38 digits.

What is a use case that requires support for such large values? 

> SQL API: Implement scale and precision metadata
> ---
>
> Key: IGNITE-17203
> URL: https://issues.apache.org/jira/browse/IGNITE-17203
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Reporter: Pavel Tupitsyn
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-alpha6
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> *scale()* and *precision()* in *ColumnMetadata* interface return incorrect 
> values. Implement them properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)