[jira] [Commented] (IGNITE-17272) Logical recovery works incorrectly for encrypted caches

2022-07-26 Thread Aleksandr Polovtcev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571310#comment-17571310
 ] 

Aleksandr Polovtcev commented on IGNITE-17272:
--

[~timonin.maksim] Thank you for noticing and fixing the problem! I will have a 
look shortly. Sorry for any inconveniences.

> Logical recovery works incorrectly for encrypted caches
> ---
>
> Key: IGNITE-17272
> URL: https://issues.apache.org/jira/browse/IGNITE-17272
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.13
>Reporter: Aleksandr Polovtcev
>Assignee: Aleksandr Polovtcev
>Priority: Major
> Fix For: 2.14
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When encryption is enabled for a particular cache, its WAL records get 
> encrypted and wrapped in an {{EncryptedRecord}}. This encrypted record type 
> is considered a {{PHYSICAL}} record, which leads to such records being 
> omitted during logical recovery regardless of the fact that it can contain 
> logical records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-17272) Logical recovery works incorrectly for encrypted caches

2022-07-25 Thread Maksim Timonin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570797#comment-17570797
 ] 

Maksim Timonin commented on IGNITE-17272:
-

[~apolovtcev]  [~ibessonov] 

Hi guys! This fix isn't fully correct. It leads to the InvalidMarkException 
while parsing encrypted records from WAL. 

I found that while investigating a reason of test ([1]) started failing. 
Actually there is a small fix [2], could you please have a look? WDYT, should I 
add more tests here?

[1] https://issues.apache.org/jira/browse/IGNITE-17215

[2] https://issues.apache.org/jira/browse/IGNITE-17408

> Logical recovery works incorrectly for encrypted caches
> ---
>
> Key: IGNITE-17272
> URL: https://issues.apache.org/jira/browse/IGNITE-17272
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.13
>Reporter: Aleksandr Polovtcev
>Assignee: Aleksandr Polovtcev
>Priority: Major
> Fix For: 2.14
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When encryption is enabled for a particular cache, its WAL records get 
> encrypted and wrapped in an {{EncryptedRecord}}. This encrypted record type 
> is considered a {{PHYSICAL}} record, which leads to such records being 
> omitted during logical recovery regardless of the fact that it can contain 
> logical records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-17272) Logical recovery works incorrectly for encrypted caches

2022-07-01 Thread Ivan Bessonov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561364#comment-17561364
 ] 

Ivan Bessonov commented on IGNITE-17272:


Looks good to me, thank you! I'll merge it to master

> Logical recovery works incorrectly for encrypted caches
> ---
>
> Key: IGNITE-17272
> URL: https://issues.apache.org/jira/browse/IGNITE-17272
> Project: Ignite
>  Issue Type: Bug
>Reporter: Aleksandr Polovtcev
>Assignee: Aleksandr Polovtcev
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When encryption is enabled for a particular cache, its WAL records get 
> encrypted and wrapped in an {{EncryptedRecord}}. This encrypted record type 
> is considered a {{PHYSICAL}} record, which leads to such records being 
> omitted during logical recovery regardless of the fact that it can contain 
> logical records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-17272) Logical recovery works incorrectly for encrypted caches

2022-06-30 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561042#comment-17561042
 ] 

Ignite TC Bot commented on IGNITE-17272:


{panel:title=Branch: [pull/10122/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/10122/head] Base: [master] : New Tests 
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}PDS (Indexing){color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=6656823]]
* {color:#013220}IgnitePdsWithIndexingCoreTestSuite: 
IgniteLogicalRecoveryEncryptionTest.testRecoverPartitionStates - PASSED{color}

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6656860buildTypeId=IgniteTests24Java8_RunAll]

> Logical recovery works incorrectly for encrypted caches
> ---
>
> Key: IGNITE-17272
> URL: https://issues.apache.org/jira/browse/IGNITE-17272
> Project: Ignite
>  Issue Type: Bug
>Reporter: Aleksandr Polovtcev
>Assignee: Aleksandr Polovtcev
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When encryption is enabled for a particular cache, its WAL records get 
> encrypted and wrapped in an {{EncryptedRecord}}. This encrypted record type 
> is considered a {{PHYSICAL}} record, which leads to such records being 
> omitted during logical recovery regardless of the fact that it can contain 
> logical records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)