[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-04-20 Thread Semen Boikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976385#comment-15976385
 ] 

Semen Boikov commented on IGNITE-1794:
--

I found that L2 cache interfaces were changed in 5.2 and it makes sense to have 
2 implementations for 5.1.X and 5.2.X. Actually implementations for various 
versions can reuse most of code, to avoid copy-paste between modules I'll 
create hibernate-core module, add hibernate-5.1 module and rename current 
'hibernate' module into 'hibernate-4.2'. Support for 5.2 will be added in 2.1 
release since it requires build changes.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Sub-task
>  Components: Hibernate L2 cache
>Reporter: Artem Shutak
>Assignee: Semen Boikov
>  Labels: important, newbie
> Fix For: 2.0
>
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-04-07 Thread Semen Boikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960661#comment-15960661
 ] 

Semen Boikov commented on IGNITE-1794:
--

Hi Vadim,

I'm going to review latest changes in next few days.

Thanks!

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Sub-task
>  Components: Hibernate L2 cache
>Reporter: Artem Shutak
>Assignee: Semen Boikov
>  Labels: important, newbie
> Fix For: 2.0
>
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-03-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933471#comment-15933471
 ] 

ASF GitHub Bot commented on IGNITE-1794:


GitHub user vopolski opened a pull request:

https://github.com/apache/ignite/pull/1643

IGNITE-1794

Fixed originally by Mykola Pereyma. Changed hibernate version to 5.2.7 and 
deleted ByteArrayType.java as per CI comments.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vopolski/ignite master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1643


commit 5bf2618b482f8b33e834d1d7b6d8be2bcf0dc3de
Author: Mykola Pereyma 
Date:   2017-01-23T16:17:53Z

IGNITE-1794 Added support of Hibernate 5.1.2.Final

commit e6fdb6ccbdfecb205ef1b82fecc46dca198f8776
Author: javaller 
Date:   2017-03-20T19:36:48Z

Merge branch 'IGNITE-1794' of https://github.com/mykola-pereyma/ignite

commit 1fa0e9b6bac3a57c35e5a457d416dfcaa94cef0a
Author: javaller 
Date:   2017-03-20T19:56:26Z

Deleted ByteArrayType and changed hibernate version to 5.2.7 IGNITE-1794




> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Task
>  Components: Hibernate L2 cache
>Reporter: Artem Shutak
>Assignee: Vadim Opolski
>  Labels: newbie
> Fix For: 2.0
>
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-02-09 Thread Anton Vinogradov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859273#comment-15859273
 ] 

Anton Vinogradov commented on IGNITE-1794:
--

[~mpereyma], we're planning 1.9. This is an excellent candidate for the 
release. Please join the discussion there and confirm that you will be able to 
complete the task by defined time:
http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-1-9-td14170.html

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Task
>  Components: Hibernate L2 cache
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Fix For: 1.9
>
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-24 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836816#comment-15836816
 ] 

Denis Magda commented on IGNITE-1794:
-

[~sboikov], as the original creator of hibernate component, please review the 
changes.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Fix For: 1.9
>
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-20 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832390#comment-15832390
 ] 

Denis Magda commented on IGNITE-1794:
-

[~mpereyma], do you think you will be able to finish the work on this ticket in 
a couple of weeks? Apache Ignite community should release one more version the 
next month and it will be great to incorporate results of your work there.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-19 Thread Valentin Kulichenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830242#comment-15830242
 ] 

Valentin Kulichenko commented on IGNITE-1794:
-

[~mpereyma], I think this is the most straightforward approach. Feel free to 
propose your own though, I don't know the details of difference between 
version, so there can be easily a better solution. But we definitely should 
continue support for Hibernate 4, too early to drop it.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-19 Thread Mykola Pereyma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829987#comment-15829987
 ] 

Mykola Pereyma commented on IGNITE-1794:


[~vkulichenko]Yes, your statement is correct - idea was to upgrade Hibernate 
5.X version and backward compatibility with Hibernate 4.X is out of scope in 
this case. Would you suggest to one module like 'hibernate5' and apply those 
changes there?

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-18 Thread Valentin Kulichenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829111#comment-15829111
 ] 

Valentin Kulichenko commented on IGNITE-1794:
-

It looks like this change is not backward compatible and moreover completely 
drops support for Hibernate 4. [~mpereyma], can you please confirm this? If so, 
I think we should create two separate modules for Hibernate 4 and 5 to support 
both.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-18 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828843#comment-15828843
 ] 

Denis Magda commented on IGNITE-1794:
-

[~vkulichenko], please review the pull-request.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>Assignee: Mykola Pereyma
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2017-01-18 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828842#comment-15828842
 ] 

Denis Magda commented on IGNITE-1794:
-

[~mpereyma], sorry for a long reply. I've found this ticket by chance. Please 
send a message to the @dev list asking for review explicitly. For now I'm 
moving the ticket into "patch available" state.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2016-10-05 Thread Mykola Pereyma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548848#comment-15548848
 ] 

Mykola Pereyma commented on IGNITE-1794:


[~ashutak] Here is PR that provides support of Hibernate 5.1.2.Final 
https://github.com/apache/ignite/pull/1146.

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2016-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548835#comment-15548835
 ] 

ASF GitHub Bot commented on IGNITE-1794:


GitHub user mykola-pereyma opened a pull request:

https://github.com/apache/ignite/pull/1146

IGNITE-1794 Added support of Hibernate 5.1.2.Final



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mykola-pereyma/ignite IGNITE-1794

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1146


commit fec8b7b6cbca461d66634e88615d734540528c7e
Author: Konstantin Smirnov 
Date:   2016-10-05T14:11:10Z

IGNITE-1794 Added support of Hibernate 5.1.2.Final




> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>  Labels: newbie
> Attachments: HibernateCollectionRegionForIgnite.java, 
> HibernateEntityRegionForIgnite.java, HibernateRegionFactoryForIgnite.java, 
> HibernateTimestampsRegionForIgnite.java
>
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1794) Ignite should support Hibernate 5

2016-10-01 Thread Anil Agrawal (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538994#comment-15538994
 ] 

Anil Agrawal commented on IGNITE-1794:
--

As a work around for Hibernate 5 compatibility issue, you can override the 
function of class HibernateRegionFactory as below

class CustomHibernateRegionFactory extends HibernateRegionFactory{
@Override
public void start(SessionFactoryOptions settings, Properties 
properties) throws CacheException {
start(new Settings(settings), properties);
}
}

And use this class as hibernate.cache.region.factory_class

> Ignite should support Hibernate 5
> -
>
> Key: IGNITE-1794
> URL: https://issues.apache.org/jira/browse/IGNITE-1794
> Project: Ignite
>  Issue Type: Test
>Reporter: Artem Shutak
>  Labels: newbie
>
> Currently Ignite supports Hibernate 4. 
> In Hibernate 5 org.hibernate.cache.spi.RegionFactory.start() method signature 
> has been changed from
> {{void start(Settings var1, Properties var2) throws CacheException;}}
> on
> {{void start(SessionFactoryOptions settings, Properties properties) throws 
> CacheException;}}
> Original user list: 
> http://apache-ignite-users.70518.x6.nabble.com/Hibernate-5-L2-Cache-Compatibility-td1656.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)