[jira] [Commented] (IGNITE-19688) NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus

2023-07-10 Thread Vladislav Pyatkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741595#comment-17741595
 ] 

Vladislav Pyatkov commented on IGNITE-19688:


Merged d13553ebdaa80ab440be487ff882e279bed37c19
[~maliev] thank you for the contribution.

> NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus
> --
>
> Key: IGNITE-19688
> URL: https://issues.apache.org/jira/browse/IGNITE-19688
> Project: Ignite
>  Issue Type: Bug
>Reporter: Yury Gerzhedovich
>Assignee: Mirza Aliev
>Priority: Blocker
>  Labels: ignite-3
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> org.apache.ignite.raft.jraft.core.ItNodeTest#testChangePeersStepsDownInJointConsensus
> {noformat}
> java.lang.NullPointerException  
>  at 
> org.apache.ignite.raft.jraft.core.ItNodeTest.testChangePeersStepsDownInJointConsensus(ItNodeTest.java:3385)
>   
>  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)  
>  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   
>  at java.base/java.lang.reflect.Method.invoke(Method.java:566) 
> {noformat}
> *Motivation*
> The root cause of the issue is the method of getting leader 
> (_TestCluster#getLeader_) might return _null_ even if the test waits a leader 
> before (_TestCluster#waitLeader_).
> *Implementation Notes*
> Create a new method that returns a leader just after it has waited it 
> (_TestCluster#waitAndGetLeader_).
> *Definition of Done*
> Verify all places where method of waiting leader is used and replace it to 
> new one in that case where getting leader is not expected to receive _null_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-19688) NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus

2023-07-10 Thread Vladislav Pyatkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741593#comment-17741593
 ] 

Vladislav Pyatkov commented on IGNITE-19688:


LGTM

> NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus
> --
>
> Key: IGNITE-19688
> URL: https://issues.apache.org/jira/browse/IGNITE-19688
> Project: Ignite
>  Issue Type: Bug
>Reporter: Yury Gerzhedovich
>Assignee: Mirza Aliev
>Priority: Blocker
>  Labels: ignite-3
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> org.apache.ignite.raft.jraft.core.ItNodeTest#testChangePeersStepsDownInJointConsensus
> {noformat}
> java.lang.NullPointerException  
>  at 
> org.apache.ignite.raft.jraft.core.ItNodeTest.testChangePeersStepsDownInJointConsensus(ItNodeTest.java:3385)
>   
>  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)  
>  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   
>  at java.base/java.lang.reflect.Method.invoke(Method.java:566) 
> {noformat}
> *Motivation*
> The root cause of the issue is the method of getting leader 
> (_TestCluster#getLeader_) might return _null_ even if the test waits a leader 
> before (_TestCluster#waitLeader_).
> *Implementation Notes*
> Create a new method that returns a leader just after it has waited it 
> (_TestCluster#waitAndGetLeader_).
> *Definition of Done*
> Verify all places where method of waiting leader is used and replace it to 
> new one in that case where getting leader is not expected to receive _null_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-19688) NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus

2023-06-28 Thread Vladislav Pyatkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738179#comment-17738179
 ] 

Vladislav Pyatkov commented on IGNITE-19688:


Except the comment, I left in PR I think, waitLeadet method is completely 
replaced and could be removed.

> NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus
> --
>
> Key: IGNITE-19688
> URL: https://issues.apache.org/jira/browse/IGNITE-19688
> Project: Ignite
>  Issue Type: Bug
>Reporter: Yury Gerzhedovich
>Assignee: Mirza Aliev
>Priority: Blocker
>  Labels: ignite-3
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> org.apache.ignite.raft.jraft.core.ItNodeTest#testChangePeersStepsDownInJointConsensus
> {noformat}
> java.lang.NullPointerException  
>  at 
> org.apache.ignite.raft.jraft.core.ItNodeTest.testChangePeersStepsDownInJointConsensus(ItNodeTest.java:3385)
>   
>  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)  
>  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   
>  at java.base/java.lang.reflect.Method.invoke(Method.java:566) 
> {noformat}
> *Motivation*
> The root cause of the issue is the method of getting leader 
> (_TestCluster#getLeader_) might return _null_ even if the test waits a leader 
> before (_TestCluster#waitLeader_).
> *Implementation Notes*
> Create a new method that returns a leader just after it has waited it 
> (_TestCluster#waitAndGetLeader_).
> *Definition of Done*
> Verify all places where method of waiting leader is used and replace it to 
> new one in that case where getting leader is not expected to receive _null_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (IGNITE-19688) NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus

2023-06-27 Thread Mirza Aliev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737843#comment-17737843
 ] 

Mirza Aliev commented on IGNITE-19688:
--

[~vpyatkov] Could you please take a look? 

> NPE in ItNodeTest#testChangePeersStepsDownInJointConsensus
> --
>
> Key: IGNITE-19688
> URL: https://issues.apache.org/jira/browse/IGNITE-19688
> Project: Ignite
>  Issue Type: Bug
>Reporter: Yury Gerzhedovich
>Assignee: Mirza Aliev
>Priority: Blocker
>  Labels: ignite-3
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> org.apache.ignite.raft.jraft.core.ItNodeTest#testChangePeersStepsDownInJointConsensus
> {noformat}
> java.lang.NullPointerException  
>  at 
> org.apache.ignite.raft.jraft.core.ItNodeTest.testChangePeersStepsDownInJointConsensus(ItNodeTest.java:3385)
>   
>  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)  
>  at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   
>  at java.base/java.lang.reflect.Method.invoke(Method.java:566) 
> {noformat}
> *Motivation*
> The root cause of the issue is the method of getting leader 
> (_TestCluster#getLeader_) might return _null_ even if the test waits a leader 
> before (_TestCluster#waitLeader_).
> *Implementation Notes*
> Create a new method that returns a leader just after it has waited it 
> (_TestCluster#waitAndGetLeader_).
> *Definition of Done*
> Verify all places where method of waiting leader is used and replace it to 
> new one in that case where getting leader is not expected to receive _null_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)