[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192896#comment-15192896
 ] 

ASF GitHub Bot commented on IGNITE-2765:


Github user avinogradovgg closed the pull request at:

https://github.com/apache/ignite/pull/543


> WebSessionFilter doesn't survive client reconnect
> -
>
> Key: IGNITE-2765
> URL: https://issues.apache.org/jira/browse/IGNITE-2765
> Project: Ignite
>  Issue Type: Bug
>  Components: websession
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
>Priority: Critical
>  Labels: community, customer, important
> Fix For: 1.6
>
>
> If a {{WebSessionFilter}} is started with an embedded client, it is not 
> functional after the client disconnects and reconnects. Any operation throws 
> the exception below.
> {noformat}
> java.lang.IllegalStateException: Cache has been closed or destroyed: WebCache
>  at 
> org.apache.ignite.internal.processors.cache.GridCacheGateway.enter(GridCacheGateway.java:160)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.onEnter(IgniteCacheProxy.java:1958)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.get(IgniteCacheProxy.java:855)
>  at 
> org.apache.ignite.cache.websession.WebSessionFilter.doFilter0(WebSessionFilter.java:341)
> {noformat}
> We should get a new instance of the cache when the exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190250#comment-15190250
 ] 

Valentin Kulichenko commented on IGNITE-2765:
-

Anton,

I reviewed the changes and have couple of comments:

* When cache is recreated, it's possible that it lready has a different 
configuration than before. I think you should move all the code on lines 
239-265 to {{initCache()}} method and call it inside {{init()}}, as well as 
instead of {{reinitCache()}}.
* I don't like that we wait on reconnect and retry futures indefinitely. This 
can cause HTTP request to hang for a long time, or even forever. I think we 
should have a configurable time out there (e.g., 5sec by default). If it times 
out, we can throw the exception right away without retrying.

Otherwise looks good!

> WebSessionFilter doesn't survive client reconnect
> -
>
> Key: IGNITE-2765
> URL: https://issues.apache.org/jira/browse/IGNITE-2765
> Project: Ignite
>  Issue Type: Bug
>  Components: websession
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
>Priority: Critical
>  Labels: community, customer, important
> Fix For: 1.6
>
>
> If a {{WebSessionFilter}} is started with an embedded client, it is not 
> functional after the client disconnects and reconnects. Any operation throws 
> the exception below.
> {noformat}
> java.lang.IllegalStateException: Cache has been closed or destroyed: WebCache
>  at 
> org.apache.ignite.internal.processors.cache.GridCacheGateway.enter(GridCacheGateway.java:160)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.onEnter(IgniteCacheProxy.java:1958)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.get(IgniteCacheProxy.java:855)
>  at 
> org.apache.ignite.cache.websession.WebSessionFilter.doFilter0(WebSessionFilter.java:341)
> {noformat}
> We should get a new instance of the cache when the exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189381#comment-15189381
 ] 

ASF GitHub Bot commented on IGNITE-2765:


GitHub user avinogradovgg opened a pull request:

https://github.com/apache/ignite/pull/543

IGNITE-2765



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-2765

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #543


commit 2e64d0d7cc51552fffc231cbc850cd615076fb85
Author: vozerov-gridgain 
Date:   2015-12-29T06:31:58Z

IGNITE-2258: IGFS: now default path modes could be optionally disabled 
using FileSystemConfiguration.isInitializeDefaultPathModes() property.

commit 4cd3b3dc2f1fa0f1a9cceb6bf544dd8fb505d7f5
Author: vozerov-gridgain 
Date:   2015-12-29T09:52:00Z

IGNITE-2258: Fixed type on getter/setter.

commit 5d58fcbf40fdb9114e4cbb32b72dd9bce7fa38ca
Author: iveselovskiy 
Date:   2016-01-04T06:47:28Z

IGNITE-2308: Fixed HadoopClassLoader dependency resolution. This closes 
#391.

commit 83a19179cee2bb15adc36c2265dd0a3c794b60bb
Author: vozerov-gridgain 
Date:   2016-01-04T08:14:58Z

IGNITE-2218: Fixed a problem with native Hadoop libraries load. This closes 
#378.

commit 1d7fb5702fa33cf395e797161f3a86a9600921a7
Author: vozerov-gridgain 
Date:   2016-01-05T06:59:31Z

IGNITE-2206: Hadoop file system creation is now abstracted out using 
factory interface.

commit a12ec7d08573d5396654a5ba05bb7d873e4c2677
Author: Ignite Teamcity 
Date:   2016-01-06T10:50:48Z

1.5.2

commit 090a5de6a930c10a3a57a6e28c486fe5c87e028d
Author: vozerov-gridgain 
Date:   2015-12-29T12:50:39Z

Minor fix.

commit c786820dda7f7cd1849c5593ac24ca9072945887
Author: vozerov-gridgain 
Date:   2016-01-07T13:48:14Z

IgniteHadoopIgfsSecondaryFileSystem.usrName field is renamed to "userName" 
to preserve backward compatibility.

commit 6ab4ce246316442fa4295f9941c372fea70c24ef
Author: vozerov-gridgain 
Date:   2016-01-08T06:23:55Z

IGNITE-2342: Set correct classlader before calling FileSystem.get().

commit 077ab1b3a77fdb1c2c2fd6360fc5b60fda6c50c3
Author: vozerov-gridgain 
Date:   2016-01-08T07:17:45Z

IGNITE-2341: Improved warning message when BinaryMarshaller cannot be used. 
Also it is not shown when "org.apache.ignite" classes is in described situation.

commit 86c4816edfd0e983014f136ffc92cde28ec56cca
Author: vozerov-gridgain 
Date:   2016-01-08T07:26:03Z

IGNITE-2340: Improved error thrown when PROXY mode exists, but secondary 
file system is not IgniteHadoopIgfsSecondaryFileSystem.

commit fc48a8429a84ef6c87ed3225a218d7d3ae617e14
Author: vozerov-gridgain 
Date:   2016-01-08T07:48:42Z

Merge branch 'ignite-1.5.2' into ignite-1.5.3

commit 86740cefe212ed0f506d81056dd8e76de9a31e4f
Author: Ignite Teamcity 
Date:   2016-01-08T09:32:11Z

1.5.3-SNAPSHOT

commit 92229d2a6c6ef86772a62cb52b3aa07a55c99d89
Author: sboikov 
Date:   2016-01-13T05:56:34Z

ignite-2359 Added locking for files used by MarshallerContextImpl. (cherry 
picked from commit 1d8c4e2)

commit 2e4ce585d5f54502c6511d3425b1cd5fbf0a7f4f
Author: Ignite Teamcity 
Date:   2016-01-13T10:37:33Z

1.5.4-SNAPSHOT

commit 6e5f9f0c7d4c86773b1f0cd5c5a673acb58c86c2
Author: Denis Magda 
Date:   2016-01-13T11:42:27Z

Changed year to 2016 in Copyrights

commit 02dbcfd8ed2701a4f415c8871d0b8fd08bfa0583
Author: Alexey Goncharuk 
Date:   2016-01-13T13:47:32Z

IGNITE-2365 - Notify policy if swap or offheap is enabled and rebalanced 
entry was not preloaded.
IGNITE-2099 - Fixing custom collections.
This closes #396

commit 86c2ba2a601e82b824cf17422683e5398a4d8c7d
Author: sboikov 
Date:   2016-01-13T15:40:08Z

ignite-2350 Pass update notifier flag in discovery data (all cluster nodes 
will have the same notifier status as first cluster node)
(cherry picked from commit 7175a42)

commit e1a494df400fc37ca04e8d88d1cf20bca02607b4
Author: sboikov 
Date:   2016-01-14T11:16:33Z

Renamed fields to change fields write order (to preserve backward 
compatibility).
(cherry picked from commit 2a4adf5)

commit 09f978234b6062afa1e1658d5a6439365a856aca
Author: sboikov 
Date:   2016-01-14T11:42:44Z

Merge remote-tracking branch 

[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188670#comment-15188670
 ] 

Valentin Kulichenko commented on IGNITE-2765:
-

Created separate tickets for Spring cache and Hibernate L2 cache:

https://issues.apache.org/jira/browse/IGNITE-2786
https://issues.apache.org/jira/browse/IGNITE-2787

> WebSessionFilter doesn't survive client reconnect
> -
>
> Key: IGNITE-2765
> URL: https://issues.apache.org/jira/browse/IGNITE-2765
> Project: Ignite
>  Issue Type: Bug
>  Components: websession
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
>Priority: Critical
>  Labels: community, customer, important
> Fix For: 1.6
>
>
> If a {{WebSessionFilter}} is started with an embedded client, it is not 
> functional after the client disconnects and reconnects. Any operation throws 
> the exception below.
> {noformat}
> java.lang.IllegalStateException: Cache has been closed or destroyed: WebCache
>  at 
> org.apache.ignite.internal.processors.cache.GridCacheGateway.enter(GridCacheGateway.java:160)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.onEnter(IgniteCacheProxy.java:1958)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.get(IgniteCacheProxy.java:855)
>  at 
> org.apache.ignite.cache.websession.WebSessionFilter.doFilter0(WebSessionFilter.java:341)
> {noformat}
> We should get a new instance of the cache when the exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181813#comment-15181813
 ] 

Valentin Kulichenko commented on IGNITE-2765:
-

The same issue exists in {{SpringCache}}.

Hibernate L2 cache should be also checked.

> WebSessionFilter doesn't survive client reconnect
> -
>
> Key: IGNITE-2765
> URL: https://issues.apache.org/jira/browse/IGNITE-2765
> Project: Ignite
>  Issue Type: Bug
>  Components: websession
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
>Priority: Critical
>  Labels: community, customer, important
> Fix For: 1.6
>
>
> If a {{WebSessionFilter}} is started with an embedded client, it is not 
> functional after the client disconnects and reconnects. Any operation throws 
> the exception below.
> {noformat}
> java.lang.IllegalStateException: Cache has been closed or destroyed: WebCache
>  at 
> org.apache.ignite.internal.processors.cache.GridCacheGateway.enter(GridCacheGateway.java:160)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.onEnter(IgniteCacheProxy.java:1958)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.get(IgniteCacheProxy.java:855)
>  at 
> org.apache.ignite.cache.websession.WebSessionFilter.doFilter0(WebSessionFilter.java:341)
> {noformat}
> We should get a new instance of the cache when the exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-2765) WebSessionFilter doesn't survive client reconnect

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180668#comment-15180668
 ] 

Valentin Kulichenko commented on IGNITE-2765:
-

This issue will be fixed automatically when IGNITE-2766 is fixed. But probably 
it's better to apply quick and easy fix here, because it seems to be more 
critical (there is no workaround for {{WebSessionFilter}}).

> WebSessionFilter doesn't survive client reconnect
> -
>
> Key: IGNITE-2765
> URL: https://issues.apache.org/jira/browse/IGNITE-2765
> Project: Ignite
>  Issue Type: Bug
>  Components: websession
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
>Priority: Critical
>  Labels: community, customer, important
> Fix For: 1.6
>
>
> If a {{WebSessionFilter}} is started with an embedded client, it is not 
> functional after the client disconnects and reconnects. Any operation throws 
> the exception below.
> {noformat}
> java.lang.IllegalStateException: Cache has been closed or destroyed: WebCache
>  at 
> org.apache.ignite.internal.processors.cache.GridCacheGateway.enter(GridCacheGateway.java:160)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.onEnter(IgniteCacheProxy.java:1958)
>  at 
> org.apache.ignite.internal.processors.cache.IgniteCacheProxy.get(IgniteCacheProxy.java:855)
>  at 
> org.apache.ignite.cache.websession.WebSessionFilter.doFilter0(WebSessionFilter.java:341)
> {noformat}
> We should get a new instance of the cache when the exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)