[jira] [Commented] (IGNITE-3216) Need to deduplicate addresses registered in the IP finder

2016-06-14 Thread Valentin Kulichenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329646#comment-15329646
 ] 

Valentin Kulichenko commented on IGNITE-3216:
-

{{viewSetReadOnly}} is not used anymore, so I would prefer to remove it 
completely. Otherwise, looks good.

> Need to deduplicate addresses registered in the IP finder
> -
>
> Key: IGNITE-3216
> URL: https://issues.apache.org/jira/browse/IGNITE-3216
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Fix For: 1.7
>
>
> {{IgniteUtils.toSocketAddresses(...)}} method can produce the collection with 
> duplicated addresses in some cases (e.g., if one of hostnames is provided as 
> an IP). We should deduplicate the list before returning it (most likely we 
> should simply use {{Set}} instead).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3216) Need to deduplicate addresses registered in the IP finder

2016-06-10 Thread Anton Vinogradov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324109#comment-15324109
 ] 

Anton Vinogradov commented on IGNITE-3216:
--

TeamCity passed.

> Need to deduplicate addresses registered in the IP finder
> -
>
> Key: IGNITE-3216
> URL: https://issues.apache.org/jira/browse/IGNITE-3216
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Fix For: 1.7
>
>
> {{IgniteUtils.toSocketAddresses(...)}} method can produce the collection with 
> duplicated addresses in some cases (e.g., if one of hostnames is provided as 
> an IP). We should deduplicate the list before returning it (most likely we 
> should simply use {{Set}} instead).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3216) Need to deduplicate addresses registered in the IP finder

2016-06-09 Thread Anton Vinogradov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322547#comment-15322547
 ] 

Anton Vinogradov commented on IGNITE-3216:
--

TeamCity failed. Collections.unmodifiableSet should be used. But I found no 
reasong to make collection unmodified.
So, will check TeamCity with returning res.

> Need to deduplicate addresses registered in the IP finder
> -
>
> Key: IGNITE-3216
> URL: https://issues.apache.org/jira/browse/IGNITE-3216
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Fix For: 1.7
>
>
> {{IgniteUtils.toSocketAddresses(...)}} method can produce the collection with 
> duplicated addresses in some cases (e.g., if one of hostnames is provided as 
> an IP). We should deduplicate the list before returning it (most likely we 
> should simply use {{Set}} instead).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3216) Need to deduplicate addresses registered in the IP finder

2016-06-08 Thread Anton Vinogradov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320734#comment-15320734
 ] 

Anton Vinogradov commented on IGNITE-3216:
--

I replaced usage of F.viewSetReadOnly(...) by 
Collections.unmodifiableCollection(...)
Will check TeamCity.

> Need to deduplicate addresses registered in the IP finder
> -
>
> Key: IGNITE-3216
> URL: https://issues.apache.org/jira/browse/IGNITE-3216
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Fix For: 1.7
>
>
> {{IgniteUtils.toSocketAddresses(...)}} method can produce the collection with 
> duplicated addresses in some cases (e.g., if one of hostnames is provided as 
> an IP). We should deduplicate the list before returning it (most likely we 
> should simply use {{Set}} instead).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3216) Need to deduplicate addresses registered in the IP finder

2016-06-08 Thread Valentin Kulichenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320611#comment-15320611
 ] 

Valentin Kulichenko commented on IGNITE-3216:
-

Anton,

Why do we need the {{F.viewSetReadOnly}} call there? Can we avoid it? I would 
prefer to remove usages of {{F.}} where possible.

> Need to deduplicate addresses registered in the IP finder
> -
>
> Key: IGNITE-3216
> URL: https://issues.apache.org/jira/browse/IGNITE-3216
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Fix For: 1.7
>
>
> {{IgniteUtils.toSocketAddresses(...)}} method can produce the collection with 
> duplicated addresses in some cases (e.g., if one of hostnames is provided as 
> an IP). We should deduplicate the list before returning it (most likely we 
> should simply use {{Set}} instead).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)