[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452242#comment-15452242
 ] 

ASF GitHub Bot commented on IGNITE-3390:


Github user isapego closed the pull request at:

https://github.com/apache/ignite/pull/1012


> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vladimir Ozerov
> Fix For: 1.8
>
> Attachments: dsn_configuration_window.png, 
> dsn_configuration_window_reworked.png, dsn_configuration_window_v3.png, 
> dsn_configuration_window_v4.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452113#comment-15452113
 ] 

ASF GitHub Bot commented on IGNITE-3390:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/1012

IGNITE-3390: Added DSN configuration window.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1012.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1012


commit dabd86c62e39eb983ef3d198c8b8ee96d2623c84
Author: Andrey Novikov 
Date:   2016-08-31T09:00:19Z

IGNITE-3811 Fixed query for merge with complex key on SQL Server.

commit 5477d3c1e342adda9fc03bc6b4d8811885ae4664
Author: isapego 
Date:   2016-08-31T12:23:59Z

IGNITE-3390: Added DSN configuration window.




> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vladimir Ozerov
> Fix For: 1.8
>
> Attachments: dsn_configuration_window.png, 
> dsn_configuration_window_reworked.png, dsn_configuration_window_v3.png, 
> dsn_configuration_window_v4.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446589#comment-15446589
 ] 

ASF GitHub Bot commented on IGNITE-3390:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/881


> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vladimir Ozerov
> Fix For: 1.8
>
> Attachments: dsn_configuration_window.png, 
> dsn_configuration_window_reworked.png, dsn_configuration_window_v3.png, 
> dsn_configuration_window_v4.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434930#comment-15434930
 ] 

Igor Sapego commented on IGNITE-3390:
-

Vladimir,

1) My bad, that was for testing purposes. Fixed.
2) We use these when we load DSN info from the system. The problem is that 
{{SetPort}} clashes with some weird [system 
macro|https://msdn.microsoft.com/en-us/library/windows/desktop/dd145081(v=vs.85).aspx]
 on Windows. That's why I added {{Tcp}} part. Do you have other naming 
proposals?
3) Fixed.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.8
>
> Attachments: dsn_configuration_window.png, 
> dsn_configuration_window_reworked.png, dsn_configuration_window_v3.png, 
> dsn_configuration_window_v4.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391696#comment-15391696
 ] 

Igor Sapego commented on IGNITE-3390:
-

Vladimir,

When I generally agree with your proposals, I'm not sure that UI is something 
for which we need to maintain backward compatibility. After all, GUI is used 
only by people except for very rare cases, so there no additional work for our 
users when GUI is changed and we are not breaking anything.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
> Attachments: dsn_configuration_window.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391398#comment-15391398
 ] 

Vladimir Ozerov commented on IGNITE-3390:
-

Looks like semicolon will not work here, and we will have to use pipe char: 
https://msdn.microsoft.com/en-us/library/ms722656(v=vs.85).aspx#Anchor_4
{{host1|host2:port2|host3}}.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
> Attachments: dsn_configuration_window.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.
> DSN stands for the Data Source Name, and it is actually list of options for 
> the ODBC driver which can be used to establish connection. In our case it is 
> set of the host name, tcp port and cache name to which connection should be 
> established. In Windows it seems to be common practice to use "ODBC Data 
> Source Administrator" system tool to configure DNS for the ODBC driver. "ODBC 
> Data Source Administrator" it it's turn uses GUI windows to get DSN 
> information from the user. So to support this feature, we'd needed to 
> implement GUI window that would allow our users to configure their own DSNs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389430#comment-15389430
 ] 

Igor Sapego commented on IGNITE-3390:
-

Vladimir,

1) Currently, there are two arguments in connection string - "Server" and 
"Port", so it is going to be confusing for users to configure "Port" parameter 
if there would not be such a field. I propose to change UI when we will change 
the way addresses are specified in ODBC and leave it "as is" for current 
approach.

2) There are actually no "not-required" fields, as every field is required 
currently.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
> Attachments: dsn_configuration_window.png
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388176#comment-15388176
 ] 

ASF GitHub Bot commented on IGNITE-3390:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/881

IGNITE-3390: Added system DSN support for Windows.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isapego/ignite ignite-3390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #881


commit 26708651eda06851a5f4e76161216d1493576e4f
Author: isapego 
Date:   2016-07-15T18:14:17Z

IGNITE-3390: Window stub implemented.

commit f7a0592611e3987e99eedc9516014a39a1e92db4
Author: isapego 
Date:   2016-07-19T15:24:36Z

IGNITE-3390: Implemented Window class prototype. Needs refactoring.

commit 115da0dda5903d35e0190c161fe4be3d9c691161
Author: isapego 
Date:   2016-07-19T16:37:29Z

IGNITE-3390: Splitted Window in two classes.

commit 0f193568167277817f295a3507c17292bd8a8d3a
Author: isapego 
Date:   2016-07-19T18:09:35Z

IGNITE-3390: Refactoring.

commit 62a5ca7fb736cb74e83cd7f29c16f92394912dcc
Author: isapego 
Date:   2016-07-20T10:21:15Z

IGNITE-3390: Implmented first version of the configuration window.

commit 6f504e959bdd55bd36bbaf161d4821899cff474f
Author: isapego 
Date:   2016-07-20T14:51:36Z

IGNITE-3390: Refactoring.

commit b084124b25953fc2a2516ca301a9619f59d631bf
Author: isapego 
Date:   2016-07-20T17:17:08Z

IGNITE-3390: Implemented retrieval of the configuration parameters.

commit c9b73555b55d1c7430f04730624383caf151ec16
Author: isapego 
Date:   2016-07-21T14:19:10Z

IGNITE-3390: Implemented saving and loading of the DSN.

commit 463c6099b766349c3abde80f6459eefde61e529f
Author: isapego 
Date:   2016-07-21T15:18:50Z

IGNITE-3390: Refactoring.

commit 92b8c72dd57fd91a27054c9a5eb195ddcc92ab18
Author: isapego 
Date:   2016-07-21T15:26:38Z

IGNITE-3390: Minor refactoring of error reporting.

commit 01eac0e3f0eb973996da4c1a6ec16d969750fe83
Author: isapego 
Date:   2016-07-21T15:43:05Z

IGNITE-3390: Implmented connection by the DSN.

commit dee6363c6f4d950954fa589e8dc7d291abf461d5
Author: isapego 
Date:   2016-07-21T15:46:01Z

IGNITE-3390: Improved logs.

commit e045507619b0a5675eb38cfcd8d08467e2036c42
Author: isapego 
Date:   2016-07-21T15:58:32Z

IGNITE-3390: Implemented SQLConnect.

commit 9097ad84231d1567a6ee78b97aabc7edd70f7a55
Author: Igor Sapego 
Date:   2016-07-21T16:26:29Z

IGNITE-3390: Added new files to Autotools build system.

commit 2049a986f9dcecd84d279d66b37bdfd2f5e2be4c
Author: isapego 
Date:   2016-07-21T16:34:00Z

IGNITE-3390: Fixed dsn_config for non-windows platforms.

commit 8e7f402a84415e551df90a7ac3266053a16bb084
Author: isapego 
Date:   2016-07-21T18:26:52Z

IGNITE-3390: Some fine-tuning of the configuration window.

commit 9233823e7268d777e1526052d59c71aeb96ce037
Author: isapego 
Date:   2016-07-21T18:30:40Z

Merge remote-tracking branch 'upstream/master' into ignite-3390




> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384883#comment-15384883
 ] 

Igor Sapego commented on IGNITE-3390:
-

Implemented some basic classes to work with WinApi. I'm going to keep them 
simple as I only need single window for now.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3390) ODBC: Add system DSN support for Windows.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383016#comment-15383016
 ] 

Igor Sapego commented on IGNITE-3390:
-

Current approach is to implement UI window which could be used by user to 
configure DSN. I'm going to use raw WinAPI for that.

> ODBC: Add system DSN support for Windows.
> -
>
> Key: IGNITE-3390
> URL: https://issues.apache.org/jira/browse/IGNITE-3390
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
> Fix For: 1.7
>
>
> Need to add support for the DSN creation/modification in Windows. To do so we 
> will need to create some UI windows with matching fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)