[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885357#comment-15885357
 ] 

ASF GitHub Bot commented on IGNITE-3487:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/1573

IGNITE-3487 Removed _key and _val from table column list



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3487

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1573


commit f5847b8129c77a5200a48d6fa64f25b2b6f5b945
Author: skalashnikov 
Date:   2017-02-27T08:33:02Z

IGNITE-3487 Removed _key and _val from table column list




> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-02-27 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885380#comment-15885380
 ] 

Sergey Kalashnikov commented on IGNITE-3487:


Implemented draft solution.
Ignite PR is https://github.com/apache/ignite/pull/1573
H2 changes can be found here : 
https://github.com/zkillingjar/h2database/tree/dev-syscolumns

[~sergi.vladykin], [~vozerov], could you please take a look at the changes? 
Thanks!

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-03-01 Thread Vladimir Ozerov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889725#comment-15889725
 ] 

Vladimir Ozerov commented on IGNITE-3487:
-

[~skalashnikov],
Could you please re-merge PR with the branch {{ignite-2.0}}, I see some 
conflicts there.

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-03-01 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889960#comment-15889960
 ] 

Sergey Kalashnikov commented on IGNITE-3487:


[~vozerov], I have resolved the conflicts with ignite-2.0 branch per your 
request.

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-03-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930392#comment-15930392
 ] 

ASF GitHub Bot commented on IGNITE-3487:


Github user skalashnikov closed the pull request at:

https://github.com/apache/ignite/pull/1573


> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-03-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930394#comment-15930394
 ] 

ASF GitHub Bot commented on IGNITE-3487:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/1638

IGNITE-3487: Made _key and _val columns hidden



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3487

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1638


commit 8946b312670b0721c3dc271c12933c80c41668ed
Author: skalashnikov 
Date:   2017-03-17T17:57:19Z

IGNITE-3487: Made _key and _val columns hidden




> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-03-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944798#comment-15944798
 ] 

ASF GitHub Bot commented on IGNITE-3487:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/1680

IGNITE-3487:  Made _key and _val columns hidden



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3487

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1680


commit 8946b312670b0721c3dc271c12933c80c41668ed
Author: skalashnikov 
Date:   2017-03-17T17:57:19Z

IGNITE-3487: Made _key and _val columns hidden

commit 10ba37183806712994ff193af886d9744da3edc1
Author: skalashnikov 
Date:   2017-03-20T09:25:39Z

IGNITE-3487: minor fixes

commit 603fe292b27ddc421d42eb9156f03b77dc1c5233
Author: skalashnikov 
Date:   2017-03-28T08:53:25Z

Merge branch 'master' of https://github.com/apache/ignite into ignite-3487




> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955133#comment-15955133
 ] 

ASF GitHub Bot commented on IGNITE-3487:


Github user skalashnikov closed the pull request at:

https://github.com/apache/ignite/pull/1680


> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955135#comment-15955135
 ] 

ASF GitHub Bot commented on IGNITE-3487:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/1727

IGNITE-3487: _key and _val fields should be excluded from 'select * from' 
queries



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3487

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1727


commit 3a10a319f54085b6f3b59a466ea9244b53eceac9
Author: Sergi Vladykin 
Date:   2017-03-09T13:16:27Z

ignite-1.9.1 - h2 version upgrade

commit 219e6285ac1ab761045df85b73296905cd07
Author: Sergi Vladykin 
Date:   2017-03-09T13:21:55Z

ignite-1.9.1 - h2 version upgrade - tests fix

commit 143a09461b352c82b02bdbb629d6aa8f90c0745a
Author: Sergi Vladykin 
Date:   2017-03-09T15:24:25Z

ignite-1.9.1 - sql index hints

commit 8946b312670b0721c3dc271c12933c80c41668ed
Author: skalashnikov 
Date:   2017-03-17T17:57:19Z

IGNITE-3487: Made _key and _val columns hidden

commit 10ba37183806712994ff193af886d9744da3edc1
Author: skalashnikov 
Date:   2017-03-20T09:25:39Z

IGNITE-3487: minor fixes

commit 603fe292b27ddc421d42eb9156f03b77dc1c5233
Author: skalashnikov 
Date:   2017-03-28T08:53:25Z

Merge branch 'master' of https://github.com/apache/ignite into ignite-3487

commit 7a42e62d7b013492a6b704bfb7bdd8440eb0d2da
Author: skalashnikov 
Date:   2017-03-28T10:10:59Z

Merge branch 'ignite-1.9.1-hints' of 
https://github.com/gridgain/apache-ignite into ignite-3487

commit ca16c40e6fcea231666ed22e27f20bc6b4aa4690
Author: skalashnikov 
Date:   2017-04-04T13:31:52Z

Merge branch 'master' of https://github.com/apache/ignite into ignite-3487




> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981392#comment-15981392
 ] 

ASF GitHub Bot commented on IGNITE-3487:


Github user skalashnikov closed the pull request at:

https://github.com/apache/ignite/pull/1727


> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981429#comment-15981429
 ] 

ASF GitHub Bot commented on IGNITE-3487:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/1865

IGNITE-3487: hidden _key and _val columns



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3487

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1865






> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-25 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982833#comment-15982833
 ] 

Sergey Kalashnikov commented on IGNITE-3487:


[~isapego], please take a look. 

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-25 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982869#comment-15982869
 ] 

Igor Sapego commented on IGNITE-3487:
-

[~skalashnikov] looks good overall. Why don't you add a test to 
{{core-test/src/cache_query_test.cpp}} as well?

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-25 Thread Pavel Tupitsyn (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982988#comment-15982988
 ] 

Pavel Tupitsyn commented on IGNITE-3487:


LINQ fixed in .NET to handle {{*}} properly.

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-26 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984462#comment-15984462
 ] 

Igor Sapego commented on IGNITE-3487:
-

[~skalashnikov], I've added some comments in review. Please check:
- Avoid using methods that accept IgniteError as it was decided to deprecate 
them. New tests should be written using throwing versions of methods.
- Prefer {{BOOST_CHECK*}} over {{BOOST_REQUIRE*}} in cases when failed check 
does not prevent test from continuing.


> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-26 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984584#comment-15984584
 ] 

Igor Sapego commented on IGNITE-3487:
-

[~skalashnikov] C++ part looks good.

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-26 Thread Pavel Tupitsyn (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984601#comment-15984601
 ] 

Pavel Tupitsyn commented on IGNITE-3487:


.NET part looks good to me.

> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-3487) _key and _val fields should be excluded from 'select * from' queries

2017-04-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988316#comment-15988316
 ] 

ASF GitHub Bot commented on IGNITE-3487:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1865


> _key and _val fields should be excluded from 'select * from' queries
> 
>
> Key: IGNITE-3487
> URL: https://issues.apache.org/jira/browse/IGNITE-3487
> Project: Ignite
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.6
>Reporter: Valentin Kulichenko
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.0
>
>
> We have a pretty serious usability issue - predefined {{_key}} and {{_val}} 
> fields are returned when query like {{select * from}} is executed. First of 
> all, this is counterintuitive because user never defines or configures these 
> fields. Second of all, they actually duplicate all other fields. And finally, 
> they cause serialization exceptions because classes for key and value are not 
> always available.
> We should exclude these fields from {{select * from}} queries, but this is a 
> compatibility breaking change. It should be done in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)