[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984392#comment-16984392
]
Andrey N. Gura commented on IGNITE-3495:
[~mmuzaf] Actually IEP-35 doesn't solve this problem. We should reconsider
approach for measurement of cache operation. So I reopened issue and targeted
it to 3.0.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 1.6
>Reporter: Denis A. Magda
>Priority: Major
> Labels: iep-6
> Fix For: 2.8
>
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494561#comment-16494561
]
Dmitriy Setrakyan commented on IGNITE-3495:
---
[~agoncharuk], any idea what to do with this ticket? Should it be fixed or
closed as "Won't Fix"?
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 1.6
>Reporter: Denis Magda
>Assignee: Alexey Goncharuk
>Priority: Major
> Labels: iep-6
> Fix For: 2.6
>
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393942#comment-15393942
]
Vladislav Pyatkov commented on IGNITE-3495:
---
Unfortunately, there is metrics do not reflect real life.
Correction of the behavior leads to other issues it the current implementation
of metrics.
By my assume, the interface requires a review and rework measure processing.
The task will be delayed until the interface will not be revised.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385573#comment-15385573
]
Alexey Goncharuk commented on IGNITE-3495:
--
Updating metrics in the future listener is also a good idea since we already
have this listener.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385568#comment-15385568
]
Alexey Goncharuk commented on IGNITE-3495:
--
In this case you should have tracked the exact moment when the response message
is written to socket and ACKed from remote server. Get futures give us good
enough get estimate, because if there is something besides the Get* futures
that affects get performance, this should be fixed.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385554#comment-15385554
]
Vladislav Pyatkov commented on IGNITE-3495:
---
[~agoncharuk] I think, duration is the execution time of the method (Not time
consume to access to data).
The functionality is not new for Ignite. You can see how to do it in
(cache.GridCacheAdapter#put()).
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385539#comment-15385539
]
Alexey Goncharuk commented on IGNITE-3495:
--
Vlad,
I do not like that we keep get metrics calculation in message-specific code.
This should be handled in GridDhtGetFuture and GridDhtSingleGetFuture.
Essentially, metrics should be updated with the future completion time.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384749#comment-15384749
]
Denis Magda commented on IGNITE-3495:
-
[~agoncharuk], please provide your feedback on this topic.
[~v.pyatkov], please make sure to support the same for
{{CacheMetrics.getAveragePutTime}} and {{CacheMetrics.getAverageRemoveTime}}.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Vladislav Pyatkov
> Attachments: ExampleNodeStartupClient.java, IGNITE_3495.patch,
> example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3495) CacheMetrics.getAverage###Time is not calculated properly
[
https://issues.apache.org/jira/browse/IGNITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383652#comment-15383652
]
Vladislav Pyatkov commented on IGNITE-3495:
---
I will take it upon myself.
> CacheMetrics.getAverage###Time is not calculated properly
> -
>
> Key: IGNITE-3495
> URL: https://issues.apache.org/jira/browse/IGNITE-3495
> Project: Ignite
> Issue Type: Bug
>Reporter: Denis Magda
>Assignee: Andrey Velichko
> Attachments: ExampleNodeStartupClient.java, example-default.xml
>
>
> {{CacheMetrics.getAverageGetTime}}, {{CacheMetrics.getAveragePutTime}} and
> {{CacheMetrics.getAverageRemoveTime}} are not calculated properly in the
> following scenario:
> - start a server node;
> - start a client node that will perform gets and puts;
> - {{CacheMetrics.getAverage###Time}} will always be 0 for the server node's
> cluster group.
> The issue happens because {{CacheMetricsImpl.add###TimeNanos}} method is not
> called on the server side when a metric related event happens.
> In the attache you can find source that showcases the bug.
> - start basic {{ExampleNodeStartup}} using attached configuration
> {{example-default.xml}} conjuration;
> - start {{ExampleNodeStartupClient}}. You will see that average metrics are
> not incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
