[jira] [Commented] (IGNITE-3506) .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants
[ https://issues.apache.org/jira/browse/IGNITE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950759#comment-15950759 ] Pavel Tupitsyn commented on IGNITE-3506: Merged to master > .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants > > > Key: IGNITE-3506 > URL: https://issues.apache.org/jira/browse/IGNITE-3506 > Project: Ignite > Issue Type: Improvement > Components: platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .net, breaking-api > Fix For: 2.0 > > > 1) Abbreviations should not be used > 2) Constants in generic class are not good > 2.0 migration guide has to be updated if needed: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-3506) .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants
[ https://issues.apache.org/jira/browse/IGNITE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950749#comment-15950749 ] ASF GitHub Bot commented on IGNITE-3506: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1695 > .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants > > > Key: IGNITE-3506 > URL: https://issues.apache.org/jira/browse/IGNITE-3506 > Project: Ignite > Issue Type: Improvement > Components: platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .net, breaking-api > Fix For: 2.0 > > > 1) Abbreviations should not be used > 2) Constants in generic class are not good > 2.0 migration guide has to be updated if needed: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-3506) .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants
[ https://issues.apache.org/jira/browse/IGNITE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948725#comment-15948725 ] ASF GitHub Bot commented on IGNITE-3506: GitHub user ptupitsyn opened a pull request: https://github.com/apache/ignite/pull/1695 IGNITE-3506 .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants You can merge this pull request into a Git repository by running: $ git pull https://github.com/ptupitsyn/ignite ignite-3506 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1695.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1695 commit 8631157416527d67e307a3a94cb76c9b73223b13 Author: Pavel Tupitsyn Date: 2017-03-30T07:34:15Z IGNITE-3506 .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants commit 1ef4ba2a7af15f7387945dc3f7434472a6921fe5 Author: Pavel Tupitsyn Date: 2017-03-30T07:38:01Z Add defaults test commit 6e55d1dfc179e73cb77cd8d245a15958a4ced06c Author: Pavel Tupitsyn Date: 2017-03-30T07:41:46Z Fix QueryBase commit 099d056bac19bb4f2f3b1f2151315e0cb31512e4 Author: Pavel Tupitsyn Date: 2017-03-30T07:42:39Z Fix SqlFieldsQuery > .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants > > > Key: IGNITE-3506 > URL: https://issues.apache.org/jira/browse/IGNITE-3506 > Project: Ignite > Issue Type: Improvement > Components: platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .net, breaking-api > Fix For: 2.0 > > > 1) Abbreviations should not be used > 2) Constants in generic class are not good > 2.0 migration guide has to be updated if needed: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-3506) .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants
[ https://issues.apache.org/jira/browse/IGNITE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948575#comment-15948575 ] Pavel Tupitsyn commented on IGNITE-3506: Common way to fix constants in generic classes is to introduce a non-generic base class. > .NET: Fix ContinuousQuery, QueryBase, and SqlFieldsQuery class constants > > > Key: IGNITE-3506 > URL: https://issues.apache.org/jira/browse/IGNITE-3506 > Project: Ignite > Issue Type: Improvement > Components: platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .net, breaking-api > Fix For: 2.0 > > > 1) Abbreviations should not be used > 2) Constants in generic class are not good > 2.0 migration guide has to be updated if needed: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide -- This message was sent by Atlassian JIRA (v6.3.15#6346)
