[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389375#comment-15389375
 ] 

ASF GitHub Bot commented on IGNITE-3515:


Github user kromulan closed the pull request at:

https://github.com/apache/ignite/pull/875


> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-22 Thread Krome Plasma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389205#comment-15389205
 ] 

Krome Plasma commented on IGNITE-3515:
--

Updated pull request.

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-21 Thread Krome Plasma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387636#comment-15387636
 ] 

Krome Plasma commented on IGNITE-3515:
--

[~dmagda] Done, please recheck.

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-21 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387559#comment-15387559
 ] 

Denis Magda commented on IGNITE-3515:
-

However the exception is printed out to the logger output, correct? In such a 
case you can use {{GridStringLogger}} in the test that will help to check that 
there is no {{NPE}} when your fixed is applied. Look for {{GridStringLogger}} 
usages to see how it's being used in the tests.

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-21 Thread Krome Plasma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387556#comment-15387556
 ] 

Krome Plasma commented on IGNITE-3515:
--

[~dmagda] it's not possible for me to make a test for this as Ignite wraps 
exception and cannot catch it in the test and fail the test. I was also 
discussing this with [~vladisav].

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-20 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386424#comment-15386424
 ] 

Denis Magda commented on IGNITE-3515:
-

Krome,

Please add the test to {{IgniteSemaphoreAbstractSelfTest}} test class and 
update the pull-request.

After that check "... Data Structures" related tests on TeamCity as its said at 
the very end of this documentation
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

I do understand that validation on TeamCity may look redundant but this will 
help you getting to know with the Ignite dev process.

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-20 Thread Krome Plasma (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385907#comment-15385907
 ] 

Krome Plasma commented on IGNITE-3515:
--

Simple test:

@Test
public void test ()
{
 try (Ignite ignite = Ignition.start())
 {
  ignite.semaphore("REMI", 100, true, true);
 }
}

> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
>Assignee: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3515) NullPointerException when stopping IgniteSemaphore and no method has been called previously to initialize semaphore with initializeSemaphore().

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385792#comment-15385792
 ] 

ASF GitHub Bot commented on IGNITE-3515:


GitHub user kromulan opened a pull request:

https://github.com/apache/ignite/pull/875

IGNITE-3515

Null check for sync object added to IgniteSemaphore implementation stop 
method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kromulan/ignite IGNITE-3515

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #875


commit b72e5788e735f8ed34add648638450ba3f51bbca
Author: Krome Plasma 
Date:   2016-07-20T12:41:26Z

IgniteSemaphore implementation stop method null check




> NullPointerException when stopping IgniteSemaphore and no method has been 
> called previously to initialize semaphore with initializeSemaphore().
> ---
>
> Key: IGNITE-3515
> URL: https://issues.apache.org/jira/browse/IGNITE-3515
> Project: Ignite
>  Issue Type: Bug
>  Components: data structures
>Affects Versions: 1.6
>Reporter: Krome Plasma
> Fix For: 1.7
>
>
> IgniteSemaphore stop() method does not check if internal synchronization 
> object 'sync' is null hence null pointer exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)