[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407807#comment-15407807
]
ASF GitHub Bot commented on IGNITE-3625:
GitHub user tledkov-gridgain opened a pull request:
https://github.com/apache/ignite/pull/923
IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-3625
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/923.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #923
commit 6be0a6f16fc76792dd35c82e992c7b685526c512
Author: tledkov-gridgain
Date: 2016-08-04T09:31:44Z
IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 1.8
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409140#comment-15409140
]
Taras Ledkov commented on IGNITE-3625:
--
[Tests
results|http://149.202.210.143:8111/project.html?projectId=IgniteTests&branch_IgniteTests=pull%2F923%2Fhead]
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 1.8
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428107#comment-15428107
]
Taras Ledkov commented on IGNITE-3625:
--
Should IGFS provide default configurations for meta and data caches?
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428329#comment-15428329
]
ASF GitHub Bot commented on IGNITE-3625:
Github user tledkov-gridgain closed the pull request at:
https://github.com/apache/ignite/pull/923
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[ https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428343#comment-15428343 ] ASF GitHub Bot commented on IGNITE-3625: GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/972 IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3625 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/972.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #972 commit 1d0cbb45cd61c5c8e6ec926d7e629eb94111b32f Author: vd-pyatkov Date: 2016-08-11T05:43:50Z IGNITE-3618: Client can not load data after server restarts. This closes #941. commit 1139a9f76b5d37073261d729a15b1fbec674d48d Author: vozerov-gridgain Date: 2016-08-11T05:47:48Z Added missing license. commit 0b4ffdbcce63e5ce53572f71af967cff300d5670 Author: vozerov-gridgain Date: 2016-08-14T15:18:40Z IGNITE-2852: Fixed TreeMap and TreeSet serialization. commit 89bce0fc5cb3dba56626c7088e607d0b25c3353c Author: vozerov-gridgain Date: 2016-06-30T10:14:16Z IGNITE-3021: IGFS: Fixed failiing IgfsStreamsSelfTest.testCreateFileColocated() test. Failure as caused by misconfiguration. commit 78aa065b4c7b05381b1fa31159b74969ec4a2bfe Author: vozerov-gridgain Date: 2016-07-21T10:15:35Z IGNITE-826: Removed HadoopHashMapSelfTest.testAllocation() as it tested nothing. commit f87ca482420fc1e6ffcb000a227717142d24e270 Author: vozerov-gridgain Date: 2016-07-21T10:15:41Z IGNITE-826: Removed HadoopHashMapSelfTest.testAllocation() as it tested nothing. commit 9ddf9d846f52a4e8fc433643409993884c70ce37 Author: vozerov-gridgain Date: 2016-07-21T13:00:45Z IGNITE-466: IGFS: Added "IgfsMode mode(IgfsPath)" method. commit dc81069ba9ebb88bc11cf6917e8733cc1f6de2fb Author: Ivan Veselovskiy Date: 2016-08-02T08:11:24Z IGNITE-3343: IGFS: Secondary file system is not queried for statuses during MKDIRS and CREATE operations. This closes #896. commit ae54e36f27719f46d1d276f62a977c3f8d053b44 Author: tledkov-gridgain Date: 2016-08-04T14:04:41Z IGNITE-3331 IGFS: Route client tasks to primary node when metadata co-location is enabled. This closes #921. commit 970137b1db7dc6c5e546581e22e428ae15c86513 Author: vozerov-gridgain Date: 2016-08-05T12:05:32Z IGNITE-3631: IGFS: Now metadata co-location is used for PARTITIONED cache as well. commit 4d876a7560060c892908da447178e97bfe12ca9c Author: vozerov-gridgain Date: 2016-08-05T12:05:43Z IGNITE-3631: IGFS: Now metadata co-location is used for PARTITIONED cache as well. commit f5a040a01280c654df1fc4789cc39ff1ac2d32a4 Author: tledkov-gridgain Date: 2016-08-09T07:01:56Z IGNITE-3332: IGFS: Optimized file unlock routine with help of a client callable. This closes #916. commit 5cf3bea32a25ccc78641f083aa7f1ac81b4187ba Author: vozerov-gridgain Date: 2016-08-15T10:40:41Z IGNITE-1926: IGFS: Implemented local secondary file system. commit 278633eced6d8039b5be4a18eefe6c65650aba4f Author: Yakov Zhdanov Date: 2016-08-15T11:27:22Z IGNITE-3688: Fixed visiblity issue in GridCacheIoManager.idxClsHandlers. commit 09a3922d57f9a4c8fbe6c1056f3ea128869c250e Author: vozerov-gridgain Date: 2016-08-16T09:52:09Z IGNITE-3692: IGFS: Test fixes. commit 476081b9171b1b8e5ec0a1ffd7e87092da3601d6 Author: Tikhonov Nikolay Date: 2016-08-17T11:31:20Z Fixed isReadFromBackup behaviour for transaction. This closes #955. commit 97d1a6f6f1d30507ad93122eb9ea63285cdffde7 Author: tledkov-gridgain Date: 2016-08-18T12:06:04Z IGNITE-3694 IgfsLocalSecondaryFileSystemDualAsyncSelfTest.testAppendConsistencyMultithreaded hangs commit 8aa534a6124c066801e6627f36179934653fe59f Author: nikolay_tikhonov Date: 2016-08-18T15:21:22Z IGNITE-2559 Fixed Transaction hangs if entry processor is not serializable. This closes #951. commit a20ca351b33efb07b83c6f5967fa7a3cef154c83 Author: sboikov Date: 2016-08-19T07:37:59Z ignite-3547 Do not try to re-send message using the same client. Remove disconnected client from 'onDisconnected' callback. commit 9db16d1b2a23e703546c472676620139e82e747f Author: Alexey Kuznetsov Date: 2016-08-19T10:40:30Z Fixed NPE in special case. commit a6eb20e934710ac53319573a7e2d71493bde8c4e Author: tledkov-gridgain Date: 2016-08-18T16:22:01Z IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches commit 4ca097edd701531e01a670b16e9a2e4b986d0395 Author: tledkov-gridgain Date: 2016-08-19T15:37:48Z Merge remote-tracking branch 'remotes/community/ignite-1.6.6' into ignite-3625 > IGFS: Use common namin
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430379#comment-15430379
]
Taras Ledkov commented on IGNITE-3625:
--
[Tests
results|http://149.202.210.143:8111/project.html?projectId=IgniteTests&branch_IgniteTests=pull%2F972%2Fhead]
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438881#comment-15438881
]
Taras Ledkov commented on IGNITE-3625:
--
*1* - Should we rename the pre-configured user's cache in this case?
*2-5* - fixed.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732375#comment-15732375
]
Taras Ledkov commented on IGNITE-3625:
--
Merged
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766892#comment-15766892
]
Vladimir Ozerov commented on IGNITE-3625:
-
I still do not quite understand why do we need some magic in getters and
setter. Can we do the following?
1) If cache name is set explicitly, then use it.
2) If not, then pick relevant cache configuration, convert cache name, and add
this cache to startup list.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766958#comment-15766958
]
Taras Ledkov commented on IGNITE-3625:
--
In this case we cannot guarantee that IGFS uses the cache with standard name.
Also we should support both configuration: by cache name and by cache
configuration.
Should the {{getDataCacheName}} and {{getMetaCacheName}} methods be marked as
deprecated in this case?
Support of the {{getCacheName}} / {{setCacheName}} makes the solution is more
complicated. In all places of code where we use cache names we must be check
IGFS configuration: what is used cache name used or cache config.
What about mixed mixed configurations: e.g. data cache is configured by name
and meta by cache config?
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811734#comment-15811734
]
Taras Ledkov commented on IGNITE-3625:
--
- *1-5* - fixed;
- *6, 7* - You are right. Caches configuration is removed from
{{default-config.xml}} and {{JettyRestProcessorAbstractSelfTest}} but I thing
we should leave caches configurations at the {{example-igfs.xml}} to provide
example of configuration.
- *8* - The patch doesn't contain changes at the
{{VisorCacheQueryDetailMetricsCollectorTask}} and
{{VisorNodeDataCollectorJob}}. Sorry, I forgot to merge the branch with last
changes on ignite-2.0. Re-merged.
- *9, 10, 11* - fixed.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829822#comment-15829822
]
Vladimir Ozerov commented on IGNITE-3625:
-
Taras,
Looks good to me. I made several minor corrections and merged with
{{ignite-2.0}} branch. The only thing I am concerned about is changes to Visor
classes. Could you please ask Visor experts, e.g. [~kuaw26] to review them?
Also I would perform another IGFS/Hadoop tests run since lots of changes were
merged from {{ignite-2.0}}.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849518#comment-15849518
]
Alexey Kuznetsov commented on IGNITE-3625:
--
Taras, in general looks good for me, but when I started some my tests I got
following exception:
{code}
Cache name cannot match the template "igfs-(-data|-meta)" because it
is reserved for IGFS internal purposes.
{code}
And I have no idea what cache has wrong name. How about to print actual cache
name in order user to be able quickly found wrong name and fix it?
The exception message could look like this:
{code}
Cache name '' cannot match the template "igfs-(-data|-meta)"
because it is reserved for IGFS internal purposes.
{code}
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Alexey Kuznetsov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849682#comment-15849682
]
Taras Ledkov commented on IGNITE-3625:
--
[~akuznetsov], the issue of exception message is fixed. Please review.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869808#comment-15869808
]
Taras Ledkov commented on IGNITE-3625:
--
[~vozerov],
It depends on the Ignite backward compatibility policy.
Now the most code to support both (old and new) types of IGFS cache
configurations is placed at the {{IgfsUtils}}:
- isIgfsCache
- prepareCacheConfigurations & validateLocalIgfsConfigurations
- get(Data|Meta)CacheName.
We can simplify these methods when old IGFS caches configurations is dropped.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869833#comment-15869833
]
Vladimir Ozerov commented on IGNITE-3625:
-
[~tledkov-gridgain], I would vote for removing old getters/setters then.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
[
https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871568#comment-15871568
]
Taras Ledkov commented on IGNITE-3625:
--
The getters and setter of the cache names are removed from IGFS configuration.
[Tests|http://195.239.208.174/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull%2F972%2Fhead]
are re-run.
> IGFS: Use common naming for IGFS meta and data caches.
> --
>
> Key: IGNITE-3625
> URL: https://issues.apache.org/jira/browse/IGNITE-3625
> Project: Ignite
> Issue Type: Task
> Components: IGFS
>Affects Versions: 1.6
>Reporter: Vladimir Ozerov
>Assignee: Taras Ledkov
> Fix For: 2.0
>
>
> Currently IGFS is configured by passing names of two caches: meta and data.
> See {{FileSystemConfiguration.metaCacheName}} and
> {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the
> user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es,
> or if it is configured as both meta and data cache for a single IGFS, then
> throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to
> {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed
> both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should
> be thrown. The most simple way: throw an exception if user-configured cache
> name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
