[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876274#comment-16876274 ] Denis Mekhanikov commented on IGNITE-3653: -- [~Pavlukhin], good catch, thanks. Fixed. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876254#comment-16876254 ] Ivan Pavlukhin commented on IGNITE-3653: [~dmekhanikov], I left a small [comment|https://github.com/apache/ignite/pull/4566#pullrequestreview-256381353] on GitHub regarding enabling one test. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876009#comment-16876009 ] Dmitriy Govorukhin commented on IGNITE-3653: [~dmekhanikov] Looks good for me. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[
https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863141#comment-16863141
]
Ignite TC Bot commented on IGNITE-3653:
---
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Core Linux){color} [[tests 3 TIMEOUT
|https://ci.ignite.apache.org/viewLog.html?buildId=4108742]]
{color:#d04437}Platform .NET{color} [[tests 3 TIMEOUT
|https://ci.ignite.apache.org/viewLog.html?buildId=4108744]]
* exe:
CacheQueriesRestartServerTest.Test_ScanQueryAfterClientReconnect_ReturnsResults(False)
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4102688buildTypeId=IgniteTests24Java8_RunAll]
> P2P doesn't work for remote filter and filter factory.
> --
>
> Key: IGNITE-3653
> URL: https://issues.apache.org/jira/browse/IGNITE-3653
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 1.6
>Reporter: Nikolai Tikhonov
>Assignee: Denis Mekhanikov
>Priority: Major
> Fix For: 2.8
>
> Attachments: CCP2PTest.patch
>
>
> Remote filter and filter factory classes were not deployed on nodes which
> join to cluster after their initialization. Test attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695697#comment-16695697 ] Amelchev Nikita commented on IGNITE-3653: - [~dmekhanikov], thanks for looking at this issue! I'll continue discussing this problem in IGNITE-10238. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695171#comment-16695171 ] Denis Mekhanikov commented on IGNITE-3653: -- [~NSAmelchev], I took another look at the _GridContinuousProcessor.processStartRequest_ procedure, and now I doubt, that you can do CQ deployment asynchronously from processing of the discovery message. Deployment result is written into the discovery message, that is being processed, so deployment should happen before the message is passed further. I'm afraid, this ticket doesn't address this issue, > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695134#comment-16695134 ] Denis Mekhanikov commented on IGNITE-3653: -- [~NSAmelchev], I'm currently working on a similar problem, but regarding continuous queries being deployed to joining nodes. This is pretty similar to the problem, that you described, because I'm moving deserialization to a system thread pool and making it asynchronous. But I'm not going to fix the problem with processing of _StartRoutineDiscoveryMessage_ under this ticket. I think, work on IGNITE-10238 should be started after this ticket is resolved. I'm implementing mechanisms for asynchronous P2P class loading, and the same challenge will arise in another ticket. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693576#comment-16693576 ] Amelchev Nikita commented on IGNITE-3653: - Hi, [~dmekhanikov]. I would ask you about one problem in continuous queries. Discovery protocol with mutable messages has a problem: When _GridContinuousProcessor.processStartRequest_ processes the _StartRoutineDiscoveryMessage_ message it sends some other messages for unmarshal (when peerClsLoading enabled). It may lead to deadlock disco threads (IGNITE-10238). It is not possible to take this out to the system pool because the modified message needs to be sent across the ring. Will your changes fix the problem? > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668815#comment-16668815 ] ASF GitHub Bot commented on IGNITE-3653: GitHub user dmekhanikov reopened a pull request: https://github.com/apache/ignite/pull/4566 IGNITE-3653 Fix P2P class loading for remote filter and filter factory in CQs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3653 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4566.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4566 commit f33c53d8895d5b9764fc3daddc213aa0f530e06d Author: Denis Mekhanikov Date: 2018-08-17T12:18:01Z IGNITE-3653 Add tests. commit c598082d504f6b9f8bde4e020be3e4960da9b7ff Author: Denis Mekhanikov Date: 2018-08-17T14:32:04Z IGNITE-3653 Call p2pUnmarshal() before registering CQ handler on data exchange. commit 5a0423aaab7f9c36552da5464ce143750bb385fd Author: Denis Mekhanikov Date: 2018-09-05T12:21:45Z IGNITE-3653 Use GridToStringBuilder for CacheContinuousQueryDeployableObject. commit d7ffa09674ddc3780ae3a9c6cade63cc4e0c7bc7 Author: Denis Mekhanikov Date: 2018-09-06T08:13:23Z IGNITE-3653 Check that P2P class loading is enabled. commit 6531f2a28504586cc3294aa71ca6f4a871e5cf42 Author: Denis Mekhanikov Date: 2018-10-19T12:36:26Z IGNITE-3653 Exclude bytes from CacheContinuousQueryDeployableObject.toString > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668813#comment-16668813 ] ASF GitHub Bot commented on IGNITE-3653: Github user dmekhanikov closed the pull request at: https://github.com/apache/ignite/pull/4566 > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.8 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584012#comment-16584012 ] ASF GitHub Bot commented on IGNITE-3653: GitHub user dmekhanikov opened a pull request: https://github.com/apache/ignite/pull/4566 IGNITE-3653 Fix P2P class loading for remote filter and filter factory in CQs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3653 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4566.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4566 commit 48ce5e66e199c1a3c2593d40e0cb7a8e61d279c3 Author: Denis Mekhanikov Date: 2018-08-17T12:18:01Z IGNITE-3653 Add tests. commit 31a81d8d3d3cdccb58b8d98f11d3a55fdfe281d6 Author: Denis Mekhanikov Date: 2018-08-17T14:32:04Z IGNITE-3653 Call p2pUnmarshal() before registering CQ handler on data exchange. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolai Tikhonov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.7 > > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-3653) P2P doesn't work for remote filter and filter factory.
[ https://issues.apache.org/jira/browse/IGNITE-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310748#comment-16310748 ] tonysze commented on IGNITE-3653: - In Ignite 2.3.0, I have added the following line in org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryHandler.register (line number 317): p2pUnmarshal(ctx.localNodeId(), ctx); Just before: final CacheEntryEventFilter filter = getEventFilter(); Afterward, the RemoteFilter can be loaded, *PROVIDED* that the RemoteFilterFactory class is already available on the Server node. Continuous Query also seems working and can fail over between server nodes. If the RemoteFilterFactory class is not available on the server node, there would be another exception. Also, I haven't ran the full set of test cases yet, so not sure if it may introduce other problems. > P2P doesn't work for remote filter and filter factory. > -- > > Key: IGNITE-3653 > URL: https://issues.apache.org/jira/browse/IGNITE-3653 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 1.6 >Reporter: Nikolay Tikhonov > Attachments: CCP2PTest.patch > > > Remote filter and filter factory classes were not deployed on nodes which > join to cluster after their initialization. Test attached. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
