[jira] [Commented] (IGNITE-3876) ODBC: Check all output parameters for nulls before assignment.
[ https://issues.apache.org/jira/browse/IGNITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523665#comment-15523665 ] ASF GitHub Bot commented on IGNITE-3876: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1099 > ODBC: Check all output parameters for nulls before assignment. > --- > > Key: IGNITE-3876 > URL: https://issues.apache.org/jira/browse/IGNITE-3876 > Project: Ignite > Issue Type: Task > Components: odbc >Affects Versions: 1.7 >Reporter: Igor Sapego >Assignee: Vladimir Ozerov > Labels: odbc > Fix For: 1.8 > > > Currently, we suppose that all the output pointer parameters are not null and > point to the valid data. Practice shows that a lot of users call ODBC > functions with NULL parameters if they don't need some of the output values. > Review the API and add all necessary null-checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3876) ODBC: Check all output parameters for nulls before assignment.
[ https://issues.apache.org/jira/browse/IGNITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523199#comment-15523199 ] Vladimir Ozerov commented on IGNITE-3876: - Fixed. > ODBC: Check all output parameters for nulls before assignment. > --- > > Key: IGNITE-3876 > URL: https://issues.apache.org/jira/browse/IGNITE-3876 > Project: Ignite > Issue Type: Task > Components: odbc >Affects Versions: 1.7 >Reporter: Igor Sapego >Assignee: Vladimir Ozerov > Labels: odbc > Fix For: 1.8 > > > Currently, we suppose that all the output pointer parameters are not null and > point to the valid data. Practice shows that a lot of users call ODBC > functions with NULL parameters if they don't need some of the output values. > Review the API and add all necessary null-checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3876) ODBC: Check all output parameters for nulls before assignment.
[ https://issues.apache.org/jira/browse/IGNITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523175#comment-15523175 ] Vladimir Ozerov commented on IGNITE-3876: - Merged. > ODBC: Check all output parameters for nulls before assignment. > --- > > Key: IGNITE-3876 > URL: https://issues.apache.org/jira/browse/IGNITE-3876 > Project: Ignite > Issue Type: Task > Components: odbc >Affects Versions: 1.7 >Reporter: Igor Sapego >Assignee: Vladimir Ozerov > Labels: odbc > Fix For: 1.8 > > > Currently, we suppose that all the output pointer parameters are not null and > point to the valid data. Practice shows that a lot of users call ODBC > functions with NULL parameters if they don't need some of the output values. > Review the API and add all necessary null-checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3876) ODBC: Check all output parameters for nulls before assignment.
[ https://issues.apache.org/jira/browse/IGNITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510633#comment-15510633 ] ASF GitHub Bot commented on IGNITE-3876: GitHub user isapego opened a pull request: https://github.com/apache/ignite/pull/1099 IGNITE-3876: Added null-pointer checks and tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1099.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1099 commit aecdbc0c87095acc9947e7826e33f55a0b15fe07 Author: isapego Date: 2016-09-20T17:42:11Z IGNITE-3876: Added robustness tests. commit e3a85ab59a60a93682ba87d16211d7a5fe1e38d7 Author: isapego Date: 2016-09-21T17:36:00Z IGNITE-3876: More tests and fixes. > ODBC: Check all output parameters for nulls before assignment. > --- > > Key: IGNITE-3876 > URL: https://issues.apache.org/jira/browse/IGNITE-3876 > Project: Ignite > Issue Type: Task > Components: odbc >Affects Versions: 1.7 >Reporter: Igor Sapego >Assignee: Igor Sapego > Labels: odbc > Fix For: 1.8 > > > Currently, we suppose that all the output pointer parameters are not null and > point to the valid data. Practice shows that a lot of users call ODBC > functions with NULL parameters if they don't need some of the output values. > Review the API and add all necessary null-checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3876) ODBC: Check all output parameters for nulls before assignment.
[ https://issues.apache.org/jira/browse/IGNITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507254#comment-15507254 ] Igor Sapego commented on IGNITE-3876: - I'm going to add checks and tests for all the functions with output parameters. > ODBC: Check all output parameters for nulls before assignment. > --- > > Key: IGNITE-3876 > URL: https://issues.apache.org/jira/browse/IGNITE-3876 > Project: Ignite > Issue Type: Task > Components: odbc >Affects Versions: 1.7 >Reporter: Igor Sapego >Assignee: Igor Sapego > Labels: odbc > Fix For: 1.8 > > > Currently, we suppose that all the output pointer parameters are not null and > point to the valid data. Practice shows that a lot of users call ODBC > functions with NULL parameters if they don't need some of the output values. > Review the API and add all necessary null-checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
