[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-04-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971076#comment-15971076
 ] 

ASF GitHub Bot commented on IGNITE-4587:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1808


> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-04-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971021#comment-15971021
 ] 

ASF GitHub Bot commented on IGNITE-4587:


GitHub user glukos opened a pull request:

https://github.com/apache/ignite/pull/1808

IGNITE-4587: Found bug - CacheVersionIO is changed, but size isn't



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite IGNITE-4587-version-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1808


commit 3590a6796dc440d49223b8c94e9bac53e4d51e6c
Author: Ivan Rakov 
Date:   2017-04-17T12:34:14Z

IGNITE-4587: Found bug - CacheVersionIO is changed, but size isn't




> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-30 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948936#comment-15948936
 ] 

Andrey Gura commented on IGNITE-4587:
-

Good news! I'll run tests once again and then merge changes into master.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-29 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948419#comment-15948419
 ] 

Denis Magda commented on IGNITE-4587:
-

[~dreamx], [~agura],

Looking at the benchmarking results produced by one of my colleagues I didn't 
spot any performance degradation between 1.9 and 2.0 for PRIMARY write order 
mode. So, we accept this contribution and wipe out {{CLOCK}} mode.

Even more, can we remove {{CacheAtomicWriteOrderMode}} enum from the public API 
at all? I see no reason why we should preserve for a single option available - 
{{PRIMARY}}. Asked the same in the related discussion on the dev list.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-24 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939972#comment-15939972
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

[~agura] Thanks for the explanation, on the weekend I'll learn 
{{ignite-yardstick}} module.
[~dmagda] ok :)

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-23 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939187#comment-15939187
 ] 

Denis Magda commented on IGNITE-4587:
-

Guys, in any case, after we see benchmarking results for 1.9 and 2.0 (both in 
PRIMARY synchronization mode) then the final decision will be done. If 2.0 
outperforms 1.9 in PRIMARY synchronization mode then there is no sense to 
preserve harmful CLOCK mode. Even more, we might need to remove 
{{CacheWriteSynchMode}} from the public API at all, since there is no need to 
have it for a single parameter.



> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-23 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938875#comment-15938875
 ] 

Andrey Gura commented on IGNITE-4587:
-

[~dreamx] You can find performance test in {{ignite-yardstick}} module. 

{{CLOCK}} mode behaves better in case of multiple clients perform operations 
like {{putAll}}.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-22 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936278#comment-15936278
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

[~agura] Are these your internal tests? 
Can you find out more in which cases is it {CLOCK} mode more preferable?

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-21 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935189#comment-15935189
 ] 

Andrey Gura commented on IGNITE-4587:
-

[~dreamx] Looks good for me. I've merged it with master and ran tests. If tests 
will ok I'll merge your changes.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-16 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928095#comment-15928095
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

[~agura] All is done.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-16 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928066#comment-15928066
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

18. ask on dev list
21. I checked again.
22. I not found U.sleep() calls.

Waiting for your response in the tests. :)


> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-16 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928086#comment-15928086
 ] 

Andrey Gura commented on IGNITE-4587:
-

Maksim, I'll answer later. What about other issues?

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-13 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907918#comment-15907918
 ] 

Andrey Gura commented on IGNITE-4587:
-

[~dreamx],

I've review your changes. See my comments below. Please, fix.

# Class {{GridCacheAtomicFullApiSelfTest}}: method {{cacheConfiguration()}} can 
be removed because it just returns result of base class method.
# Class {{GridCacheAtomicMultiNodeP2PDisabledFullApiSelfTest}}: method 
{{cacheConfiguration()}} can be removed because it just returns result of base 
class method.
# Class {{GridCacheReplicatedAtomicMultiNodeFullApiSelfTest}}: method 
{{cacheConfiguration()}} can be removed because it just returns result of base 
class method.
# Class {{GridCacheAtomicMessageCountSelfTest}}: methods 
{{testPartitionedPrimary()}} and {{testClientPrimary()}} should be renamed to 
{{testPartitioned()}} and {{testClient()}} respectively.
# Class {{GridCacheAtomicNearCacheSelfTest}}: method {{startGridsLocal()}} 
confuses. Why {{Local}}? May be {{doStartGrids}} or something like.
# Class {{GridCacheAtomicVersionComparator}}: {{ignoreTime}} parameter at 
{{compare}} method is unused and should be removed.
# Class {{GridCacheInterceptorAbstractSelfTest}}: unused import and methods.
# Class {{GridCacheMapEntry}}, method {{innerUpdate}}, lines 2172 and 2228: 
{{ignireTime}} variable is always {{true}}. Need remove usage.
# Class {{GridCacheMultithreadedFailoverAbstractTest}}, method 
{{configuration()}}, line 221: Nested if could be combined with embraced.
# Class {{GridCacheUtils}}: unused imports.
# Class {{GridCacheUtils}}: Bug. Please fix array size and offsets in 
{{versionToBytes()}} and {{readVersion()}} methods.
# Class {{IgniteUtils}}: Bug. Please fix offsets in {{writeVersion()}} and 
{{readVersion()}} methods.
# Class {{GridCacheVersion}}: Bug. Integers will be overflowed in 
{{asGridUuid()}} method. Please replace by {{new UUID(topVer, nodeOrderDrId)}}.
# Class {{GridCacheVersion}}: method {{fieldsCount()}} returns incorrect 
result. Use {{MessageCodeGenerator}} in order to generate correct code.
# Class {{GridCacheVersionEx}}: incorrect implementations of {{fieldsCount()}}, 
{{writeTo()}} and {{readFrom()}} methods. Use {{MessageCodeGenerator}} in order 
to generate correct code.
# Class {{GridCommonAbstractTest}}: unused imports.
# Class {{GridCommonAbstractTest}}: method {{atomicClockModeDelay()}} should be 
removed.
# Class {{GridDhtAtomicCache}}: I'm not sure about it. It seems that methos 
{{isFastMap()}} should not be removed. Could you please ask about it on dev 
list. Check also {{fastMap}} flag in {{GridNearAtomicUpdateFuture}} class.
# Class {{GridDhtAtomicCache}}: Redundant {{catch}} blocks in 
{{lockEntriesMethod()}}, lines 2899 and 2914.
# Class {{GridNearAtomicSingleUpdateFuture}}: Method {{mapSingleUpdate()}} 
creates different requests (like {{GridNearAtomicSingleUpdateInvokeRequest}}). 
For all this requests all instantiations have {{updateVer == null}}. Need to 
remove this prameter. The same for {{GridNearAtomicUpdateFuture}} class 
{{mapUpdate()}} and {{mapSingleUpdate()}} methods.
# Class {{IgniteBenchmarkArguments}}: Comand line arguments {{"-wom", 
"--writeOrderMode"}} were removed. Please, check that there are not this 
arguments usges in {{modules/yardstick}}.
# Class {{IgniteCacheExpiryPolicyAbstractTest}}: methods {{nearReaderUpdate()}} 
and {{nearPutAll()}}. It seems that all {{U.sleep()}} calls are redundant now.
# Class {{IgniteCachePutRetryAbstractSelfTest}}: unused import.

Also I see a lot of removed tests. I need additional time for analyzing it. 
Thanks!

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-12 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906659#comment-15906659
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

[~agura] yes, 
http://ci.ignite.apache.org/project.html?projectId=IgniteTests_IgniteTests=pull/1521/head
Ok, I removed everything.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-03-10 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905252#comment-15905252
 ] 

Andrey Gura commented on IGNITE-4587:
-

[~dreamx], did you run tests on TC? 

Also I see the following classes in 
{{org.apache.ignite.internal.processors.clock}} package:

- {{GridClockDeltaSnapshot}}
- {{GridClockDeltaSnapshotMessage}}
- {{GridClockDeltaVersion}}
- {{GridClockMessage}}
- {{GridClockServer}}
- {{GridClockSource}}
- {{GridJvmClockSource}}

I believe all this classes can be removed.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-02-23 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880836#comment-15880836
 ] 

Andrey Gura commented on IGNITE-4587:
-

Hi, [~dreamx]

I've reviewed your pull request. First of all, please merge the latest changes 
from master branch. 

See my comments bellow:

# {{CacheAtomicWriteOrderMode}} enum contains now only one value {{PRIMARY}}. 
Given the fact that this enum makes sense only for atomic cache I would prefer 
to remove this enum. But better way is to discuss this on dev list. If there 
are no any objectives then we can just remove this enum and all methods' 
parameters of this type.
# {{GridDhtAtomicCache}} class {{isFastMap}} method always returns {{false}} 
now. So this method is also candidate for removal. 
# {{GridNearAtomicSingleUpdateFuture}} class {{mapSingleUpdate}} method. 
Parameter {{updVer}} is always {{null}} now. Please remove this parameter. Also 
please make sure that this parameter make sense for requests that will be 
created in this method. It seems that 
{{GridNearAtomicSingleUpdateFuture.updVer}} doesn't make sense also.
# {{GridNearAtomicUpdateFuture}} class. The same issue as for previous item but 
for {{mapSingleUpdate}} and {{mapUpdate}} methods and {{updVer}} parameter.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-02-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863413#comment-15863413
 ] 

ASF GitHub Bot commented on IGNITE-4587:


GitHub user dream-x opened a pull request:

https://github.com/apache/ignite/pull/1521

IGNITE-4587: Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

[Jira ticket](https://issues.apache.org/jira/browse/IGNITE-4587). 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dream-x/ignite ignite-4587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1521


commit f0dcbbdecd10ee9afee3cb0c5a96bb1540d0c06a
Author: Max Kozlov 
Date:   2017-02-13T09:20:51Z

Delete CLOCK mode in CacheAtomicWriteOrderMode.

commit a37ff76168613007d3ca09c06688bc6456e4c330
Author: Max Kozlov 
Date:   2017-02-13T09:27:28Z

Delete use CLOCK for ignite-core.

commit 25d4ea5003773b739baba2c2d5c3e7be2194ba7a
Author: Max Kozlov 
Date:   2017-02-13T09:43:59Z

Fix tests CLOCK change to PRIMARY and delete same test.




> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
>Assignee: Maksim Kozlov
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-02-10 Thread Denis Magda (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862068#comment-15862068
 ] 

Denis Magda commented on IGNITE-4587:
-

[~dreamx], I would change the write mode from {{CLOCK}} to {{PRIMARY}} for the 
tests like that.

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Denis Magda
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

2017-02-10 Thread Maksim Kozlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861200#comment-15861200
 ] 

Maksim Kozlov commented on IGNITE-4587:
---

[~dmagda], how to deal with the tests where it is verified to work with 
{{CacheAtomicWriteOrderMode.CLOCK}} (i.e. 
{{GridCacheInterceptorLocalAtomicSelfTest}}, 
{{GridCacheAtomicOffHeapMultiNodeFullApiSelfTest}} and other)?

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> ---
>
> Key: IGNITE-4587
> URL: https://issues.apache.org/jira/browse/IGNITE-4587
> Project: Ignite
>  Issue Type: Bug
>Reporter: Denis Magda
> Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to 
> timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be 
> updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)