[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885484#comment-15885484
 ] 

ASF GitHub Bot commented on IGNITE-4735:


Github user isapego closed the pull request at:

https://github.com/apache/ignite/pull/1562


> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878179#comment-15878179
 ] 

Igor Sapego commented on IGNITE-4735:
-

[~avinogradov] Yeah, I've checked that with a diff tool.

> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877896#comment-15877896
 ] 

Vladimir Ozerov commented on IGNITE-4735:
-

[~isapego],
{{interop_target.h}} appeared, but there are no {{targetver.h}} still. However, 
I dot not see them in 1.8 release either. Do we really need them?

> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877836#comment-15877836
 ] 

Anton Vinogradov commented on IGNITE-4735:
--

Igor, 
please do "vote preparation" for same sources with both regexps (old and new) 
and make sure that sources.zip contains same files set.
 

> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877816#comment-15877816
 ] 

Vladimir Ozerov commented on IGNITE-4735:
-

LGTM

> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4735) Some CPP files are missing from source releases.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875918#comment-15875918
 ] 

ASF GitHub Bot commented on IGNITE-4735:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/1562

IGNITE-4735: Excluded CPP sources.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-4735

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1562


commit 1c3e602032df72c844e44cc1eb6224b54d9e8712
Author: Igor Sapego 
Date:   2017-02-21T12:44:30Z

IGNITE-4735: Excluded CPP sources.




> Some CPP files are missing from source releases.
> 
>
> Key: IGNITE-4735
> URL: https://issues.apache.org/jira/browse/IGNITE-4735
> Project: Ignite
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.8
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: cpp
> Fix For: 1.9
>
>
> Some CPP files missing from the sources release. For example:
> - modules/platforms/cpp/common/project/vs/targetver.h
> - modules/platforms/cpp/jni/project/vs/targetver.h
> - modules/platforms/cpp/core/include/ignite/impl/interop/interop_target.h
> It seems that there is issue with files which has "target" in name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)