[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457517#comment-16457517
]
ASF GitHub Bot commented on IGNITE-4756:
Github user daradurvs closed the pull request at:
https://github.com/apache/ignite/pull/3679
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.6
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443704#comment-16443704
]
ASF GitHub Bot commented on IGNITE-4756:
Github user daradurvs closed the pull request at:
https://github.com/apache/ignite/pull/3867
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.6
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443623#comment-16443623
]
Vyacheslav Daradur commented on IGNITE-4756:
Hi, [~ilyak], thank you for paying attention.
I've filed a ticket IGNITE-8315, it will be fixed soon.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.6
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442633#comment-16442633
]
Ilya Kasnacheev commented on IGNITE-4756:
-
[~tledkov-gridgain] Client nodes now routinely print:
2018-04-18T14:06:42,963][exchange-worker-#57][GridAffinityAssignmentCache]
Local node affinity assignment distribution is not ideal [cache=data2,
expectedPrimary=256.00, actualPrimary=0, expectedBackups=256.00,
actualBackups=0, warningThreshold=50.00%]
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.6
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432137#comment-16432137
]
Anton Vinogradov commented on IGNITE-4756:
--
[~daradurvs],
Looks good to me.
Lets replace threshold with 50% and I'll merge the changes.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.5
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430768#comment-16430768
]
Dmitriy Pavlov commented on IGNITE-4756:
TC looks good. [~avinogradov], could you please finalize review?
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.5
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417678#comment-16417678
]
Vyacheslav Daradur commented on IGNITE-4756:
Here is the latest ci.build:
https://ci.ignite.apache.org/viewLog.html?buildId=1163400
Looks good.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vyacheslav Daradur
>Priority: Minor
> Labels: newbie
> Fix For: 2.5
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158734#comment-16158734
]
Taras Ledkov commented on IGNITE-4756:
--
The patch is OK with me.
[~yzhdanov], please take a look.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158672#comment-16158672
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain], all minor cosmetic changes done.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158415#comment-16158415
]
Taras Ledkov commented on IGNITE-4756:
--
[~javaller], looks good. Please do the minor cosmetic changes:
# {{GridAffinityAssignmentCache}} fix import order.
# {{GridAffinityAssignmentCache#printDistribution}} please use {{partsCnt}}
instead of the {{assignment.size()}} to calculate {{expectedCnt}}
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152690#comment-16152690
]
Anton Vinogradov commented on IGNITE-4756:
--
[~tledkov-gridgain],
Please review.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152677#comment-16152677
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov] In my opinion tests look good. [TC
#2557|https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll_Ignite20Tests=pull%2F2557%2Fhead=buildTypeStatusDiv]
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123379#comment-16123379
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov]] Review please -
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-277
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087117#comment-16087117
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov] Added print cache / group name in log
message. Removing calculating statistics to method calculate in progress.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085540#comment-16085540
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov] Added local node filtering in calculating
statistics.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083691#comment-16083691
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov] Log4JLogger dependency removed from core
module. Log have been initialize early. I'm working on printing cache group
name in log and calculating statistics only for loacal node. What the next step?
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=4(100%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082134#comment-16082134
]
Vadim Opolski commented on IGNITE-4756:
---
Removing Log4JLogger in progress.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=4(100%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078171#comment-16078171
]
Taras Ledkov commented on IGNITE-4756:
--
[~javaller], my comments:
# You mustn't initialize {log} member at the
{{RendezvousAffinityFunctionSimpleBenchmark#beforeTestsStarted}}. It have been
initialized early.
# Then Log4JLogger dependency is not needed. Please remove it from the {{core}}
module.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Message format is
> {noformat}
> Affinity assignment distribution not even [cache=,
> even=, distribution=[,
> ..., ]].
> e.g.:
> Affinity assignment distribution not even [cache=test, even=100 (10%),
> distribution=[100 (10%), 150 (15%), 500 (50%)]].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078154#comment-16078154
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] [~avinogradov]
Removed initialization from constructor -
https://github.com/vadopolski/ignite/pull/3/files. Trying to use
IgniteMockWithLocalNode.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074861#comment-16074861
]
Taras Ledkov commented on IGNITE-4756:
--
[~javaller] my comments:
# Ignite logger must not be created in constructor of AF. It is injected by
Ignite on affinity function initialization (see more about @LoggerResource and
@IgniteInstanceResource annotations);
# Statistic must be calculated only for local node (only for one node). The
part of calculation (increment of count) can be placed inside the method
{{assignPartition}}; Local node ID can be gathered from ignite instance (see
@IgniteInstanceResource annotations);
# The statistic structure for one node will be simplified to integer array
({{int[] stat}}) that contains counts of partitions (primary, back1, backup2,
etc);
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074732#comment-16074732
]
Vadim Opolski commented on IGNITE-4756:
---
[~tledkov-gridgain] Is written log suitable for this issue ?
https://github.com/vadopolski/ignite/pull/3/files
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049263#comment-16049263
]
Taras Ledkov commented on IGNITE-4756:
--
If I catch your question right:
# You patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049233#comment-16049233
]
Vadim Opolski commented on IGNITE-4756:
---
[~yzhdanov] , [~tledkov-gridgain] I cant find information about where to create
log message in correct format. Help please.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887692#comment-15887692
]
Yakov Zhdanov commented on IGNITE-4756:
---
[~tledkov-gridgain], I think this should be enabled by default. To make it
faster we need to combine this calculation for caches with same topology and
same affinity, and probably output deviation information only for local node.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Priority: Minor
> Labels: newbie
> Fix For: 2.0
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885760#comment-15885760
]
Taras Ledkov commented on IGNITE-4756:
--
[~yzhdanov], If we are going to print only nodes that differ on +/-10% from
average partitions count we can print problem message looks like:
{noformat}
[cacheName=NAME, nodes=[nodeId= Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Priority: Minor
> Labels: newbie
> Fix For: 2.0
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885713#comment-15885713
]
Yakov Zhdanov commented on IGNITE-4756:
---
I think this way log will become too verbose.
[~tledkov-gridgain], can you please think over and suggest another format -
Ignite outputs only warning for caches and nodes where distribution is not
even. I would also allow to set threshold via system property
(-DIGNITE_PART_DISTRIBUTION_WARN_THRESHOLD=0.1 - warn about nodes with 10+%
difference).
We can output the messages on each topology change
OK Message
{{Partition map has been built (distribution is even).}}
Problem message
{{Partition map has been built (distribution is not even for caches)
[cacheName=NAME, nodes=[, ,
]}}
[~tledkov-gridgain], can you please suggest message format also containing info
on backups distribution. Can you please think it over?
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Priority: Minor
> Labels: newbie
> Fix For: 2.0
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
