[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087193#comment-16087193
]
ASF GitHub Bot commented on IGNITE-4831:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/2265
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>Assignee: Andrew Mashenkov
> Fix For: 2.2
>
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078297#comment-16078297
]
ASF GitHub Bot commented on IGNITE-4831:
GitHub user AMashenkov opened a pull request:
https://github.com/apache/ignite/pull/2265
IGNITE-4831: Option to disable MBeans.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-4831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2265
commit cfc3d0f1ea61eabc75bb4d13699958495edfdfd2
Author: Andrey V. Mashenkov
Date: 2017-07-04T15:21:10Z
WIP.
commit a93c5fb8b6841c6f9cc5196b5cc6dd20390cb18b
Author: Andrey V. Mashenkov
Date: 2017-07-04T15:21:10Z
WIP.
commit 18c5d5ead54cb5ca1db0cdd20cc64f85e58403b1
Author: Andrey V. Mashenkov
Date: 2017-07-04T17:24:52Z
WIP.
commit 552c32e5387c94a403228931d5625ce1a53d871d
Author: Andrey V. Mashenkov
Date: 2017-07-07T16:01:22Z
Tests added
commit 731dcdfef81fc1f24ad98cf9ee98475df920d820
Author: Andrey V. Mashenkov
Date: 2017-07-07T16:03:22Z
Tests added
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>Assignee: Andrew Mashenkov
> Fix For: 2.2
>
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017513#comment-16017513
]
Valentin Kulichenko commented on IGNITE-4831:
-
My comments on the PR:
* What is the purpose of {{mbeans-disallowed.policy}} file?
* Why the catch block for {{JMException}} is changed multiple times like below?
This seems to be a redundant change.
{code}
catch (JMException e) {
if (! (e instanceof InstanceNotFoundException &&
IgniteUtils.IGNITE_DISABLE_MBEANS))
U.error(log, "Failed to unregister MBean for memory metrics: " +
memPlc.memoryMetrics().getName(), e);
}
{code}
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012543#comment-16012543
]
ASF GitHub Bot commented on IGNITE-4831:
GitHub user rfqu opened a pull request:
https://github.com/apache/ignite/pull/1959
IGNITE-4831 fixed (Add an option to disable MBeans).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rfqu/ignite ignite-4831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1959
commit d4fe48d417548739b60a4ccbd5c24fb3e85f6346
Author: rfqu
Date: 2017-05-16T14:48:37Z
IGNITE-4831 fixed (Add an option to disable MBeans).
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012044#comment-16012044
]
ASF GitHub Bot commented on IGNITE-4831:
Github user rfqu closed the pull request at:
https://github.com/apache/ignite/pull/1945
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010812#comment-16010812
]
ASF GitHub Bot commented on IGNITE-4831:
GitHub user rfqu opened a pull request:
https://github.com/apache/ignite/pull/1945
IGNITE-4831 fixed (Add an option to disable MBeans). Option IGNITE_DI…
…SABLE_MBEANS added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rfqu/ignite ignite-4831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1945
commit 8123b84a9b7d5322455dc67187b2d2f6673f61ab
Author: rfqu
Date: 2017-05-15T16:19:32Z
IGNITE-4831 fixed (Add an option to disable MBeans). Option
IGNITE_DISABLE_MBEANS added.
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010809#comment-16010809
]
ASF GitHub Bot commented on IGNITE-4831:
Github user rfqu closed the pull request at:
https://github.com/apache/ignite/pull/1944
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010788#comment-16010788
]
ASF GitHub Bot commented on IGNITE-4831:
GitHub user rfqu opened a pull request:
https://github.com/apache/ignite/pull/1944
IGNITE-4831 fixed (Add an option to disable MBeans). Option IGNITE_DI…
…SABLE_MBEANS added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rfqu/ignite ignite-4831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1944
commit 8123b84a9b7d5322455dc67187b2d2f6673f61ab
Author: rfqu
Date: 2017-05-15T16:19:32Z
IGNITE-4831 fixed (Add an option to disable MBeans). Option
IGNITE_DISABLE_MBEANS added.
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4831) Add an option to disable MBeans
[
https://issues.apache.org/jira/browse/IGNITE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007988#comment-16007988
]
Andrew Mashenkov commented on IGNITE-4831:
--
I've found we support MBean registration for various plugged components, e.g.
SPI implementations.
But there is no list of such components and their interfaces javadoc doesn't
contains such info as well.
It would be nice to fix javadoc within this ticket.
> Add an option to disable MBeans
> ---
>
> Key: IGNITE-4831
> URL: https://issues.apache.org/jira/browse/IGNITE-4831
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.8
>Reporter: Valentin Kulichenko
>
> There are multiple MBeans registered by Ignite and there is no way to avoid
> their registration (in case they're not allowed for security reasons for
> example). We should have a system property that will disable MBeans.
> In addition, if MBean registration throws a {{RuntimeException}}, this
> exception is not properly handled. For example, if it happens during cache
> creation, {{createCache}} method hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
