[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496297#comment-16496297
 ] 

Pavel Konstantinov commented on IGNITE-5011:


Re-tested on the master

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Pavel Konstantinov
>Priority: Trivial
> Fix For: 2.6
>
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493705#comment-16493705
 ] 

ASF GitHub Bot commented on IGNITE-5011:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1917


> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Pavel Konstantinov
>Priority: Trivial
> Fix For: 2.6
>
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480567#comment-16480567
 ] 

Dmitriy Pavlov commented on IGNITE-5011:


Was PR 1917 merged? 

I don't see comment from committer about merge.

If PR is not merged, Resolved status is not best option.

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Alexey Kuznetsov
>Priority: Trivial
> Fix For: 2.6
>
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480115#comment-16480115
 ] 

Pavel Konstantinov commented on IGNITE-5011:


'-t' option validation looks good.

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Pavel Konstantinov
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Vasiliy Sisko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478457#comment-16478457
 ] 

Vasiliy Sisko commented on IGNITE-5011:
---

Looks good. [~pkonstantinov] Please test with empty and invalid arguments. 
Check validation of other arguments.

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467251#comment-16467251
 ] 

Dmitriy Pavlov commented on IGNITE-5011:


[~kuaw26] could you please review this ticket? I'm not so strong in scala.

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449212#comment-16449212
 ] 

ASF GitHub Bot commented on IGNITE-5011:


GitHub user vinx13 reopened a pull request:

https://github.com/apache/ignite/pull/1917

IGNITE-5011: Add validation on args and show proper warnings on disco 
command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vinx13/ignite ignite-5011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1917


commit a3230f6f92622a2cadbc0a1e3c0748685a2c4aed
Author: Wuwei Lin 
Date:   2017-05-06T10:37:32Z

IGNITE-5011: Add validation on args and show proper warnings




> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448526#comment-16448526
 ] 

Dmitriy Pavlov commented on IGNITE-5011:


Hi [~vinx13], I can see PR is closed, but ticket is in PA state. 

Could you please set status of ticket to open or to in progress?

Alternatively could you please provide PR and TC RunAll to review and check?

> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361080#comment-16361080
 ] 

ASF GitHub Bot commented on IGNITE-5011:


Github user vinx13 closed the pull request at:

https://github.com/apache/ignite/pull/1917


> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5011) Add validation of input params of disco command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999385#comment-15999385
 ] 

ASF GitHub Bot commented on IGNITE-5011:


GitHub user vinx13 opened a pull request:

https://github.com/apache/ignite/pull/1917

IGNITE-5011: Add validation on args and show proper warnings on disco 
command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vinx13/ignite ignite-5011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1917


commit a3230f6f92622a2cadbc0a1e3c0748685a2c4aed
Author: Wuwei Lin 
Date:   2017-05-06T10:37:32Z

IGNITE-5011: Add validation on args and show proper warnings




> Add validation of input params of disco command
> ---
>
> Key: IGNITE-5011
> URL: https://issues.apache.org/jira/browse/IGNITE-5011
> Project: Ignite
>  Issue Type: Bug
>Reporter: Pavel Konstantinov
>Assignee: Wuwei Lin
>Priority: Trivial
>
> {code}
> visor> disco -t=0h
> java.lang.IllegalArgumentException: Time frame size is not positive in: 0h
> at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282)
> at 
> org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329)
> at 
> org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318)
> at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
> at 
> scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.App$$anonfun$main$1.apply(App.scala:76)
> at scala.collection.immutable.List.foreach(List.scala:381)
> at 
> scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35)
> at scala.App$class.main(App.scala:76)
> at 
> org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318)
> at 
> org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala)
> (wrn) : Invalid command name: 'disco -t=0h'
> (wrn) : Type 'help' to print commands list.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)