[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-08-29 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596236#comment-16596236
 ] 

ASF GitHub Bot commented on IGNITE-5136:


Github user SomeFire closed the pull request at:

https://github.com/apache/ignite/pull/3236


> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.7
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-05-23 Thread Ryabov Dmitrii (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486899#comment-16486899
 ] 

Ryabov Dmitrii commented on IGNITE-5136:


[~avinogradov], new implementation is ready, tests are ok.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.6
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-05-15 Thread Ryabov Dmitrii (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475769#comment-16475769
 ] 

Ryabov Dmitrii commented on IGNITE-5136:


Agree, this way will be simpler than current implementation. I'll make chenges.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.6
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-05-15 Thread Anton Vinogradov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475763#comment-16475763
 ] 

Anton Vinogradov commented on IGNITE-5136:
--

[~SomeFire]

Since we're fixing memory leak I propose to use \{{ConcurrentLinkedHashMap}} 
with maxCap ~ 100. 

This will allow us to keep 100 actual uniquie errors, this should be enough.

100 should not be hardcoded. 

 

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.6
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-05-15 Thread Nikolay Izhikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475659#comment-16475659
 ] 

Nikolay Izhikov commented on IGNITE-5136:
-

[~SomeFire] I left some comments in upsource. Please, fix it.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.6
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-05-08 Thread Ivan Fedotov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467381#comment-16467381
 ] 

Ivan Fedotov commented on IGNITE-5136:
--

[~SomeFire], looks good to me.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
>Priority: Major
> Fix For: 2.6
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2018-01-09 Thread Ryabov Dmitrii (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318274#comment-16318274
 ] 

Ryabov Dmitrii commented on IGNITE-5136:


[~zstan], it impossible to register any task that way because 
{{GridTimeoutProcessor}} and other exists only inside a node, but 
GridLogThrottle is static class and can be used without any {{Ignite}} instance.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
> Fix For: 2.4
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-12-29 Thread Ryabov Dmitrii (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306237#comment-16306237
 ] 

Ryabov Dmitrii commented on IGNITE-5136:


Ok, I'll change it.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
> Fix For: 2.4
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-12-29 Thread Stanilovsky Evgeny (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306231#comment-16306231
 ] 

Stanilovsky Evgeny commented on IGNITE-5136:


[~dvryaboy] thanks, but i mean that you just need to register clear task, like:
{code:java}
GridTimeoutProcessor,  ctx.timeout()
{code}


> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
> Fix For: 2.4
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-12-19 Thread Ryabov Dmitrii (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296542#comment-16296542
 ] 

Ryabov Dmitrii commented on IGNITE-5136:


[~zstan], I've done with your comment, can you review again?

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
> Fix For: 2.4
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-12-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292333#comment-16292333
 ] 

ASF GitHub Bot commented on IGNITE-5136:


GitHub user SomeFire opened a pull request:

https://github.com/apache/ignite/pull/3236

IGNITE-5136: GridLogThrottle memory leak



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SomeFire/ignite ignite-5136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3236


commit 63bfe6a8681ea7a9f40de9d17f44df0c66c678ec
Author: vadopolski 
Date:   2017-09-05T17:29:58Z

Added test and cleanUpOldEntries

commit 30b132e7e2a62ae1d0605db1cdd107eb9ca1ec37
Author: vadopolski 
Date:   2017-09-05T18:19:27Z

Added check of timeStamp in map.

commit 09d0fed6fdc8ca910a5e1b67bbe4d3c1911a37d3
Author: vadopolski 
Date:   2017-09-05T19:28:59Z

Added testOnChangingTimeout

commit a13a6e78e9ecf1507cf2e82a0859fa10bf02babc
Author: vadopolski 
Date:   2017-09-06T14:12:04Z

Added lazy initialization.

commit eb75fe7d7219b3d1f9a2ba64d4a6fd532aee742d
Author: vadopolski 
Date:   2017-09-06T14:19:34Z

Added throttleTimeout.

commit 795593570e78623fea8c0d16f7c19423d6b83654
Author: vadopolski 
Date:   2017-09-06T14:23:42Z

Changed sleep timeout.

commit 18b8c75df9673d7c1223d66f74da68d436a45eee
Author: vadopolski 
Date:   2017-09-06T15:07:41Z

Added removing from errors with iterator.

commit 184f092b3bc0fd604480ae2cbd16f0fa8a7fed6e
Author: vadopolski 
Date:   2017-09-06T15:41:39Z

Code style.n

commit 881b78fd69ad1939bb580c49880623eb3ed74cca
Author: vadopolski 
Date:   2017-09-07T13:40:07Z

Improved iterator.

commit 90e9665f6371abbc3180c55ab75c714a38c1ed22
Author: vadopolski 
Date:   2017-09-07T16:24:34Z

Changed sleep timeout.

commit 6d2e0158bb5c0d8fc0c602cd0a8c874f0ed685e7
Author: vadopolski 
Date:   2017-09-07T16:37:13Z

Refactoring.

commit 9bfa9c3b60b53b1f444a6721f01dd84dc1f028f4
Author: vadopolski 
Date:   2017-09-07T16:47:31Z

Refactoring.

commit 0769ce86fdf5d73658548f31af21f9782d210f70
Author: vadopolski 
Date:   2017-09-07T16:50:36Z

Deleted loggedTs.

commit df05944a66448b4fcd3f635f8e348827096b5f15
Author: vadopolski 
Date:   2017-09-11T16:24:33Z

Review fixes

commit ec037cab659107d3f9959fe1b2540028f95d9345
Author: vadopolski 
Date:   2017-09-13T13:24:31Z

Added synchronized.

commit ec7d65527199039f84fcd4f0aa30cb1758c0e2e9
Author: vadopolski 
Date:   2017-09-13T17:46:39Z

Added cancel to synchronized area.

commit 2f8ba6b1864e479e934033fa7c49b44e1e57156e
Author: vadopolski 
Date:   2017-09-15T10:28:14Z

Added cancel to synchronized.

commit fabbc8bc22237f63e6a93851bdbbec7ee8bf5ec2
Author: vadopolski 
Date:   2017-09-15T13:31:46Z

Added cleanUpCancelEnabled to mapCleaningPeriodSetup.

commit ac850a5f6bf0cf44ea3afcd895a9ec95398834ca
Author: vadopolski 
Date:   2017-09-15T13:36:51Z

Refactoring.

commit 45c0eb6159bd51b23ed35ae7f49b6502c8c96ba8
Author: vadopolski 
Date:   2017-09-15T13:46:12Z

Overwritten mapCleaningPeriodSetup.

commit b2ec2a25de6fe484ac3dcfcd2b90256f2cf416bd
Author: vadopolski 
Date:   2017-09-15T14:11:31Z

Refactoring.

commit 3e11d19e1e39c3b476df65292640b83342455d19
Author: Dmitrii Ryabov 
Date:   2017-12-14T12:56:44Z

Merge branch 'master' into ignite-5136

commit c0be8de7de492122e35be641a9a0f06a1d4f937f
Author: Dmitrii Ryabov 
Date:   2017-12-14T15:33:44Z

IGNITE-5136: review fix.




> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Ryabov Dmitrii
> Fix For: 2.4
>
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-09-18 Thread Stanilovsky Evgeny (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169707#comment-16169707
 ] 

Stanilovsky Evgeny commented on IGNITE-5136:


No need to use separate ThreadPool, using java.util.Timer would be enough.

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Vadim Opolski
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5136) GridLogThrottle memory leak

2017-09-17 Thread Vadim Opolski (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169413#comment-16169413
 ] 

Vadim Opolski commented on IGNITE-5136:
---

[~zstan] [~avinogradov] In my opinion tests look good.
[TC Overview | 
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll&branch_Ignite20Tests=pull%2F2674%2Fmerge&tab=buildTypeStatusDiv]

> GridLogThrottle memory leak
> ---
>
> Key: IGNITE-5136
> URL: https://issues.apache.org/jira/browse/IGNITE-5136
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Reporter: Stanilovsky Evgeny
>Assignee: Vadim Opolski
>
> class GridLogThrottle stores throttle info into map and noone clears it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)