[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087199#comment-16087199
 ] 

Vyacheslav Daradur commented on IGNITE-5153:


Sent to [ci.tests|http://ci.ignite.apache.org/viewQueued.html?itemId=726606].

> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.2
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087000#comment-16087000
 ] 

ASF GitHub Bot commented on IGNITE-5153:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/2300

IGNITE-5153 CPP: Introduced "varint" encoding in C++



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5153

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2300


commit 1e1e8432dc936df7c62557575a57c4a159b4bca6
Author: Vyacheslav Daradur 
Date:   2017-05-31T08:41:56Z

ignite-5097: writing arrays length in varint encoding was implemented

commit d162d3e3d9036cddb275b4a3d86b8f5de9795185
Author: daradurvs 
Date:   2017-06-01T18:35:13Z

ignite-5097: doUnsafeWriteUnsignedVarint method was added

commit bfe381b3a7498eb5bebeb25026a43d36656c6041
Author: daradurvs 
Date:   2017-06-04T21:25:48Z

ignite-5097: dotNET - writing arrays length in varint encoding was 
implemented

commit 516fcf41e4e973abf41cdd19acd2c9ea1bfb9445
Author: daradurvs 
Date:   2017-06-04T21:26:00Z

ignite-5097: dotNET - hardcoded hashcode values in the tests were changed 
according to new conditions

commit fb43cbd77e9c83ef1aeb9dced923d9ca094a8be3
Author: Vyacheslav Daradur 
Date:   2017-07-05T20:25:27Z

Merge branch 'master' into ignite-5097_2

commit 398cb205c26c65f369dc3bdc4198f6032a206e87
Author: daradurvs 
Date:   2017-07-06T18:12:09Z

ignite-5097: compatibility property to allow to keep data in old format was 
added in Java part

commit 4105cf073e0e23f44c0c271407ce5415f867a352
Author: daradurvs 
Date:   2017-07-06T18:12:55Z

ignite-5097: dotNET - compatibility property to allow to keep data in old 
format was added

commit 86082a8052ce2e5c818183a18d16eddf54d5e346
Author: Vyacheslav Daradur 
Date:   2017-07-07T14:15:14Z

ignite-5097: compatibility mode test was added

commit 6aadaa985d021d38accedeaa3ada6790eb1981a9
Author: daradurvs 
Date:   2017-07-07T17:46:56Z

ignite-5097: dotNET - compatibility mode tests were added; fix constant 
condition

commit bd24ccf6e8c2b4deb85cd3ad48635be9addaecd3
Author: Vyacheslav Daradur 
Date:   2017-07-10T15:22:01Z

ignite-5097: dotNET - fix compatibility property condition

commit 5f3e1543c8de140a533d0fbdbfca74a2ffd89a36
Author: Vyacheslav Daradur 
Date:   2017-07-10T15:32:44Z

ignite-5097: rename constant of compatibility mode

commit ac59755342093609c2c9505ccde3308ebf1f1ed4
Author: daradurvs 
Date:   2017-07-10T17:42:00Z

ignite-5097: dotNET - fix compatibility mode test

commit 36e7ce2fb39f8426f2438b0b81823309e6434151
Author: Igor Sapego 
Date:   2017-05-04T13:11:11Z

IGNITE-5153: Implemented varint writing and reading

commit 720c9a273102604b371e24cecb807a4b6637
Author: Igor Sapego 
Date:   2017-05-04T15:26:27Z

IGNITE-5153: Added tests

commit 14416c538765990e6c5853b552e4167ccc8b7573
Author: Igor Sapego 
Date:   2017-05-05T12:44:56Z

IGNITE-5153: Refactored Decimal writing reading

commit d5534fde463594df007e5161d2bdd6546bb762d6
Author: Igor Sapego 
Date:   2017-05-05T13:41:03Z

IGNITE-5153: Refactored strings marshalling

commit 3cf8ebf9f978479682329fc18eef6d782ca703a5
Author: Igor Sapego 
Date:   2017-05-05T14:40:58Z

IGNITE-5153: Refactored tests and added tests for Decimal

commit 6c587ad0c4f5370f6c3635065f3d348f855cbb66
Author: Igor Sapego 
Date:   2017-05-05T17:57:06Z

IGNITE-5153: Fixed marshaling of Decimals

commit ffb5a2b9ec1486573c5ed4c50d53a15fb4a48062
Author: Igor Sapego 
Date:   2017-05-10T16:10:29Z

IGNITE-5153: Added tests for string

commit 4c57f878d06541d397381d79294fded5410317fc
Author: Igor Sapego 
Date:   2017-05-10T17:44:02Z

IGNITE-5153: Implemented for Decimals

commit a43aeba23260ff348147b93ce103982be4c8e6ad
Author: Igor Sapego 
Date:   2017-05-10T17:57:19Z

IGNITE-5153: Implemented for strings

commit 1f8ca2ae39dba23d53ef15cdc78bbcda8cc82c11
Author: Igor Sapego 
Date:   2017-05-10T18:58:07Z

IGNITE-5153: Refactored BinaryReaderImpl

commit 57b43296d65d8dfc8a9d9ab1a19e80f865bac9cd
Author: Igor Sapego 
Date:   2017-05-10T19:14:12Z

IGNITE-5153: Implemented 

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086988#comment-16086988
 ] 

Vyacheslav Daradur commented on IGNITE-5153:


[~isapego], I don't see your updates. The latest commit was 11 days ago. Do you 
push changes?

> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.2
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083816#comment-16083816
 ] 

Vyacheslav Daradur commented on IGNITE-5153:


[~isapego],
There are some changes in the [PR|https://github.com/apache/ignite/pull/2043].
I've added the changes to provide compatibility property to allow to keep data 
in old format (as it had been told by [~avinogradov])

It is managed by system-environment property: {{GNITE_NO_VARINT_ARRAY_LENGTH}}
When set to {{true}}, Ignite switches to compatibility mode with versions that 
writing length of arrays in default format.
Default is {{false}}, which means that length of arrays will be written in 
varint encoding.
Please, see details in the [PR|https://github.com/apache/ignite/pull/2043].

Could you implement this changes?
Thanks in advance.

> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.2
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072779#comment-16072779
 ] 

ASF GitHub Bot commented on IGNITE-5153:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/2228

IGNITE-5153 CPP: Introduced "varint" encoding in C++



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5153_2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2228


commit 1e1e8432dc936df7c62557575a57c4a159b4bca6
Author: Vyacheslav Daradur 
Date:   2017-05-31T08:41:56Z

ignite-5097: writing arrays length in varint encoding was implemented

commit d162d3e3d9036cddb275b4a3d86b8f5de9795185
Author: daradurvs 
Date:   2017-06-01T18:35:13Z

ignite-5097: doUnsafeWriteUnsignedVarint method was added

commit bfe381b3a7498eb5bebeb25026a43d36656c6041
Author: daradurvs 
Date:   2017-06-04T21:25:48Z

ignite-5097: dotNET - writing arrays length in varint encoding was 
implemented

commit 516fcf41e4e973abf41cdd19acd2c9ea1bfb9445
Author: daradurvs 
Date:   2017-06-04T21:26:00Z

ignite-5097: dotNET - hardcoded hashcode values in the tests were changed 
according to new conditions

commit 51fd311c5775fb7c5801c9588cafbcd842be2a4f
Author: Igor Sapego 
Date:   2017-05-31T14:58:03Z

IGNITE-5153: Initial commit

commit a6dbd043de5d2aa08195ff67cad768fa3337e05e
Author: Igor Sapego 
Date:   2017-05-31T15:32:43Z

IGNITE-5153: Fix for Decimals

commit 302d68d4b8313a9f0e593d711ac22d3ab1534cf8
Author: Igor Sapego 
Date:   2017-07-03T17:53:58Z

IGNITE-5153: Fix for the test configuration




> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.1
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010571#comment-16010571
 ] 

Igor Sapego commented on IGNITE-5153:
-

There is an issue with implementation for Collections, Maps and Arrays of 
objects - in C++ length of these types implemented in 3 steps:
1. Open writing session;
2. Write objects one by one;
3. Close session.

As you can see, the length of the of these types is unknown upon session 
opening. Previously we were just reserving 4 bytes for length and were writing 
it on session closing. Now we can't know how much bytes to reserve, as the 
length field is now of a variable length.

> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.1
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5153) CPP: BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Igor Sapego (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005245#comment-16005245
 ] 

Igor Sapego commented on IGNITE-5153:
-

Implemented for Decimals, Strings and Arrays. Added tests. Implementation for 
Collections is in progress.

> CPP: BinaryMarshaller should write ints in "varint" encoding where it makes 
> sense
> -
>
> Key: IGNITE-5153
> URL: https://issues.apache.org/jira/browse/IGNITE-5153
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vyacheslav Daradur
>Assignee: Igor Sapego
> Fix For: 2.1
>
>
> Need to implement IGNITE-5097



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)