[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034538#comment-16034538 ] ASF GitHub Bot commented on IGNITE-5176: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2040 > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033057#comment-16033057 ] Taras Ledkov commented on IGNITE-5176: -- Waiting for [Tests|http://195.239.208.174/project.html?projectId=Ignite20Tests&tab=projectOverview&branch_Ignite20Tests=pull%2F2040%2Fhead] > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033037#comment-16033037 ] Vladimir Ozerov commented on IGNITE-5176: - [~tledkov-gridgain], LGTM. Let;s make sure that tests are OK. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032893#comment-16032893 ] Taras Ledkov commented on IGNITE-5176: -- All comments are fixed. *8, 9* - will throw {{SQLFeatureNotSupportedException}} because Ignite doesn't support SQL structured types. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031994#comment-16031994 ] Vladimir Ozerov commented on IGNITE-5176: - [~tledkov-gridgain], my comments: 1) {{JdbcUtils.isReadSqlObject}} - please remove this, no thread locals. 2) {{JdbcThinResultSet.isBeforeFirst}} - requirement "or the result set contains no rows" is not satisfied 3) {{JdbcThinResultSet.getString}} - instead of checking for String over and over again in {{getTypedValue}}, it is better to check it only in {{getString}} method. 4) {{JdbcThinResultSet.getBoolean}} - incorrect implementation, see JavaDocs 5) {{JdbcThinResultSet.findColumn}} - linear search to find the string? Please use HashMap. Be careful with " If a select list contains the same column more than once, the *first* instance of the column will be returned." 6) {{JdbcThinResultSet.cancelRowUpdates}} - see "the result set concurrency is CONCUR_READ_ONLY" 7) {{JdbcThinResultSet.moveToCurrentRow}} - same as p.6 8) {{JdbcThinResultSet.getObject(int, Map)}} - why map is not used? should we support this method for now? 9) {{JdbcThinResultSet.getObject(String, Map)}} - why map is not used? should we support this method for now? 10) Getters with Calendar in params - why is it ignored? > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030894#comment-16030894 ] Taras Ledkov commented on IGNITE-5176: -- [Tests results|http://195.239.208.174/project.html?projectId=Ignite20Tests&tab=projectOverview&branch_Ignite20Tests=pull%2F2040%2Fhead] > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029587#comment-16029587 ] ASF GitHub Bot commented on IGNITE-5176: GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/2040 IGNITE-5176 JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2040 > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028471#comment-16028471 ] ASF GitHub Bot commented on IGNITE-5176: Github user tledkov-gridgain closed the pull request at: https://github.com/apache/ignite/pull/1994 > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028151#comment-16028151 ] Igor Sapego commented on IGNITE-5176: - [~tledkov-gridgain], I've finished with the C++ part. Tests also pass. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Igor Sapego > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026234#comment-16026234 ] Igor Sapego commented on IGNITE-5176: - [~tledkov-gridgain], why have you changed values of constants in {{SqlListenerRequest}}? You should have just add {{QRY_METADATA}} to the end of the list. This is totally unnecessary breaking change. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Igor Sapego > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024476#comment-16024476 ] Taras Ledkov commented on IGNITE-5176: -- {quote} The first page of query results is added to response on query execute. What is the reason for this change? {quote} The main reason is decrease TCP interaction. e.g.: Simple short queries will be required one TCP request / response instead of two. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Igor Sapego > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023142#comment-16023142 ] Igor Sapego commented on IGNITE-5176: - {quote} the first page of query results is added to response on query execute. {quote} What is the reason for this change? Overall, it seems like ODBC driver side will need pretty serious re-work and writing some new tests to cover affected functionality, just to be sure that nothing got broken. My estimation is that it will take 2-3 days to change C++ part accordingly. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Igor Sapego > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022616#comment-16022616 ] Taras Ledkov commented on IGNITE-5176: -- [Tests results|http://195.239.208.174/project.html?projectId=Ignite20Tests&tab=projectOverview&branch_Ignite20Tests=pull%2F1994%2Fhead] [~isapego], please review the changes. If you are OK with it please modify the ODBC native part according with protocol changes: - take a look at the {{SqlListenerQueryExecuteRequest}}, {{SqlListenerQueryMetadataRequest}} and {{SqlListenerQueryCursor#fetchRows}}; - metadata isn't sent in response on query execute separate new message is introduced to metadata gathering on demand; - the first page of query results is added to response on query execute. - the management of fetchSize (pageSize) and maxRows is moved on the server side. > JDBC Driver: implement query execution for thin jdbc driver based on common > odbc/jdbc protocol > -- > > Key: IGNITE-5176 > URL: https://issues.apache.org/jira/browse/IGNITE-5176 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.0 >Reporter: Taras Ledkov >Assignee: Taras Ledkov > Fix For: 2.1 > > > Implementation query execution & fetch results for thin JDBC driver over ODBC > protocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-5176) JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol
[ https://issues.apache.org/jira/browse/IGNITE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021180#comment-16021180 ] ASF GitHub Bot commented on IGNITE-5176: GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/1994 IGNITE-5176 JDBC Driver: implement query execution for thin jdbc driver based on common odbc/jdbc protocol You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1994 commit c7e215347e567f5c6c11954d932cfbb63743ec24 Author: tledkov-gridgain Date: 2017-05-04T14:59:38Z IGNITE-5163 save the progress commit b0023f87ab9f08063001bee77931ae9edc13487e Author: tledkov-gridgain Date: 2017-05-05T12:03:08Z IGNITE-5163 save the progress commit fa9fee2a996f676f2a1c3371adaf0a35ce2810f7 Author: tledkov-gridgain Date: 2017-05-05T12:03:14Z Merge branch '_master' into ignite-5163 commit dca4546b82547f1eef97e7bd1f3254914d3b5055 Author: tledkov-gridgain Date: 2017-05-05T12:06:04Z Merge branch '_master' into ignite-5163 commit db57be2da1beddc91df301033386f2a97ec578f2 Author: tledkov-gridgain Date: 2017-05-05T12:11:29Z IGNITE-5163: fix after merge commit 4412b1b085c7f81426e4d11b139ad856f0b6bf2d Author: tledkov-gridgain Date: 2017-05-05T12:33:10Z IGNITE-5163: minor commit d8d0a9b6309cd75b37ff50f18c22560a26c9c23b Author: tledkov-gridgain Date: 2017-05-05T14:02:46Z Merge branch 'master' into ignite-5163 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerProtocolVersion.java commit 7f60086405d8160c5d24f9a5cd36f99e81fd8e4e Author: tledkov-gridgain Date: 2017-05-05T14:54:15Z IGNITE-5163: fix after merge commit 461a6fe654db0e81f84c74649b5e88a703af80c9 Author: tledkov-gridgain Date: 2017-05-05T15:04:50Z IGNITE-5163: add properties to handshake commit abd3894dd3419bdc1a14f15893fc9737d1cd0761 Author: tledkov-gridgain Date: 2017-05-05T15:08:01Z IGNITE-5163: minors commit 7ddc2f7641f222a29dbc8caa5197f453db0d5981 Author: tledkov-gridgain Date: 2017-05-10T08:49:17Z Merge branch '_master' into ignite-5163 commit 9bfe91d3a597083da921220650c3e417dbb0b5c6 Author: devozerov Date: 2017-05-10T09:59:22Z Merge branch 'master' into ignite-5163 commit a303e25e5d1fe815e314d4fad2858d1d374487a8 Author: devozerov Date: 2017-05-10T10:24:00Z Review. commit 8b94095ab8ab8a70d7fc9ec20df52e0c19d5bd19 Author: devozerov Date: 2017-05-10T10:25:28Z Merge remote-tracking branch 'upstream/ignite-5163' into ignite-5163 # Conflicts: # modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDriver.java # modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcTcpIo.java commit e8eb3f519dbd8a1bca3acf42bb8b8477afc385e4 Author: tledkov-gridgain Date: 2017-05-11T12:03:18Z IGNITE-5163: fix review issues commit 081f27794d76adbf61add720dd0b1f88a69b373e Author: tledkov-gridgain Date: 2017-05-11T12:10:13Z IGNITE-5163: minors commit 0c045b61faa1791f7c4929f208bd0e83e3b581cb Author: tledkov-gridgain Date: 2017-05-11T12:59:54Z Merge branch '_master' into ignite-5163 commit d715f83068877c4532c9f0bcb008f2ab5e0571e1 Author: tledkov-gridgain Date: 2017-05-11T15:58:25Z IGNITE-5176: save the progress commit 9f1c6ac0c1223c550335387737b817ca491615c3 Author: tledkov-gridgain Date: 2017-05-12T11:57:08Z IGNITE-5176: save the progress commit 58417ef19844d625935b8d4ca7a3237cca7c72af Author: tledkov-gridgain Date: 2017-05-12T12:44:44Z Merge branch '_master' into ignite-5163 commit 80435c4344dea89a8f39fe4bfe6cc78174c2bede Author: tledkov-gridgain Date: 2017-05-12T12:45:42Z Merge branch '_master' into ignite-5176 commit 3e366385f336a385fd4c4818578626eeca73e38d Author: tledkov-gridgain Date: 2017-05-12T13:15:58Z IGNITE-5163: serialization refactoring commit e4e38acc67f0d607ac08d8e53ecece2459d6a364 Author: tledkov-gridgain Date: 2017-05-12T13:16:33Z Merge branch 'ignite-5163' into ignite-5176 commit 7b5a2987ac6128d341f8731544a754b11f93924b Author: tledkov-gridgain Date: 2017-05-12T13:44:33Z IGNITE-5176: save the progress commit a1e67bfcdbbfb290b912174531569c965b029f36 Author: tledkov-gridgain Date: 2017-05-12T13:47:39Z IGNITE-5163: serialization refactoring commit 2191a48e1e88f8d73250b4af360ed2e8ea9e64e7 Author: tledkov-gridgain Date: 2017-05-12T13:48:39Z Merge branch 'ignite-5163' into ignite-5176 commit 249b46aae7dee698fc34d0627f2407ad40d8da85 Author: tledkov-