[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259382#comment-16259382 ] Nikolay Tikhonov commented on IGNITE-5195: -- [~mcherkas], Thank you for your contribution! Looks good for me. Merged to master. > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Mikhail Cherkasov > Fix For: 2.4 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207684#comment-16207684 ] ASF GitHub Bot commented on IGNITE-5195: GitHub user ilantukh opened a pull request: https://github.com/apache/ignite/pull/2872 IGNITE-5195 : DataStreamer remap optimization. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2872.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2872 commit caa7f7c833a162a01edacb241634515cdce67ec2 Author: Ilya Lantukh Date: 2017-10-16T14:56:18Z ignite-5195 : DataStreamer remap optimization. commit 68b13fa248393c8ab75686c2956e84a2c5177839 Author: Ilya Lantukh Date: 2017-10-16T15:03:48Z ignite-5195 : Added test. commit e35b2d6508bd8b96c10d245253e066cdc2839a01 Author: Ilya Lantukh Date: 2017-10-17T13:50:53Z ignite-5195 : Fixed failing tests, simplified solution. > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Anton Vinogradov > Fix For: 2.4 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207683#comment-16207683 ] ASF GitHub Bot commented on IGNITE-5195: Github user ilantukh closed the pull request at: https://github.com/apache/ignite/pull/2862 > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Anton Vinogradov > Fix For: 2.4 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206026#comment-16206026 ] ASF GitHub Bot commented on IGNITE-5195: GitHub user ilantukh opened a pull request: https://github.com/apache/ignite/pull/2862 IGNITE-5195 : DataStreamer remap optimization. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2862.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2862 commit caa7f7c833a162a01edacb241634515cdce67ec2 Author: Ilya Lantukh Date: 2017-10-16T14:56:18Z ignite-5195 : DataStreamer remap optimization. > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Ilya Lantukh > Fix For: 2.4 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205695#comment-16205695 ] Mikhail Cherkasov commented on IGNITE-5195: --- I set priority to major because many users have faced with this problem and in an active cluster, where a lot of clients join and left cluster makes data streamer useless. > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Evgenii Zhuravlev > Fix For: 2.4 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151864#comment-16151864 ] Dmitriy Setrakyan commented on IGNITE-5195: --- Also, this is the forum thread describing this issue: http://apache-ignite-users.70518.x6.nabble.com/Failing-DataStreamer-beacuse-of-minor-version-change-td12142.html *I am surprised that a link to the user thread was not added to the ticket when it was filed. We must always be disciplined to do it.* Also, it looks like the exception thrown can be ignored (at least according to the responses in the thread). If an exception can be ignored, then it should not be an exception, it should be a warning. > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Assignee: Evgenii Zhuravlev >Priority: Minor > Fix For: 2.3 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5195) DataStreamer can fails if non-data node enter\leave the grid.
[ https://issues.apache.org/jira/browse/IGNITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007994#comment-16007994 ] Andrew Mashenkov commented on IGNITE-5195: -- There is another use case to be checked: if rising minor version topology can cause DataStreamer remapping procedure. E.g. clients connect to grid and register caches that rises minor topology version. If it so, then may be it would enough to make DataStreamer just ignore minor topology changes? > DataStreamer can fails if non-data node enter\leave the grid. > - > > Key: IGNITE-5195 > URL: https://issues.apache.org/jira/browse/IGNITE-5195 > Project: Ignite > Issue Type: Bug > Components: streaming >Affects Versions: 1.8 >Reporter: Andrew Mashenkov >Priority: Minor > Fix For: 2.2 > > Attachments: DataStreamerFailure.java > > > DataStreamer failed with "too many remaps" message even if non-data node > enter\leave topology. > PFA repro attached. > Seems, we should ignore topology changes when non-data node enter\leave the > grid. > And also we need to sure that remapping doesn't occurs when there is no data > nodes in grid any more, as remapping make no sense and more suitable message > should be logged. -- This message was sent by Atlassian JIRA (v6.3.15#6346)