[jira] [Commented] (IGNITE-5207) .NET: Non-Int32 enums can't be serialized

2017-05-15 Thread Pavel Tupitsyn (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010107#comment-16010107
 ] 

Pavel Tupitsyn commented on IGNITE-5207:


[~vozerov] no changes to the protocol.
* Enums can be {{byte}}, {{sbyte}}, {{short}}, {{ushort}}, {{int}}, {{uint}}, 
{{long}}, {{ulong}}.
* In 2.0 there is an exception for any non-Int32 enum.
* After this fix all enums that fit into 4 bytes are written in Ignite format. 
{{long}} and {{ulong}} enums are written as regular objects with a single field 
(via reflective serializer).


> .NET: Non-Int32 enums can't be serialized
> -
>
> Key: IGNITE-5207
> URL: https://issues.apache.org/jira/browse/IGNITE-5207
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.1
>
>
> There is no way to serialize non-Int32 enums. 
> Enums in .NET can be {{byte}}, {{sbyte}}, {{short}}, {{ushort}}, {{int}}, 
> {{uint}}, {{long}}, {{ulong}} (see 
> https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/keywords/enum).
> We should write all of these except {{long}} and {{ulong}} properly 
> (converting them to int and back).
> {{long}} and {{ulong}} enums should be written as object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5207) .NET: Non-Int32 enums can't be serialized

2017-05-15 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010035#comment-16010035
 ] 

Vladimir Ozerov commented on IGNITE-5207:
-

[~ptupitsyn], could you please clarify how this was fixed? Did it require any 
changes to the protocol?

> .NET: Non-Int32 enums can't be serialized
> -
>
> Key: IGNITE-5207
> URL: https://issues.apache.org/jira/browse/IGNITE-5207
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.1
>
>
> There is no way to serialize non-Int32 enums. 
> Enums in .NET can be {{byte}}, {{sbyte}}, {{short}}, {{ushort}}, {{int}}, 
> {{uint}}, {{long}}, {{ulong}} (see 
> https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/keywords/enum).
> We should write all of these except {{long}} and {{ulong}} properly 
> (converting them to int and back).
> {{long}} and {{ulong}} enums should be written as object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5207) .NET: Non-Int32 enums can't be serialized

2017-05-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007954#comment-16007954
 ] 

ASF GitHub Bot commented on IGNITE-5207:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1933


> .NET: Non-Int32 enums can't be serialized
> -
>
> Key: IGNITE-5207
> URL: https://issues.apache.org/jira/browse/IGNITE-5207
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.1
>
>
> There is no way to serialize non-Int32 enums. 
> Enums in .NET can be {{byte}}, {{sbyte}}, {{short}}, {{ushort}}, {{int}}, 
> {{uint}}, {{long}}, {{ulong}} (see 
> https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/keywords/enum).
> We should write all of these except {{long}} and {{ulong}} properly 
> (converting them to int and back).
> {{long}} and {{ulong}} enums should be written as object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5207) .NET: Non-Int32 enums can't be serialized

2017-05-12 Thread Pavel Tupitsyn (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007952#comment-16007952
 ] 

Pavel Tupitsyn commented on IGNITE-5207:


Fixed in master: 4b2b68434bf4560cb71485b93f366126730d59a7

> .NET: Non-Int32 enums can't be serialized
> -
>
> Key: IGNITE-5207
> URL: https://issues.apache.org/jira/browse/IGNITE-5207
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.1
>
>
> There is no way to serialize non-Int32 enums. 
> Enums in .NET can be {{byte}}, {{sbyte}}, {{short}}, {{ushort}}, {{int}}, 
> {{uint}}, {{long}}, {{ulong}} (see 
> https://docs.microsoft.com/en-us/dotnet/articles/csharp/language-reference/keywords/enum).
> We should write all of these except {{long}} and {{ulong}} properly 
> (converting them to int and back).
> {{long}} and {{ulong}} enums should be written as object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5207) .NET: Non-Int32 enums can't be serialized

2017-05-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007896#comment-16007896
 ] 

ASF GitHub Bot commented on IGNITE-5207:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/1933

IGNITE-5207 .NET: Support non-Int32 enums



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-5207

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1933.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1933


commit 79520ac9d6da1decebbe3a0e31abe48fc4c064b1
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:18:35Z

IGNITE-5207 .NET: Non-Int32 enums can't be serialized

commit 6279507ec929f1dd7ba938e2383766451253ab7b
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:21:38Z

failing test added

commit 79862815a2e2fada95a12caac138f604f32ac126
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:27:25Z

Easy fix implemented

commit b4ee2ea5faae143266693d27993cb36c03b15f20
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:42:37Z

wip tests

commit 1d14404a6b8cde039a5607fdc275bae5536aebd8
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:48:21Z

wip tests

commit 244d6540f2bfdc8b8224aa63a1c2b4edfca05a11
Author: Pavel Tupitsyn 
Date:   2017-05-12T08:50:08Z

wip

commit c29bf478d66da332fe6e00353c63239fab443149
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:00:53Z

wip

commit 12a9775fb70693fcd793b3eed028a5eee440dde8
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:07:55Z

wip

commit 88f1d6e59d5e4d153d4c2c66e5a98e177dbfece7
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:30:24Z

Refactor binary writers

commit a7b77be9ec56da3d627c9986daf7473a75b2c2a6
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:34:02Z

wip

commit 544e07d941d3321d6c431d08247df248dbf85003
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:50:39Z

wip

commit f6fc06c3d4092a3e77ece5f8ce64e46a12d9970a
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:52:49Z

wip

commit dffe685e28ce9e3a9de21e752489bdec97c760fd
Author: Pavel Tupitsyn 
Date:   2017-05-12T09:53:50Z

Enum handling done




> .NET: Non-Int32 enums can't be serialized
> -
>
> Key: IGNITE-5207
> URL: https://issues.apache.org/jira/browse/IGNITE-5207
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.0
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.1
>
>
> There is no way to serialize non-Int32 enums. We should write them in some 
> special way maybe.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)