[jira] [Commented] (IGNITE-5305) DDL: Set schema to cache configuration during CREATE TABLE

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034560#comment-16034560
 ] 

ASF GitHub Bot commented on IGNITE-5305:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2055


> DDL: Set schema to cache configuration during CREATE TABLE
> --
>
> Key: IGNITE-5305
> URL: https://issues.apache.org/jira/browse/IGNITE-5305
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> See {{GridQueryProcessor.dynamicTableCreate}} method. We have unused 
> parameter {{schemaName}}. It should be set to 
> {{CacheConfiguration.sqlSchema}}.
> If I try to do so, {{H2DynamicTableTest}} start to hang due to exception in 
> exchange thread due to some error in indexing engine. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5305) DDL: Set schema to cache configuration during CREATE TABLE

2017-06-01 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032939#comment-16032939
 ] 

Vladimir Ozerov commented on IGNITE-5305:
-

[~al.psc], my comments:
1) I make a check for public schema earlier in execution pipeline.
2) I fixed test so that {{DROP TABLE}} also goes through public schema. Now 
{{testDropNonDynamicTable}} started to fail. It should be re-written or fixed.


> DDL: Set schema to cache configuration during CREATE TABLE
> --
>
> Key: IGNITE-5305
> URL: https://issues.apache.org/jira/browse/IGNITE-5305
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> See {{GridQueryProcessor.dynamicTableCreate}} method. We have unused 
> parameter {{schemaName}}. It should be set to 
> {{CacheConfiguration.sqlSchema}}.
> If I try to do so, {{H2DynamicTableTest}} start to hang due to exception in 
> exchange thread due to some error in indexing engine. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5305) DDL: Set schema to cache configuration during CREATE TABLE

2017-06-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032678#comment-16032678
 ] 

ASF GitHub Bot commented on IGNITE-5305:


GitHub user alexpaschenko opened a pull request:

https://github.com/apache/ignite/pull/2055

IGNITE-5305 Correct schema in GridQueryProcessor.dynamicTableCreate



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5305

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2055


commit a0504b74a37ac07228c828a5445cc556ed997d7d
Author: Alexander Paschenko 
Date:   2017-06-01T09:17:05Z

IGNITE-5305 Correct schema in GridQueryProcessor.dynamicTableCreate




> DDL: Set schema to cache configuration during CREATE TABLE
> --
>
> Key: IGNITE-5305
> URL: https://issues.apache.org/jira/browse/IGNITE-5305
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> See {{GridQueryProcessor.dynamicTableCreate}} method. We have unused 
> parameter {{schemaName}}. It should be set to 
> {{CacheConfiguration.sqlSchema}}.
> If I try to do so, {{H2DynamicTableTest}} start to hang due to exception in 
> exchange thread due to some error in indexing engine. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)