[jira] [Commented] (IGNITE-5327) Create predefined cache templates for CREATE TABLE command

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034801#comment-16034801
 ] 

ASF GitHub Bot commented on IGNITE-5327:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2056


> Create predefined cache templates for CREATE TABLE command
> --
>
> Key: IGNITE-5327
> URL: https://issues.apache.org/jira/browse/IGNITE-5327
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> We need to add predefined templates which will always be available on the 
> node. Let's avoid adding them to node configuration to avoid cache data 
> sharing on node startup. Instead, let's just create them on-fly when certain 
> template name is found.
> Proposed templates:
> 1) "PARTITIONED" => {{new CacheConfiguration().setCacheMode(PARTITIONED)}}
> 2) "REPLICATED" => {{new CacheConfiguration().setCacheMode(REPLICATED)}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5327) Create predefined cache templates for CREATE TABLE command

2017-06-01 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032923#comment-16032923
 ] 

Vladimir Ozerov commented on IGNITE-5327:
-

[~al.psc], in general fix looks good, but I would add several usability 
improvements:
1) Let's use {{PARTITIONED}} template by default if {{template}} parameter is 
not provided at all. This is precisely how {{Ignite.createCache(new 
CacheConfiguration())}} works. Additional tests are needed for this.
2) Let's perform case insensitive comparison for {{PARTITIONED}} and 
{{REPLICATED}} caches. This way both {{template=PARTITIONED}} and 
{{template=partitioned}} will work.

> Create predefined cache templates for CREATE TABLE command
> --
>
> Key: IGNITE-5327
> URL: https://issues.apache.org/jira/browse/IGNITE-5327
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> We need to add predefined templates which will always be available on the 
> node. Let's avoid adding them to node configuration to avoid cache data 
> sharing on node startup. Instead, let's just create them on-fly when certain 
> template name is found.
> Proposed templates:
> 1) "PARTITIONED" => {{new CacheConfiguration().setCacheMode(PARTITIONED)}}
> 2) "REPLICATED" => {{new CacheConfiguration().setCacheMode(REPLICATED)}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5327) Create predefined cache templates for CREATE TABLE command

2017-06-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032746#comment-16032746
 ] 

ASF GitHub Bot commented on IGNITE-5327:


GitHub user alexpaschenko opened a pull request:

https://github.com/apache/ignite/pull/2056

IGNITE-5327 PARTITIONED and REPLICATED cache templates



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5327

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2056


commit e03c7b552ea11e89f47ad4c3a34b076855e77487
Author: Alexander Paschenko 
Date:   2017-06-01T10:16:23Z

IGNITE-5327 PARTITIONED and REPLICATED cache templates




> Create predefined cache templates for CREATE TABLE command
> --
>
> Key: IGNITE-5327
> URL: https://issues.apache.org/jira/browse/IGNITE-5327
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> We need to add predefined templates which will always be available on the 
> node. Let's avoid adding them to node configuration to avoid cache data 
> sharing on node startup. Instead, let's just create them on-fly when certain 
> template name is found.
> Proposed templates:
> 1) "PARTITIONED" => {{new CacheConfiguration().setCacheMode(PARTITIONED)}}
> 2) "REPLICATED" => {{new CacheConfiguration().setCacheMode(REPLICATED)}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)