[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-06-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034532#comment-16034532
 ] 

ASF GitHub Bot commented on IGNITE-5335:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2034


> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.1
>
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-06-01 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032715#comment-16032715
 ] 

Sergey Kalashnikov commented on IGNITE-5335:


[~vozerov], You are right. I have fixed that too and added a test. Please see 
again.

> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.1
>
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-05-31 Thread Vladimir Ozerov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031674#comment-16031674
 ] 

Vladimir Ozerov commented on IGNITE-5335:
-

[~skalashnikov], looks like we should also fix this in 
{{org.apache.ignite.internal.binary.BinaryFieldImpl#readField}}. Please confirm.

> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.1
>
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-05-30 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029442#comment-16029442
 ] 

Sergey Kalashnikov commented on IGNITE-5335:


[~vozerov],
Tests looks good. Could you please review the changes?

> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.1
>
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-05-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029298#comment-16029298
 ] 

ASF GitHub Bot commented on IGNITE-5335:


GitHub user skalashnikov opened a pull request:

https://github.com/apache/ignite/pull/2034

IGNITE-5335: Fixed reading decimal binary field



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5335

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2034


commit 78a118c1c25e9e8afc2f4721f40d65ce2646e5de
Author: skalashnikov 
Date:   2017-05-30T11:49:49Z

IGNITE-5335: Fixed reading decimal binary field




> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>  Labels: important
> Fix For: 2.1
>
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (IGNITE-5335) Wrong value read by SQL query for field containing negative decimal

2017-05-29 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028507#comment-16028507
 ] 

Sergey Kalashnikov commented on IGNITE-5335:


Attached the reproducer

> Wrong value read by SQL query for field containing negative decimal
> ---
>
> Key: IGNITE-5335
> URL: https://issues.apache.org/jira/browse/IGNITE-5335
> Project: Ignite
>  Issue Type: Bug
>  Components: binary, sql
>Affects Versions: 2.0
>Reporter: Sergey Kalashnikov
> Attachments: BinaryObjectFieldDecimalTest.java
>
>
> Steps to reproduce:
> 1) Create a cache with value type having some decimal field.
> 2) Instantiate a value, intialize decimal field with a negative value and put 
> it to the cache.
> 3) Perform an sql query on the decimal field.
> 4) Check the selected value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)