[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[Vitaliy Biryukov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087259#comment-16087259
 ] 

Vitaliy Biryukov  commented on IGNITE-5452:
---

[~amashenkov],
Done.
http://ci.ignite.apache.org/viewLog.html?buildId=726244=buildResultsDiv=Ignite20Tests_RunAll

> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085820#comment-16085820
 ] 

Andrew Mashenkov commented on IGNITE-5452:
--

[~VitaliyB]

See my comments in UpSource.
Please, check all you tests are present in TestSuites and run TC tests [1] 
after all issues will be fixed.

[1] 
http://ci.ignite.apache.org/project.html?projectId=Ignite20Tests_Ignite20Tests=pull%2F2279%2Fhead

> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[Vitaliy Biryukov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085405#comment-16085405
 ] 

Vitaliy Biryukov  commented on IGNITE-5452:
---

[~amashenkov],
Done.

> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083788#comment-16083788
 ] 

Andrew Mashenkov commented on IGNITE-5452:
--

[~VitaliyB],

See my comments in UpSource.



> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[Vitaliy Biryukov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082185#comment-16082185
 ] 

Vitaliy Biryukov  commented on IGNITE-5452:
---

Ready to review.

[~amashenkov], please take a look.

> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5452) Tx with timeout can make node can hang on stop.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082174#comment-16082174
 ] 

ASF GitHub Bot commented on IGNITE-5452:


GitHub user BiryukovVA opened a pull request:

https://github.com/apache/ignite/pull/2279

Merge remote-tracking branch 'upstream/master' into IGNITE-5452

IGNITE-5452:
1) Handled eaten InterruptedException in TimeoutObject.
2) Test correctness of rollback a transaction with timeout during the grid 
stop.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BiryukovVA/ignite IGNITE-5452

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2279


commit b2be98aff13d239dc0999491ebde52bd450a0bd0
Author: Vitaliy Biryukov 
Date:   2017-07-11T13:06:10Z

IGNITE-5452:
1) Handled eaten InterruptedException in TimeoutObject.
2) Test correctness of rollback a transaction with timeout during the grid 
stop.

commit e663bb37d86dfb4e6a57ba95629d2635e4cb92cc
Author: Vitaliy Biryukov 
Date:   2017-07-11T13:09:00Z

Merge remote-tracking branch 'upstream/master' into IGNITE-5452




> Tx with timeout can make node can hang on stop.
> ---
>
> Key: IGNITE-5452
> URL: https://issues.apache.org/jira/browse/IGNITE-5452
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Andrew Mashenkov
>Assignee: Vitaliy Biryukov 
> Fix For: 2.2
>
> Attachments: LockTimeoutFailedOnStop.java
>
>
> PFA repro attached.
> Actually, there are 2 issue.
> 1. GridTimeoutProcessor can't be stopped if TimeoutObject eats 
> InterruptedException. We should handle this correctly.
> 2. TX use TimeoutObjects to be rolled back by timeout.  However, TXs doesn't 
> remove their TimeoutObjects on node stop. 
> Possible, TimeoutObject doesn't removed on TX rollback and this should be 
> investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)