[jira] [Commented] (IGNITE-5505) @AffinityKeyMapped annotation is ignored if class names are configured on BinaryConfiguration

2017-08-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130331#comment-16130331
 ] 

ASF GitHub Bot commented on IGNITE-5505:


Github user kukushal closed the pull request at:

https://github.com/apache/ignite/pull/2270


> @AffinityKeyMapped annotation is ignored if class names are configured on 
> BinaryConfiguration
> -
>
> Key: IGNITE-5505
> URL: https://issues.apache.org/jira/browse/IGNITE-5505
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.7
>Reporter: Andrey Gura
>Assignee: Alexey Kukushkin
> Fix For: 2.2
>
>
> {{@AffinityKeyMapped}} annotation on key class field is ignored in case when 
> class names passed to {{inaryConfiguration}} via {{setClassNames()}} method.
> The problem is that Ignite uses {{IgniteConfiguration.cacheKeyCfg}} during 
> {{BinaryContext.configure()}} execution and doesn't check class fileds on 
> {{@AffinityKeyMapped}} annotation.
> Possible solution: check class fields on {{@AffinityKeyMapped}} annotation if 
> there is no any mapping for cache key type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5505) @AffinityKeyMapped annotation is ignored if class names are configured on BinaryConfiguration

2017-08-04 Thread Alexey Kukushkin (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114470#comment-16114470
 ] 

Alexey Kukushkin commented on IGNITE-5505:
--

I discussed this with [~vozerov] again and confirmed we do not want to fix this 
since any fix would violate Ignite design ideology. 
To work around the problem in addition to specifying affinity key field using 
@AffinityKeyMapped annotation also specify it in the cache key configuration 
like this:




...










Resolving this issue with a fix.

> @AffinityKeyMapped annotation is ignored if class names are configured on 
> BinaryConfiguration
> -
>
> Key: IGNITE-5505
> URL: https://issues.apache.org/jira/browse/IGNITE-5505
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.7
>Reporter: Andrey Gura
>Assignee: Alexey Kukushkin
> Fix For: 2.2
>
>
> {{@AffinityKeyMapped}} annotation on key class field is ignored in case when 
> class names passed to {{inaryConfiguration}} via {{setClassNames()}} method.
> The problem is that Ignite uses {{IgniteConfiguration.cacheKeyCfg}} during 
> {{BinaryContext.configure()}} execution and doesn't check class fileds on 
> {{@AffinityKeyMapped}} annotation.
> Possible solution: check class fields on {{@AffinityKeyMapped}} annotation if 
> there is no any mapping for cache key type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5505) @AffinityKeyMapped annotation is ignored if class names are configured on BinaryConfiguration

2017-07-21 Thread Dmitry Karachentsev (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095907#comment-16095907
 ] 

Dmitry Karachentsev commented on IGNITE-5505:
-

Looks like I faced the same issue [IGNITE-5795]. If it won't be fixed, it 
should be at least documented.

> @AffinityKeyMapped annotation is ignored if class names are configured on 
> BinaryConfiguration
> -
>
> Key: IGNITE-5505
> URL: https://issues.apache.org/jira/browse/IGNITE-5505
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.7
>Reporter: Andrey Gura
>Assignee: Alexey Kukushkin
> Fix For: 2.2
>
>
> {{@AffinityKeyMapped}} annotation on key class field is ignored in case when 
> class names passed to {{inaryConfiguration}} via {{setClassNames()}} method.
> The problem is that Ignite uses {{IgniteConfiguration.cacheKeyCfg}} during 
> {{BinaryContext.configure()}} execution and doesn't check class fileds on 
> {{@AffinityKeyMapped}} annotation.
> Possible solution: check class fields on {{@AffinityKeyMapped}} annotation if 
> there is no any mapping for cache key type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5505) @AffinityKeyMapped annotation is ignored if class names are configured on BinaryConfiguration

2017-07-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080153#comment-16080153
 ] 

ASF GitHub Bot commented on IGNITE-5505:


GitHub user kukushal opened a pull request:

https://github.com/apache/ignite/pull/2270

IGNITE-5505 @AffinityKeyMapped annotation is ignored if class names are 
configured on BinaryConfiguration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-gg-5505

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2270


commit c0a0e1340d3576b9880eaf9c9ad431cde85e5429
Author: Alexey Kukushkin 
Date:   2017-07-07T15:54:39Z

test for IGNITE-5505

commit 67e1457d4fd62bbd5004a60a8d3e1799b4125c9a
Author: Alexey Kukushkin 
Date:   2017-07-07T16:49:23Z

Fix code style

commit 5023ff50fb461d37fb2b05a7c8a01fc6091028ba
Author: Alexey Kukushkin 
Date:   2017-07-10T10:44:49Z

Solution for IGNITE-5505




> @AffinityKeyMapped annotation is ignored if class names are configured on 
> BinaryConfiguration
> -
>
> Key: IGNITE-5505
> URL: https://issues.apache.org/jira/browse/IGNITE-5505
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.7
>Reporter: Andrey Gura
>Assignee: Alexey Kukushkin
>
> {{@AffinityKeyMapped}} annotation on key class field is ignored in case when 
> class names passed to {{inaryConfiguration}} via {{setClassNames()}} method.
> The problem is that Ignite uses {{IgniteConfiguration.cacheKeyCfg}} during 
> {{BinaryContext.configure()}} execution and doesn't check class fileds on 
> {{@AffinityKeyMapped}} annotation.
> Possible solution: check class fields on {{@AffinityKeyMapped}} annotation if 
> there is no any mapping for cache key type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)