[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[
https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096186#comment-16096186
]
Pavel Tupitsyn commented on IGNITE-5791:
Looks good, merged to master: {{0d2b989d2be62533a36061940497a734463b5f10}}
> Block matrix Introduction
> -
>
> Key: IGNITE-5791
> URL: https://issues.apache.org/jira/browse/IGNITE-5791
> Project: Ignite
> Issue Type: Sub-task
> Components: ml
>Reporter: Yury Babak
>Assignee: Yury Babak
> Fix For: 2.2
>
>
> Introduction of sparce distributed block matrix with more efficient
> multiplication rather than row/col distributed matrix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[ https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096160#comment-16096160 ] Yury Babak commented on IGNITE-5791: [~ptupitsyn], fixed in last commit. > Block matrix Introduction > - > > Key: IGNITE-5791 > URL: https://issues.apache.org/jira/browse/IGNITE-5791 > Project: Ignite > Issue Type: Sub-task > Components: ml >Reporter: Yury Babak >Assignee: Yury Babak > Fix For: 2.2 > > > Introduction of sparce distributed block matrix with more efficient > multiplication rather than row/col distributed matrix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[
https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096157#comment-16096157
]
Pavel Tupitsyn commented on IGNITE-5791:
[~chief] some TODOs are still there:
* {{CacheUtils.java}}
* {{SparseDistributedMatrixTest.java}}
> Block matrix Introduction
> -
>
> Key: IGNITE-5791
> URL: https://issues.apache.org/jira/browse/IGNITE-5791
> Project: Ignite
> Issue Type: Sub-task
> Components: ml
>Reporter: Yury Babak
>Assignee: Yury Babak
> Fix For: 2.2
>
>
> Introduction of sparce distributed block matrix with more efficient
> multiplication rather than row/col distributed matrix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[ https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096155#comment-16096155 ] Yury Babak commented on IGNITE-5791: [~ptupitsyn], please have a look again NB: I've created https://issues.apache.org/jira/browse/IGNITE-5802 for all our other wrong TODO. I`ll solve this ticket during next week. > Block matrix Introduction > - > > Key: IGNITE-5791 > URL: https://issues.apache.org/jira/browse/IGNITE-5791 > Project: Ignite > Issue Type: Sub-task > Components: ml >Reporter: Yury Babak >Assignee: Yury Babak > Fix For: 2.2 > > > Introduction of sparce distributed block matrix with more efficient > multiplication rather than row/col distributed matrix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[
https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096118#comment-16096118
]
Pavel Tupitsyn commented on IGNITE-5791:
[~chief] my comments:
* All {{TODO}}s must include JIRA links, see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs
* {{Matrix.java}} has commented-out {{map}} method, please remove.
* Argument validation is missing in some places. Internal code (example:
{{CacheUtils}}) should use {{assert}}, public APIs (example:
{{SparseBlockDistributedMatrix.times()}}, mtx can be null) must throw
exceptions for invalid arguments.
* {{checkRowIndex}}: Should we include rowSize in exception text instead of
writing this to console?
> Block matrix Introduction
> -
>
> Key: IGNITE-5791
> URL: https://issues.apache.org/jira/browse/IGNITE-5791
> Project: Ignite
> Issue Type: Sub-task
> Components: ml
>Reporter: Yury Babak
>Assignee: Yury Babak
> Fix For: 2.2
>
>
> Introduction of sparce distributed block matrix with more efficient
> multiplication rather than row/col distributed matrix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[ https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096100#comment-16096100 ] Yury Babak commented on IGNITE-5791: [~ptupitsyn], please have a look > Block matrix Introduction > - > > Key: IGNITE-5791 > URL: https://issues.apache.org/jira/browse/IGNITE-5791 > Project: Ignite > Issue Type: Sub-task > Components: ml >Reporter: Yury Babak >Assignee: Yury Babak > Fix For: 2.2 > > > Introduction of sparce distributed block matrix with more efficient > multiplication rather than row/col distributed matrix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5791) Block matrix Introduction
[ https://issues.apache.org/jira/browse/IGNITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094800#comment-16094800 ] Yury Babak commented on IGNITE-5791: Pull request: https://github.com/apache/ignite/pull/2326 Reviewed by [~oignatenko] > Block matrix Introduction > - > > Key: IGNITE-5791 > URL: https://issues.apache.org/jira/browse/IGNITE-5791 > Project: Ignite > Issue Type: Sub-task > Components: ml >Reporter: Yury Babak >Assignee: Yury Babak > Fix For: 2.2 > > > Introduction of sparce distributed block matrix with more efficient > multiplication rather than row/col distributed matrix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
