[jira] [Commented] (IGNITE-5859) IgniteUtils.ceilPow2 overflow for values greater than 2^30

2018-12-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725025#comment-16725025
 ] 

ASF GitHub Bot commented on IGNITE-5859:


Github user BiryukovVA closed the pull request at:

https://github.com/apache/ignite/pull/2355


> IgniteUtils.ceilPow2 overflow for values greater than 2^30
> --
>
> Key: IGNITE-5859
> URL: https://issues.apache.org/jira/browse/IGNITE-5859
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vitaliy Biryukov
>Assignee: Vitaliy Biryukov
>Priority: Major
> Attachments: CeilPow2Test.java
>
>
> Method "IgniteUtils.ceilPow2" can overflow for values greater than 2^30 and 
> return Integer.MIN_VALUE for them.
> Maybe this check was skipped for method speed. In this case, we need to add 
> information about this into javaDoc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-5859) IgniteUtils.ceilPow2 overflow for values greater than 2^30

2017-07-29 Thread Vitaliy Biryukov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106250#comment-16106250
 ] 

Vitaliy Biryukov  commented on IGNITE-5859:
---

[~avinogradov], [~chief], Done.
http://ci.ignite.apache.org/viewLog.html?buildId=744804&tab=buildResultsDiv&buildTypeId=Ignite20Tests_RunAll

> IgniteUtils.ceilPow2 overflow for values greater than 2^30
> --
>
> Key: IGNITE-5859
> URL: https://issues.apache.org/jira/browse/IGNITE-5859
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vitaliy Biryukov 
>Assignee: Vitaliy Biryukov 
> Attachments: CeilPow2Test.java
>
>
> Method "IgniteUtils.ceilPow2" can overflow for values greater than 2^30 and 
> return Integer.MIN_VALUE for them.
> Maybe this check was skipped for method speed. In this case, we need to add 
> information about this into javaDoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5859) IgniteUtils.ceilPow2 overflow for values greater than 2^30

2017-07-28 Thread Yury Babak (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104789#comment-16104789
 ] 

Yury Babak commented on IGNITE-5859:


[~avinogradov] looks fine for me.

[~VitaliyB] please run all related tests on TC and link the result, just for 
avoid of regression.

> IgniteUtils.ceilPow2 overflow for values greater than 2^30
> --
>
> Key: IGNITE-5859
> URL: https://issues.apache.org/jira/browse/IGNITE-5859
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vitaliy Biryukov 
>Assignee: Vitaliy Biryukov 
> Attachments: CeilPow2Test.java
>
>
> Method "IgniteUtils.ceilPow2" can overflow for values greater than 2^30 and 
> return Integer.MIN_VALUE for them.
> Maybe this check was skipped for method speed. In this case, we need to add 
> information about this into javaDoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5859) IgniteUtils.ceilPow2 overflow for values greater than 2^30

2017-07-27 Thread Vitaliy Biryukov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103606#comment-16103606
 ] 

Vitaliy Biryukov  commented on IGNITE-5859:
---

[~avinogradov], please take a look.

Issue was created after:
http://apache-ignite-developers.2346864.n4.nabble.com/Bug-in-method-tt20122.html

> IgniteUtils.ceilPow2 overflow for values greater than 2^30
> --
>
> Key: IGNITE-5859
> URL: https://issues.apache.org/jira/browse/IGNITE-5859
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vitaliy Biryukov 
>Assignee: Vitaliy Biryukov 
> Attachments: CeilPow2Test.java
>
>
> Method "IgniteUtils.ceilPow2" can overflow for values greater than 2^30 and 
> return Integer.MIN_VALUE for them.
> Maybe this check was skipped for method speed. In this case, we need to add 
> information about this into javaDoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (IGNITE-5859) IgniteUtils.ceilPow2 overflow for values greater than 2^30

2017-07-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103561#comment-16103561
 ] 

ASF GitHub Bot commented on IGNITE-5859:


GitHub user BiryukovVA opened a pull request:

https://github.com/apache/ignite/pull/2355

IGNITE-5859: Utils.ceilPow2 method fixed.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BiryukovVA/ignite IGNITE-5859

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2355


commit b2c4c01d8bccc55532de276cdca24ab23680fcc6
Author: Vitaliy Biryukov 
Date:   2017-07-27T17:38:08Z

IGNITE-5859: Utils.ceilPow2 method fixed.




> IgniteUtils.ceilPow2 overflow for values greater than 2^30
> --
>
> Key: IGNITE-5859
> URL: https://issues.apache.org/jira/browse/IGNITE-5859
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vitaliy Biryukov 
>Assignee: Vitaliy Biryukov 
> Attachments: CeilPow2Test.java
>
>
> Method "IgniteUtils.ceilPow2" can overflow for values greater than 2^30 and 
> return Integer.MIN_VALUE for them.
> Maybe this check was skipped for method speed. In this case, we need to add 
> information about this into javaDoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)