[jira] [Commented] (IGNITE-5924) .NET: Decouple Marshaller from Ignite

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148837#comment-16148837
 ] 

ASF GitHub Bot commented on IGNITE-5924:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2559


> .NET: Decouple Marshaller from Ignite
> -
>
> Key: IGNITE-5924
> URL: https://issues.apache.org/jira/browse/IGNITE-5924
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> {{Marshaller}} class has {{Ignite}} property, which is used everywhere as a 
> convenient accessor.
> With thin client we don't have an {{Ignite}} instance ({{IgniteClient}} is 
> there instead). 
> Also, {{Marshaller}} itself only needs {{Ignite.BinaryProcessor}}, which is 
> also tied to JNI.
> So the plan is:
> * Add {{IBinaryProcessor}} interface
> * Replace {{Marshaller.Ignite}} with {{Marshaller.BinaryProcessor}}
> * Fix external {{Marshaller.Ignite}} usages in some way



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5924) .NET: Decouple Marshaller from Ignite

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148836#comment-16148836
 ] 

Pavel Tupitsyn commented on IGNITE-5924:


{{IIgniteInternal}} introduced, most {{Ignite}} usages replaced.
Merged to master: {{8629b50d6ff490fa2a13f829f9dc35661a3fdbeb}}.

> .NET: Decouple Marshaller from Ignite
> -
>
> Key: IGNITE-5924
> URL: https://issues.apache.org/jira/browse/IGNITE-5924
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> {{Marshaller}} class has {{Ignite}} property, which is used everywhere as a 
> convenient accessor.
> With thin client we don't have an {{Ignite}} instance ({{IgniteClient}} is 
> there instead). 
> Also, {{Marshaller}} itself only needs {{Ignite.BinaryProcessor}}, which is 
> also tied to JNI.
> So the plan is:
> * Add {{IBinaryProcessor}} interface
> * Replace {{Marshaller.Ignite}} with {{Marshaller.BinaryProcessor}}
> * Fix external {{Marshaller.Ignite}} usages in some way



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5924) .NET: Decouple Marshaller from Ignite

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148757#comment-16148757
 ] 

ASF GitHub Bot commented on IGNITE-5924:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/2559

IGNITE-5924 .NET: Decouple Marshaller from Ignite



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-5924-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2559


commit 5b86262531e2238d0c987b9d8710114e2f738436
Author: Pavel Tupitsyn 
Date:   2017-08-31T09:30:03Z

IGNITE-5924 .NET: Decouple Marshaller from Ignite

commit 9c296ecffea5a1c9de56a4ce77a2ce3aa49ef60b
Author: Pavel Tupitsyn 
Date:   2017-08-31T09:46:42Z

Refactor Ignite to IIgniteInternal

commit 2a9919161c524bccc439cc5a1524c26682528485
Author: Pavel Tupitsyn 
Date:   2017-08-31T09:49:27Z

cleanup

commit 78cf67efc02702c65f1e52259e25e9b596d68bec
Author: Pavel Tupitsyn 
Date:   2017-08-31T09:50:26Z

Cleanup




> .NET: Decouple Marshaller from Ignite
> -
>
> Key: IGNITE-5924
> URL: https://issues.apache.org/jira/browse/IGNITE-5924
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> {{Marshaller}} class has {{Ignite}} property, which is used everywhere as a 
> convenient accessor.
> With thin client we don't have an {{Ignite}} instance ({{IgniteClient}} is 
> there instead). 
> Also, {{Marshaller}} itself only needs {{Ignite.BinaryProcessor}}, which is 
> also tied to JNI.
> So the plan is:
> * Add {{IBinaryProcessor}} interface
> * Replace {{Marshaller.Ignite}} with {{Marshaller.BinaryProcessor}}
> * Fix external {{Marshaller.Ignite}} usages in some way



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5924) .NET: Decouple Marshaller from Ignite

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147656#comment-16147656
 ] 

Pavel Tupitsyn commented on IGNITE-5924:


May be we should introduce {{IIgniteInternal}} interface instead to decouple 
from concrete implementation.

> .NET: Decouple Marshaller from Ignite
> -
>
> Key: IGNITE-5924
> URL: https://issues.apache.org/jira/browse/IGNITE-5924
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> {{Marshaller}} class has {{Ignite}} property, which is used everywhere as a 
> convenient accessor.
> With thin client we don't have an {{Ignite}} instance ({{IgniteClient}} is 
> there instead). 
> Also, {{Marshaller}} itself only needs {{Ignite.BinaryProcessor}}, which is 
> also tied to JNI.
> So the plan is:
> * Add {{IBinaryProcessor}} interface
> * Replace {{Marshaller.Ignite}} with {{Marshaller.BinaryProcessor}}
> * Fix external {{Marshaller.Ignite}} usages in some way



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)